Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. As suggested by Gaeton, I've also removed --enable-maintainer-mode from autogen.sh Merged 262679d..4bf3eac master - master Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,6 @@ RELEASE_DATE=2012-09-05 RELEASE_NAME=Iced Tea AC_CONFIG_SRCDIR([Makefile.am]) AM_INIT_AUTOMAKE([foreign dist-bzip2]) -AM_MAINTAINER_MODE # Require xorg-macros minimum of 1.14 for XORG_COMPILER_BRAND in XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MACROS_VERSION], -- 1.7.12 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel -- keith.pack...@intel.com pgpo5HmZsxcU1.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On Sun, Sep 30, 2012 at 16:45:17 -0400, Gaetan Nadon wrote: On 12-09-29 04:37 PM, Dan Nicholson wrote: Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) Oh, yeah. That would be the best. The historical background is that mode was added as a CVS tarball timestamp loss workaround before the git days. Whoever wishes to keep this workaround should demonstrate that they extract tarballs from CVS and want to prevent the build to re-create the configuration because the timestamp was lost and files appear to be out-of-date. Well for us as I recall it was not so much cvs as - extract tarball - patch configure.ac and configure (or Makefile.am and Makefile.in, whatever) - run configure make - make tries to run some autotool because the timestamps are screwed up and it thinks the generated file is out of date - that fails because the autotools aren't installed in your build chroot. Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
LOn Oct 2, 2012 1:09 PM, Julien Cristau jcris...@debian.org wrote: On Sun, Sep 30, 2012 at 16:45:17 -0400, Gaetan Nadon wrote: On 12-09-29 04:37 PM, Dan Nicholson wrote: Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) Oh, yeah. That would be the best. The historical background is that mode was added as a CVS tarball timestamp loss workaround before the git days. Whoever wishes to keep this workaround should demonstrate that they extract tarballs from CVS and want to prevent the build to re-create the configuration because the timestamp was lost and files appear to be out-of-date. Well for us as I recall it was not so much cvs as - extract tarball - patch configure.ac and configure (or Makefile.am and Makefile.in, whatever) - run configure make - make tries to run some autotool because the timestamps are screwed up and it thinks the generated file is out of date - that fails because the autotools aren't installed in your build chroot. Yes, that's what I was thinking of. -- Dan ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On 12-10-02 04:09 PM, Julien Cristau wrote: On Sun, Sep 30, 2012 at 16:45:17 -0400, Gaetan Nadon wrote: On 12-09-29 04:37 PM, Dan Nicholson wrote: Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) Oh, yeah. That would be the best. The historical background is that mode was added as a CVS tarball timestamp loss workaround before the git days. Whoever wishes to keep this workaround should demonstrate that they extract tarballs from CVS and want to prevent the build to re-create the configuration because the timestamp was lost and files appear to be out-of-date. Well for us as I recall it was not so much cvs as - extract tarball - patch configure.ac and configure (or Makefile.am and Makefile.in, whatever) - run configure make - make tries to run some autotool because the timestamps are screwed up and it thinks the generated file is out of date - that fails because the autotools aren't installed in your build chroot. Cheers, Julien I could have misinterpreted what is written in here http://lists.gnu.org/archive/html/automake/2003-02/msg00036.html, but it looks like timestamps were screwed up right after extracting from CVS, no need to actually edit any config files. I guess there could be other scenarios as well. I mentioned this because most people don't know why the code is the way it is today. That was done like 10 years or so ago. I'd rather delete the workaround code as opposed to make it dead code and having to explain it for the next 20 years. It'd be nice to hear from people who actually lived trough this era as I just read about it. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On 12-09-27 05:12 PM, Adam Jackson wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,6 @@ RELEASE_DATE=2012-09-05 RELEASE_NAME=Iced Tea AC_CONFIG_SRCDIR([Makefile.am]) AM_INIT_AUTOMAKE([foreign dist-bzip2]) -AM_MAINTAINER_MODE # Require xorg-macros minimum of 1.14 for XORG_COMPILER_BRAND in XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MACROS_VERSION], This is the right thing to do. A couple of improvements: * A more technical explanation in the commit text. I like to refer to the AM_MAINTAINER mode as a CVS timestamp losssage workaround. The full background can be found here: http://lists.gnu.org/archive/html/automake/2003-02/msg00036.html * The autogen.sh file must be changed to remove the --enable-maintainer-mode parameter which belongs to AM_MAINTAINER_MODE. Otherwise you get: configure: WARNING: unrecognized options: --enable-maintainer-mode In essence we are removing configuration code which was put in place as a work around to a CVS behaviour which caused the downloaded tar file content to always be out-of-date and rebuilt. This workaround is no longer required, if it ever has been. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On 12-09-29 04:37 PM, Dan Nicholson wrote: Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) Oh, yeah. That would be the best. The historical background is that mode was added as a CVS tarball timestamp loss workaround before the git days. Whoever wishes to keep this workaround should demonstrate that they extract tarballs from CVS and want to prevent the build to re-create the configuration because the timestamp was lost and files appear to be out-of-date. The most desirable option is to remove both the --enable-maintainer-mode parameter in autohen.sh (to avoid introducing a new warning) and the AM_MAINTAINER_MODE statement in configure.ac. This will relieve people who edit configure.ac from a tarball. As it is today, the configuration is not re-creared. That is why people insisted on keeping autogen.sh in tarballs, which was a workaround to the CVS workaround. Peter is right, it should be done in all the repos. The patch is incomplete. It will introduce a new warning as the option --enable-maintainer-mode is not recognized because of the missing AM_MAINTAINER_MODE statement. If the statement is amended with the enable parameter, then the CVS workaround is disabled. This will not stop, however, other people from proposing the restoration of the workaround, asking questions, and reopening the discussion many times over the next few decades. Might as well take in out of the files and out of sight. The burden of the proof lies on some distros. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On Thu, Sep 27, 2012 at 2:12 PM, Adam Jackson a...@redhat.com wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,6 @@ RELEASE_DATE=2012-09-05 RELEASE_NAME=Iced Tea AC_CONFIG_SRCDIR([Makefile.am]) AM_INIT_AUTOMAKE([foreign dist-bzip2]) -AM_MAINTAINER_MODE # Require xorg-macros minimum of 1.14 for XORG_COMPILER_BRAND in XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MACROS_VERSION], Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) See here for details: http://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/. -- Chase ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On Fri, Sep 28, 2012 at 08:59:47 -0700, Dan Nicholson wrote: It's more correct for downstream in a sense. You don't accidentally get the autotools pulled in during your tarball build if you patched something. There are ways to accomplish that (touch) without maintainer mode, though. I recall Julien said they wanted this in Debian. I think this patch is the right thing to do. Nowadays we (Debian) run autoreconf at package build time for pretty much all X stuff anyway, so it doesn't really make a difference to us anymore. Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On Sep 29, 2012 11:19 AM, Chase Douglas chase.doug...@ubuntu.com wrote: On Thu, Sep 27, 2012 at 2:12 PM, Adam Jackson a...@redhat.com wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,6 @@ RELEASE_DATE=2012-09-05 RELEASE_NAME=Iced Tea AC_CONFIG_SRCDIR([Makefile.am]) AM_INIT_AUTOMAKE([foreign dist-bzip2]) -AM_MAINTAINER_MODE # Require xorg-macros minimum of 1.14 for XORG_COMPILER_BRAND in XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MACROS_VERSION], Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) Oh, yeah. That would be the best. Dan ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On 9/27/12 7:13 PM, Keith Packard wrote: Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. At one point, I'm almost certain that not having AM_MAINTAINER_MODE meant that you *never* got correct behaviour. When did that change? Maybe you're remembering you need --enable-maintainer-mode to get correct behaviour? Which is true, if you've said AM_MAINTAINER_MODE in configure.ac. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On Sep 28, 2012 7:45 AM, Adam Jackson a...@redhat.com wrote: On 9/27/12 7:13 PM, Keith Packard wrote: Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. At one point, I'm almost certain that not having AM_MAINTAINER_MODE meant that you *never* got correct behaviour. When did that change? Maybe you're remembering you need --enable-maintainer-mode to get correct behaviour? Which is true, if you've said AM_MAINTAINER_MODE in configure.ac. It's more correct for downstream in a sense. You don't accidentally get the autotools pulled in during your tarball build if you patched something. There are ways to accomplish that (touch) without maintainer mode, though. I recall Julien said they wanted this in Debian. I think this patch is the right thing to do. Reviewed-by: Dan Nicholson dbn.li...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] configure: Stop using AM_MAINTAINER_MODE
All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,6 @@ RELEASE_DATE=2012-09-05 RELEASE_NAME=Iced Tea AC_CONFIG_SRCDIR([Makefile.am]) AM_INIT_AUTOMAKE([foreign dist-bzip2]) -AM_MAINTAINER_MODE # Require xorg-macros minimum of 1.14 for XORG_COMPILER_BRAND in XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MACROS_VERSION], -- 1.7.12 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,6 @@ RELEASE_DATE=2012-09-05 RELEASE_NAME=Iced Tea AC_CONFIG_SRCDIR([Makefile.am]) AM_INIT_AUTOMAKE([foreign dist-bzip2]) -AM_MAINTAINER_MODE Yeah, AM_MAINTAINER_MODE just lets you to opt-in to correct behavior, instead of just having correct behavior all the time. It should die. Reviewed-by: Eric Anholt e...@anholt.net pgpAMn8ri3SOS.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. At one point, I'm almost certain that not having AM_MAINTAINER_MODE meant that you *never* got correct behaviour. When did that change? -- keith.pack...@intel.com pgp5gH0sgshih.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On Thu, Sep 27, 2012 at 05:12:19PM -0400, Adam Jackson wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,6 @@ RELEASE_DATE=2012-09-05 RELEASE_NAME=Iced Tea AC_CONFIG_SRCDIR([Makefile.am]) AM_INIT_AUTOMAKE([foreign dist-bzip2]) -AM_MAINTAINER_MODE # Require xorg-macros minimum of 1.14 for XORG_COMPILER_BRAND in XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MACROS_VERSION], -- 1.7.12 yes please. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Also, this affects all repos, anyone volunteering? ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE
On Thu, Sep 27, 2012 at 5:12 PM, Adam Jackson a...@redhat.com wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. YES PLEASE! Reviewed-by: Alex Deucher alexander.deuc...@amd.com Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,6 @@ RELEASE_DATE=2012-09-05 RELEASE_NAME=Iced Tea AC_CONFIG_SRCDIR([Makefile.am]) AM_INIT_AUTOMAKE([foreign dist-bzip2]) -AM_MAINTAINER_MODE # Require xorg-macros minimum of 1.14 for XORG_COMPILER_BRAND in XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MACROS_VERSION], -- 1.7.12 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
