Re: [PATCH] dri2: SProcDRI2Connect - send the response.
Michal Srb writes: > The swapped implementation of DRI2Connect is always responding with empty > device and driver values. However the response was only prepared and never > sent (also had undefined .type member), causing e.g. glxinfo get stuck waiting > for response when started remotely from machine with different > endianity. Merged. 457fc77..9bc53d8 master -> master -- keith.pack...@intel.com pgpaa3fRK9gQq.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dri2: SProcDRI2Connect - send the response.
On Fre, 2012-05-04 at 18:29 +0200, Michal Srb wrote: > The swapped implementation of DRI2Connect is always responding with empty > device and driver values. However the response was only prepared and never > sent (also had undefined .type member), causing e.g. glxinfo get stuck waiting > for response when started remotely from machine with different endianity. > > Signed-off-by: Michal Srb > Reviewed-by: Jeremy Huddleston Tested-by: Michel Dänzer This should also go to stable trees. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] dri2: SProcDRI2Connect - send the response.
The swapped implementation of DRI2Connect is always responding with empty device and driver values. However the response was only prepared and never sent (also had undefined .type member), causing e.g. glxinfo get stuck waiting for response when started remotely from machine with different endianity. Signed-off-by: Michal Srb Reviewed-by: Jeremy Huddleston --- hw/xfree86/dri2/dri2ext.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c index 73ef7f2..c7749ba 100644 --- a/hw/xfree86/dri2/dri2ext.c +++ b/hw/xfree86/dri2/dri2ext.c @@ -592,12 +592,15 @@ SProcDRI2Connect(ClientPtr client) if (sizeof(*stuff) / 4 != client->req_len) return BadLength; +rep.type = X_Reply; rep.sequenceNumber = client->sequence; swaps(&rep.sequenceNumber); rep.length = 0; rep.driverNameLength = 0; rep.deviceNameLength = 0; +WriteToClient(client, sizeof(xDRI2ConnectReply), &rep); + return Success; } -- 1.7.9.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dri2: SProcDRI2Connect - send the response.
/facepalm Reviewed-by: Jeremy Huddleston On Mar 21, 2012, at 7:14 AM, Michal Srb wrote: > The swapped implementation of DRI2Connect is always responding with empty > device and driver values. However the response was only prepared and never > sent (also had undefined .type member), causing e.g. glxinfo get stuck waiting > for response when started remotely from machine with different endianity. > > Signed-off-by: Michal Srb > --- > hw/xfree86/dri2/dri2ext.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c > index 73ef7f2..c7749ba 100644 > --- a/hw/xfree86/dri2/dri2ext.c > +++ b/hw/xfree86/dri2/dri2ext.c > @@ -592,12 +592,15 @@ SProcDRI2Connect(ClientPtr client) > if (sizeof(*stuff) / 4 != client->req_len) > return BadLength; > > +rep.type = X_Reply; > rep.sequenceNumber = client->sequence; > swaps(&rep.sequenceNumber); > rep.length = 0; > rep.driverNameLength = 0; > rep.deviceNameLength = 0; > > +WriteToClient(client, sizeof(xDRI2ConnectReply), &rep); > + > return Success; > } > > -- > 1.7.9.2 > > ___ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel > ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] dri2: SProcDRI2Connect - send the response.
The swapped implementation of DRI2Connect is always responding with empty device and driver values. However the response was only prepared and never sent (also had undefined .type member), causing e.g. glxinfo get stuck waiting for response when started remotely from machine with different endianity. Signed-off-by: Michal Srb --- hw/xfree86/dri2/dri2ext.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c index 73ef7f2..c7749ba 100644 --- a/hw/xfree86/dri2/dri2ext.c +++ b/hw/xfree86/dri2/dri2ext.c @@ -592,12 +592,15 @@ SProcDRI2Connect(ClientPtr client) if (sizeof(*stuff) / 4 != client->req_len) return BadLength; +rep.type = X_Reply; rep.sequenceNumber = client->sequence; swaps(&rep.sequenceNumber); rep.length = 0; rep.driverNameLength = 0; rep.deviceNameLength = 0; +WriteToClient(client, sizeof(xDRI2ConnectReply), &rep); + return Success; } -- 1.7.9.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
