Re: [PATCH] glx: remove unused systemTimeExtension

2017-09-08 Thread Eric Anholt 
Emil Velikov  writes:

> On 23 August 2017 at 18:08, Eric Anholt  wrote:
>> Emil Velikov  writes:
>>
>>> Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a
>>> dri1 artefact copy/pasted in the dri2/drisw codebase.
>>
>> Agreed that it seems to be only DRI1 drivers that used it.
>>
>> Reviewed-by: Eric Anholt 
>
> Thank you Eric.
>
> Do you have access to push the commit, or it's up-to Adam/others to do that?

Pushed now.


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] glx: remove unused systemTimeExtension

2017-09-04 Thread Emil Velikov 
On 23 August 2017 at 18:08, Eric Anholt  wrote:
> Emil Velikov  writes:
>
>> Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a
>> dri1 artefact copy/pasted in the dri2/drisw codebase.
>
> Agreed that it seems to be only DRI1 drivers that used it.
>
> Reviewed-by: Eric Anholt 

Thank you Eric.

Do you have access to push the commit, or it's up-to Adam/others to do that?

-Emil
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] glx: remove unused systemTimeExtension

2017-08-23 Thread Eric Anholt 
Emil Velikov  writes:

> Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a
> dri1 artefact copy/pasted in the dri2/drisw codebase.

Agreed that it seems to be only DRI1 drivers that used it.

Reviewed-by: Eric Anholt 


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] glx: remove unused systemTimeExtension

2017-08-03 Thread Emil Velikov 
On 29 September 2016 at 18:36, Emil Velikov  wrote:
> Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a
> dri1 artefact copy/pasted in the dri2/drisw codebase.
>
> Signed-off-by: Emil Velikov 
> ---
>  glx/glxdri2.c  |  1 -
>  glx/glxdricommon.c | 23 ---
>  glx/glxdricommon.h |  2 --
>  glx/glxdriswrast.c |  1 -
>  4 files changed, 27 deletions(-)
>
> diff --git a/glx/glxdri2.c b/glx/glxdri2.c
> index afaf44e..85700fe 100644
> --- a/glx/glxdri2.c
> +++ b/glx/glxdri2.c
> @@ -773,7 +773,6 @@ static const __DRIuseInvalidateExtension 
> dri2UseInvalidate = {
>  };
>
>  static const __DRIextension *loader_extensions[] = {
> -,
>  ,
>  ,
>  NULL
> diff --git a/glx/glxdricommon.c b/glx/glxdricommon.c
> index 62cce13..43987d6 100644
> --- a/glx/glxdricommon.c
> +++ b/glx/glxdricommon.c
> @@ -41,29 +41,6 @@
>  #include "glxscreens.h"
>  #include "glxdricommon.h"
>
> -static int
> -getUST(int64_t * ust)
> -{
> -struct timeval tv;
> -
> -if (ust == NULL)
> -return -EFAULT;
> -
> -if (gettimeofday(, NULL) == 0) {
> -ust[0] = (tv.tv_sec * 100) + tv.tv_usec;
> -return 0;
> -}
> -else {
> -return -errno;
> -}
> -}
> -
> -const __DRIsystemTimeExtension systemTimeExtension = {
> -{__DRI_SYSTEM_TIME, 1},
> -getUST,
> -NULL,
> -};
> -
>  #define __ATTRIB(attrib, field) \
>  { attrib, offsetof(__GLXconfig, field) }
>
> diff --git a/glx/glxdricommon.h b/glx/glxdricommon.h
> index f4fcf00..f568918 100644
> --- a/glx/glxdricommon.h
> +++ b/glx/glxdricommon.h
> @@ -36,8 +36,6 @@ __GLXconfig *glxConvertConfigs(const __DRIcoreExtension * 
> core,
> const __DRIconfig ** configs,
> unsigned int drawableType);
>
> -extern const __DRIsystemTimeExtension systemTimeExtension;
> -
>  void *glxProbeDriver(const char *name,
>   void **coreExt, const char *coreName, int coreVersion,
>   void **renderExt, const char *renderName,
> diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c
> index be32527..69484a5 100644
> --- a/glx/glxdriswrast.c
> +++ b/glx/glxdriswrast.c
> @@ -366,7 +366,6 @@ static const __DRIswrastLoaderExtension 
> swrastLoaderExtension = {
>  };
>
>  static const __DRIextension *loader_extensions[] = {
> -,
>  ,
>  NULL
>  };
> --
Humble ping anyone?

I ended "writing" exact same patch just the other day.

Thanks
Emil
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] glx: remove unused systemTimeExtension

2016-09-29 Thread Emil Velikov 
Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a
dri1 artefact copy/pasted in the dri2/drisw codebase.

Signed-off-by: Emil Velikov 
---
 glx/glxdri2.c  |  1 -
 glx/glxdricommon.c | 23 ---
 glx/glxdricommon.h |  2 --
 glx/glxdriswrast.c |  1 -
 4 files changed, 27 deletions(-)

diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index afaf44e..85700fe 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@ -773,7 +773,6 @@ static const __DRIuseInvalidateExtension dri2UseInvalidate 
= {
 };
 
 static const __DRIextension *loader_extensions[] = {
-,
 ,
 ,
 NULL
diff --git a/glx/glxdricommon.c b/glx/glxdricommon.c
index 62cce13..43987d6 100644
--- a/glx/glxdricommon.c
+++ b/glx/glxdricommon.c
@@ -41,29 +41,6 @@
 #include "glxscreens.h"
 #include "glxdricommon.h"
 
-static int
-getUST(int64_t * ust)
-{
-struct timeval tv;
-
-if (ust == NULL)
-return -EFAULT;
-
-if (gettimeofday(, NULL) == 0) {
-ust[0] = (tv.tv_sec * 100) + tv.tv_usec;
-return 0;
-}
-else {
-return -errno;
-}
-}
-
-const __DRIsystemTimeExtension systemTimeExtension = {
-{__DRI_SYSTEM_TIME, 1},
-getUST,
-NULL,
-};
-
 #define __ATTRIB(attrib, field) \
 { attrib, offsetof(__GLXconfig, field) }
 
diff --git a/glx/glxdricommon.h b/glx/glxdricommon.h
index f4fcf00..f568918 100644
--- a/glx/glxdricommon.h
+++ b/glx/glxdricommon.h
@@ -36,8 +36,6 @@ __GLXconfig *glxConvertConfigs(const __DRIcoreExtension * 
core,
const __DRIconfig ** configs,
unsigned int drawableType);
 
-extern const __DRIsystemTimeExtension systemTimeExtension;
-
 void *glxProbeDriver(const char *name,
  void **coreExt, const char *coreName, int coreVersion,
  void **renderExt, const char *renderName,
diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c
index be32527..69484a5 100644
--- a/glx/glxdriswrast.c
+++ b/glx/glxdriswrast.c
@@ -366,7 +366,6 @@ static const __DRIswrastLoaderExtension 
swrastLoaderExtension = {
 };
 
 static const __DRIextension *loader_extensions[] = {
-,
 ,
 NULL
 };
-- 
2.9.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel