Re: [PATCH] glx: swrast can do GLX 1.4 too
On Thu, 2009-10-29 at 14:01 -0400, Adam Jackson wrote: Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxdriswrast.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c index 44f658f..20f9f90 100644 --- a/glx/glxdriswrast.c +++ b/glx/glxdriswrast.c @@ -510,6 +510,9 @@ __glXDRIscreenProbe(ScreenPtr pScreen) __glXScreenInit(screen-base, pScreen); +screen-base.GLXmajor = 1; +screen-base.GLXminor = 4; + LogMessage(X_INFO, AIGLX: Loaded and initialized %s\n, filename); Keith, please merge. We didn't come up with any good reason to force these to be #defines when this was discussed, IIRC. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] glx: swrast can do GLX 1.4 too
On Mon, 14 Dec 2009 15:27:49 -0500, Adam Jackson a...@nwnk.net wrote: Keith, please merge. We didn't come up with any good reason to force these to be #defines when this was discussed, IIRC. Thanks. Pushed. -- keith.pack...@intel.com pgpey0T2cxVgf.pgp Description: PGP signature ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] glx: swrast can do GLX 1.4 too
On Fri, 2009-10-30 at 11:19 -0400, Kristian Høgsberg wrote: On Thu, Oct 29, 2009 at 5:52 PM, Adam Jackson a...@nwnk.net wrote: On Thu, 2009-10-29 at 14:01 -0700, keithp wrote: Excerpts from Adam Jackson's message of Thu Oct 29 11:01:29 -0700 2009: +screen-base.GLXmajor = 1; +screen-base.GLXminor = 4; Should this define be in a header somewhere? Maybe? It ends up being variable per renderer atm, so you'd end up with #define GLX_SWRAST_PROTOCOL_MINOR 4 #define GLX_DRI_PROTOCOL_MINOR 2 #define GLX_DRI2_PROTOCOL_MINOR 4 That doesn't seem especially useful, even as documentation. The whole thing is broken, in reality. pbuffer support and separable read/draw surfaces in the context are features that require some level of hardware (well, renderer) support, and we're not querying the renderer for their presence. No, pbuffer support is entirely in GLX and all DRI2 drivers support separate draw and read drawables. I didn't say we weren't giving the right answer, although I did say in reality when I should have said in theory. I was trying to say we were being chummy with the implementation. Not all DRI1 drivers necessarily support separate read/draw (although I think they do), and I'm reasonably sure hardware has existed where the only offscreen renderbuffer was the backbuffer. It wouldn't be impossible to implement pbuffers in that environment, but, the point remains, it requires renderer support. Still, swrast _can_ do 1.4, and I don't see a lot of value in #define'ing that bit of truth. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] glx: swrast can do GLX 1.4 too
On Thu, Oct 29, 2009 at 5:52 PM, Adam Jackson a...@nwnk.net wrote: On Thu, 2009-10-29 at 14:01 -0700, keithp wrote: Excerpts from Adam Jackson's message of Thu Oct 29 11:01:29 -0700 2009: + screen-base.GLXmajor = 1; + screen-base.GLXminor = 4; Should this define be in a header somewhere? Maybe? It ends up being variable per renderer atm, so you'd end up with #define GLX_SWRAST_PROTOCOL_MINOR 4 #define GLX_DRI_PROTOCOL_MINOR 2 #define GLX_DRI2_PROTOCOL_MINOR 4 That doesn't seem especially useful, even as documentation. The whole thing is broken, in reality. pbuffer support and separable read/draw surfaces in the context are features that require some level of hardware (well, renderer) support, and we're not querying the renderer for their presence. No, pbuffer support is entirely in GLX and all DRI2 drivers support separate draw and read drawables. cheers, Kristian ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] glx: swrast can do GLX 1.4 too
Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxdriswrast.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c index 44f658f..20f9f90 100644 --- a/glx/glxdriswrast.c +++ b/glx/glxdriswrast.c @@ -510,6 +510,9 @@ __glXDRIscreenProbe(ScreenPtr pScreen) __glXScreenInit(screen-base, pScreen); +screen-base.GLXmajor = 1; +screen-base.GLXminor = 4; + LogMessage(X_INFO, AIGLX: Loaded and initialized %s\n, filename); -- 1.6.4.4 ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] glx: swrast can do GLX 1.4 too
Excerpts from Adam Jackson's message of Thu Oct 29 11:01:29 -0700 2009: +screen-base.GLXmajor = 1; +screen-base.GLXminor = 4; + Should this define be in a header somewhere? -- keith.pack...@intel.com signature.asc Description: PGP signature ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] glx: swrast can do GLX 1.4 too
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxdriswrast.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c index 44f658f..20f9f90 100644 --- a/glx/glxdriswrast.c +++ b/glx/glxdriswrast.c @@ -510,6 +510,9 @@ __glXDRIscreenProbe(ScreenPtr pScreen) __glXScreenInit(screen-base, pScreen); +screen-base.GLXmajor = 1; +screen-base.GLXminor = 4; + LogMessage(X_INFO, AIGLX: Loaded and initialized %s\n, filename); -- 1.6.4.4 ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
