Re: [PATCH 0/3] Fix pointer emulation on non-ownership windows

2012-11-08 Thread Chase Douglas
On Thu, Nov 1, 2012 at 10:17 PM, Peter Hutterer wrote:

>
> https://bugs.freedesktop.org/show_bug.cgi?id=56557
>
> Pointer emulation on the root window does not work correctly. We currently
> only deliver to window owners, but no client owns the root window. The real
> bug here is that even though the events are registered for, the listener
> lookup fails and we never send emulated pointer events to the client.
>
> Fix this by storing the resource type of the listener with the touch so we
> know what to actually look up. And to make this work we need a resource
> type
> for active grabs, and we need to store implicit passive grabs in the
> resource system as well.
>
> oh, and having the second argument to FreeResource() be "don't free the
> resource data if the resource type to remove equals this type" is an
> interesting choice of an API.
>

I'm slowly losing my memory of the internals of X :(. While I can't make
out exactly how this works immediately, it looks like a proper solution all
around.

Reviewed-by: Chase Douglas 
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 0/3] Fix pointer emulation on non-ownership windows

2012-11-02 Thread Peter Hutterer

https://bugs.freedesktop.org/show_bug.cgi?id=56557

Pointer emulation on the root window does not work correctly. We currently
only deliver to window owners, but no client owns the root window. The real
bug here is that even though the events are registered for, the listener
lookup fails and we never send emulated pointer events to the client.

Fix this by storing the resource type of the listener with the touch so we
know what to actually look up. And to make this work we need a resource type
for active grabs, and we need to store implicit passive grabs in the
resource system as well.

oh, and having the second argument to FreeResource() be "don't free the
resource data if the resource type to remove equals this type" is an
interesting choice of an API.

Cheers,
  Peter
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel