Re: [PATCH 1/3] glamor: Fix memory leak in put_image

2014-05-22 Thread Keith Packard 
Markus Wick mar...@selfnet.de writes:

 Signed-off-by: Markus Wick mar...@selfnet.de
 ---
  glamor/glamor_image.c | 1 +
  1 file changed, 1 insertion(+)

 diff --git a/glamor/glamor_image.c b/glamor/glamor_image.c
 index 4791d08..c087a13 100644
 --- a/glamor/glamor_image.c
 +++ b/glamor/glamor_image.c
 @@ -92,6 +92,7 @@ glamor_put_image_bail(DrawablePtr drawable, GCPtr gc, int 
 depth, int x, int y,
  glamor_prepare_access_gc(gc))
  fbPutImage(drawable, gc, depth, x, y, w, h, leftPad, format, bits);
  glamor_finish_access(drawable);
 +glamor_finish_access_gc(gc);

This function shouldn't be calling glamor_prepare_access_gc -- that's
only for fill functions using the stipple or tile.

-- 
keith.pack...@intel.com


pgp1PenWxjOzG.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/3] glamor: Fix memory leak in put_image

2014-05-14 Thread Markus Wick 
Signed-off-by: Markus Wick mar...@selfnet.de
---
 glamor/glamor_image.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/glamor/glamor_image.c b/glamor/glamor_image.c
index 4791d08..c087a13 100644
--- a/glamor/glamor_image.c
+++ b/glamor/glamor_image.c
@@ -92,6 +92,7 @@ glamor_put_image_bail(DrawablePtr drawable, GCPtr gc, int 
depth, int x, int y,
 glamor_prepare_access_gc(gc))
 fbPutImage(drawable, gc, depth, x, y, w, h, leftPad, format, bits);
 glamor_finish_access(drawable);
+glamor_finish_access_gc(gc);
 }
 
 void
-- 
1.9.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel