Re: [PATCH 1/3] glx: fix memory leak when destroying screen
For all 3: Reviewed-by: Jeremy Huddleston On Oct 29, 2011, at 2:08 PM, przan...@gmail.com wrote: > From: Paulo Zanoni > > 1,152 bytes in 1 blocks are definitely lost in loss record 536 of 575 > at 0x4C25E84: calloc (in > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) > by 0x483820: __glXScreenInit (glxscreens.c:357) > by 0x48271C: __glXDRIscreenProbe (glxdriswrast.c:469) > by 0x4812BE: GlxExtensionInit (glxext.c:327) > by 0x41FB14: InitExtensions (miinitext.c:471) > by 0x5685AE: main (main.c:208) > > Signed-off-by: Paulo Zanoni > --- > glx/glxscreens.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/glx/glxscreens.c b/glx/glxscreens.c > index c4ad426..ebb9747 100644 > --- a/glx/glxscreens.c > +++ b/glx/glxscreens.c > @@ -422,4 +422,5 @@ void __glXScreenDestroy(__GLXscreen *screen) > free(screen->GLXvendor); > free(screen->GLXextensions); > free(screen->GLextensions); > +free(screen->visuals); > } > -- > 1.7.7 > > ___ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel > ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 1/3] glx: fix memory leak when destroying screen
2011/10/29 : > From: Paulo Zanoni > > 1,152 bytes in 1 blocks are definitely lost in loss record 536 of 575 > at 0x4C25E84: calloc (in > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) > by 0x483820: __glXScreenInit (glxscreens.c:357) > by 0x48271C: __glXDRIscreenProbe (glxdriswrast.c:469) > by 0x4812BE: GlxExtensionInit (glxext.c:327) > by 0x41FB14: InitExtensions (miinitext.c:471) > by 0x5685AE: main (main.c:208) > > Signed-off-by: Paulo Zanoni Ping? These 3 patches are somehow easy to test/review. The leaks are triggered when a screen is destroyed (each server generation). They don't represent significant improvements (as most of us never get past the first generation) but at least they help making valgrind's output cleaner, allowing us to detect the other leaks. You can even reproduce them with Xvfb. I have these patches applied to my local tree since I submitted them... Chris' patch "dri2: Register the DRI2DrawableType after server regeneration" is a requirement to properly test these in Xorg with the Intel driver, and it's on a "pull request" by Jeremy, so it should land master soon... Cheers, Paulo -- Paulo Zanoni ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 1/3] glx: fix memory leak when destroying screen
From: Paulo Zanoni 1,152 bytes in 1 blocks are definitely lost in loss record 536 of 575 at 0x4C25E84: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x483820: __glXScreenInit (glxscreens.c:357) by 0x48271C: __glXDRIscreenProbe (glxdriswrast.c:469) by 0x4812BE: GlxExtensionInit (glxext.c:327) by 0x41FB14: InitExtensions (miinitext.c:471) by 0x5685AE: main (main.c:208) Signed-off-by: Paulo Zanoni --- glx/glxscreens.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/glx/glxscreens.c b/glx/glxscreens.c index c4ad426..ebb9747 100644 --- a/glx/glxscreens.c +++ b/glx/glxscreens.c @@ -422,4 +422,5 @@ void __glXScreenDestroy(__GLXscreen *screen) free(screen->GLXvendor); free(screen->GLXextensions); free(screen->GLextensions); +free(screen->visuals); } -- 1.7.7 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
