Re: [PATCH 1/5] dix: don't InitXTestDevices if there's no XTest extension

2011-11-01 Thread Paulo Zanoni 
2011/11/1 Julien Cristau :
>
> XTEST is always defined these days.  Also, IIRC there's a bunch of stuff
> in XI that relies on the xtest devices.  Does that still work if you
> don't init the devices?

It seems you're right. I didn't think on this scenario. Let's just
discard this patch then. Sorry :(

Thanks for the review.

>
> Cheers,
> Julien
>



-- 
Paulo Zanoni
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 1/5] dix: don't InitXTestDevices if there's no XTest extension

2011-11-01 Thread Julien Cristau 
On Tue, Nov  1, 2011 at 11:12:34 -0200, przan...@gmail.com wrote:

> From: Paulo Zanoni 
> 
> Signed-off-by: Paulo Zanoni 
> ---
>  dix/devices.c |5 -
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/dix/devices.c b/dix/devices.c
> index 673a360..9d67c06 100644
> --- a/dix/devices.c
> +++ b/dix/devices.c
> @@ -681,7 +681,10 @@ InitCoreDevices(void)
>  !EnableDevice(inputInfo.keyboard, TRUE))
>  FatalError("Failed to enable core devices.");
>  
> -InitXTestDevices();
> +#ifdef XTEST
> +if (!noTestExtensions)
> + InitXTestDevices();
> +#endif
>  }
>  
>  /**

XTEST is always defined these days.  Also, IIRC there's a bunch of stuff
in XI that relies on the xtest devices.  Does that still work if you
don't init the devices?

Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/5] dix: don't InitXTestDevices if there's no XTest extension

2011-11-01 Thread przanoni 
From: Paulo Zanoni 

Signed-off-by: Paulo Zanoni 
---
 dix/devices.c |5 -
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/dix/devices.c b/dix/devices.c
index 673a360..9d67c06 100644
--- a/dix/devices.c
+++ b/dix/devices.c
@@ -681,7 +681,10 @@ InitCoreDevices(void)
 !EnableDevice(inputInfo.keyboard, TRUE))
 FatalError("Failed to enable core devices.");
 
-InitXTestDevices();
+#ifdef XTEST
+if (!noTestExtensions)
+   InitXTestDevices();
+#endif
 }
 
 /**
-- 
1.7.7

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel