Re: [PATCH modular] release.sh: Generate error for missing arguments
On Sun, Mar 13, 2011 at 08:52:42AM -0700, Dan Nicholson wrote: On Sun, Mar 13, 2011 at 3:35 AM, Dirk Wallenstein hals...@t-online.de wrote: All three arguments are required. Otherwise git-rev-list will abort the script silently. Signed-off-by: Dirk Wallenstein hals...@t-online.de Reviewed-by: Dan Nicholson dbn.li...@gmail.com Is this ready to be pushed? -- Cheers, Dirk ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH modular] release.sh: Generate error for missing arguments
On Wed, Mar 23, 2011 at 12:35:56 +0100, Dirk Wallenstein wrote: On Sun, Mar 13, 2011 at 08:52:42AM -0700, Dan Nicholson wrote: On Sun, Mar 13, 2011 at 3:35 AM, Dirk Wallenstein hals...@t-online.de wrote: All three arguments are required. Otherwise git-rev-list will abort the script silently. Signed-off-by: Dirk Wallenstein hals...@t-online.de Reviewed-by: Dan Nicholson dbn.li...@gmail.com Is this ready to be pushed? Pushed, thanks. Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH modular] release.sh: Generate error for missing arguments
All three arguments are required. Otherwise git-rev-list will abort the script silently. Signed-off-by: Dirk Wallenstein hals...@t-online.de --- release.sh | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/release.sh b/release.sh index e8ea013..1cfff07 100755 --- a/release.sh +++ b/release.sh @@ -120,15 +120,15 @@ while [ $# != 0 ]; do exit 1 ;; *) +if [ $# != 3 ]; then +echo error: invalid argument count +usage +exit 1 +fi section=$1 tag_previous=$2 tag_current=$3 shift 3 -if [ $# != 0 ]; then -echo error: unknown parameter -usage -exit 1 -fi ;; esac done -- 1.7.3.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH modular] release.sh: Generate error for missing arguments
On Sun, Mar 13, 2011 at 3:35 AM, Dirk Wallenstein hals...@t-online.de wrote: All three arguments are required. Otherwise git-rev-list will abort the script silently. Signed-off-by: Dirk Wallenstein hals...@t-online.de Reviewed-by: Dan Nicholson dbn.li...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
