Re: [PATCH synaptics 2/8] Removing extra call SetDeviceAndProtocol()

2011-02-27 Thread Peter Hutterer 
On Sun, Feb 27, 2011 at 01:11:45AM +0500, Alexandr Shadchin wrote:
> SetDeviceAndProtocol() calling in SynapticsPreInit(), extra calling
> in DeviceOn() unnecessary.
> 
> Signed-off-by: Alexandr Shadchin 
> ---
>  src/synaptics.c |1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/src/synaptics.c b/src/synaptics.c
> index daa0542..b1d027f 100644
> --- a/src/synaptics.c
> +++ b/src/synaptics.c
> @@ -786,7 +786,6 @@ DeviceOn(DeviceIntPtr dev)
>  
>  DBG(3, "Synaptics DeviceOn called\n");
>  
> -SetDeviceAndProtocol(pInfo);
>  pInfo->fd = xf86OpenSerial(pInfo->options);
>  if (pInfo->fd == -1) {
>   xf86Msg(X_WARNING, "%s: cannot open input device\n", pInfo->name);
> -- 
> 1.7.3.5

Reviewed-by: Peter Hutterer 

Cheers,
  Peter
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH synaptics 2/8] Removing extra call SetDeviceAndProtocol()

2011-02-26 Thread Alexandr Shadchin 
SetDeviceAndProtocol() calling in SynapticsPreInit(), extra calling
in DeviceOn() unnecessary.

Signed-off-by: Alexandr Shadchin 
---
 src/synaptics.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/synaptics.c b/src/synaptics.c
index daa0542..b1d027f 100644
--- a/src/synaptics.c
+++ b/src/synaptics.c
@@ -786,7 +786,6 @@ DeviceOn(DeviceIntPtr dev)
 
 DBG(3, "Synaptics DeviceOn called\n");
 
-SetDeviceAndProtocol(pInfo);
 pInfo->fd = xf86OpenSerial(pInfo->options);
 if (pInfo->fd == -1) {
xf86Msg(X_WARNING, "%s: cannot open input device\n", pInfo->name);
-- 
1.7.3.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel