Re: [PATCH xserver] autoconf: autoreconf of xserver produces warnings #38185

2011-10-03 Thread Keith Packard
On Tue, 27 Sep 2011 09:39:46 -0400, Gaetan Nadon mems...@videotron.ca wrote:

 From: Christopher Yeleighton giecr...@stegny.2a.pl

I had a local patch for exactly this issue which I've pushed.

-- 
keith.pack...@intel.com


pgpieaaK3RKW1.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] autoconf: autoreconf of xserver produces warnings #38185

2011-09-27 Thread Jon TURNEY
On 25/09/2011 00:21, Gaetan Nadon wrote:
 From: Christopher Yeleighton 
 giecrilj-n4iaqcmfnhax1+imcfc...@public.gmane.org
 
 https://bugs.freedesktop.org/show_bug.cgi?id=38185
 
 warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected
 
 Signed-off-by: Gaetan Nadon memsize-XzQKRVe1yT0V+D8aMU/k...@public.gmane.org
 ---
  configure.ac |8 ++--
  1 files changed, 6 insertions(+), 2 deletions(-)
 
 diff --git a/configure.ac b/configure.ac

Reviewed-by  Tested-by: Jon TURNEY jon.tur...@dronecode.org.uk

The commit message should probably mention that this warning was added in
autoconf-2.68
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


[PATCH xserver] autoconf: autoreconf of xserver produces warnings #38185

2011-09-27 Thread Gaetan Nadon
From: Christopher Yeleighton giecr...@stegny.2a.pl

https://bugs.freedesktop.org/show_bug.cgi?id=38185

warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected

This warning was introduced in autoconf version 2.68.

Reviewed-by  Tested-by: Jon TURNEY jon.tur...@dronecode.org.uk
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
 configure.ac |8 ++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index b0d2643..6e65161 100644
--- a/configure.ac
+++ b/configure.ac
@@ -723,7 +723,7 @@ case $host_os in
AC_CACHE_CHECK([whether to build 
Xquartz],xorg_cv_Carbon_framework,[
save_LDFLAGS=$LDFLAGS
LDFLAGS=$LDFLAGS -framework Carbon
-   AC_LINK_IFELSE([char FSFindFolder(); int main() 
{ FSFindFolder(); return 0;}],
+   AC_LINK_IFELSE([AC_LANG_SOURCE([[char 
FSFindFolder(); int main() { FSFindFolder(); return 0;}]])],
   [xorg_cv_Carbon_framework=yes],
   [xorg_cv_Carbon_framework=no])
LDFLAGS=$save_LDFLAGS])
@@ -875,10 +875,12 @@ AC_DEFINE_UNQUOTED([USE_SIGIO_BY_DEFAULT], 
[$USE_SIGIO_BY_DEFAULT_VALUE],
 
 AC_MSG_CHECKING([for glibc...])
 AC_PREPROC_IFELSE([
+AC_LANG_SOURCE([[
 #include features.h
 #ifndef __GLIBC__
 #error
 #endif
+]])
 ], glibc=yes, glibc=no)
 AC_MSG_RESULT([$glibc])
 
@@ -904,9 +906,10 @@ if ! test x$have_clock_gettime = xno; then
 fi
 
 AC_RUN_IFELSE([
+AC_LANG_SOURCE([[
 #include time.h
 
-int main(int argc, char *argv[[]]) {
+int main(int argc, char *argv[]) {
 struct timespec tp;
 
 if (clock_gettime(CLOCK_MONOTONIC, tp) == 0)
@@ -914,6 +917,7 @@ int main(int argc, char *argv[[]]) {
 else
 return 1;
 }
+]])
 ], [MONOTONIC_CLOCK=yes], [MONOTONIC_CLOCK=no],
[MONOTONIC_CLOCK=cross compiling])
 
-- 
1.7.4.1

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


[PATCH xserver] autoconf: autoreconf of xserver produces warnings #38185

2011-09-24 Thread Gaetan Nadon
From: Christopher Yeleighton giecr...@stegny.2a.pl

https://bugs.freedesktop.org/show_bug.cgi?id=38185

warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected

Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
 configure.ac |8 ++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index b0d2643..6e65161 100644
--- a/configure.ac
+++ b/configure.ac
@@ -723,7 +723,7 @@ case $host_os in
AC_CACHE_CHECK([whether to build 
Xquartz],xorg_cv_Carbon_framework,[
save_LDFLAGS=$LDFLAGS
LDFLAGS=$LDFLAGS -framework Carbon
-   AC_LINK_IFELSE([char FSFindFolder(); int main() 
{ FSFindFolder(); return 0;}],
+   AC_LINK_IFELSE([AC_LANG_SOURCE([[char 
FSFindFolder(); int main() { FSFindFolder(); return 0;}]])],
   [xorg_cv_Carbon_framework=yes],
   [xorg_cv_Carbon_framework=no])
LDFLAGS=$save_LDFLAGS])
@@ -875,10 +875,12 @@ AC_DEFINE_UNQUOTED([USE_SIGIO_BY_DEFAULT], 
[$USE_SIGIO_BY_DEFAULT_VALUE],
 
 AC_MSG_CHECKING([for glibc...])
 AC_PREPROC_IFELSE([
+AC_LANG_SOURCE([[
 #include features.h
 #ifndef __GLIBC__
 #error
 #endif
+]])
 ], glibc=yes, glibc=no)
 AC_MSG_RESULT([$glibc])
 
@@ -904,9 +906,10 @@ if ! test x$have_clock_gettime = xno; then
 fi
 
 AC_RUN_IFELSE([
+AC_LANG_SOURCE([[
 #include time.h
 
-int main(int argc, char *argv[[]]) {
+int main(int argc, char *argv[]) {
 struct timespec tp;
 
 if (clock_gettime(CLOCK_MONOTONIC, tp) == 0)
@@ -914,6 +917,7 @@ int main(int argc, char *argv[[]]) {
 else
 return 1;
 }
+]])
 ], [MONOTONIC_CLOCK=yes], [MONOTONIC_CLOCK=no],
[MONOTONIC_CLOCK=cross compiling])
 
-- 
1.7.4.1

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel