Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
On Sat, Feb 03, 2018 at 02:28:58PM -0800, Keith Packard wrote: > Adam Jackson writes: > > > Got impatient and hacked on this a bit more: > > > > https://cgit.freedesktop.org/xorg/proto/xorgproto/ > > Thanks for taking this on. It looks great. > > I have a question -- is there any place which we care about that doesn't > have meson support yet? If not, then might I gently suggest that we > simply never release this with autotools support? As far as OpenBSD is concerned (and my work as maintainer) dropping autotools in favor of meson in general would be a major PITA. For the proto case, we actually don't use the autotools build system for the split packages version, because of the overhead, and the (relative) simplicity of just writing BSD makefiles for these. I haven't looked that the merged xproto yet though. -- Matthieu Herrb signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
Adam Jackson writes: > Got impatient and hacked on this a bit more: > > https://cgit.freedesktop.org/xorg/proto/xorgproto/ Thanks for taking this on. It looks great. I have a question -- is there any place which we care about that doesn't have meson support yet? If not, then might I gently suggest that we simply never release this with autotools support? Also, is there any way we could have the 'autogen.sh' file (or similar) do all of the necessary meson bits so I don't have to remember how to run that command? -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
On Wed, 2018-01-24 at 16:08 -0500, Adam Jackson wrote: > On Wed, 2018-01-24 at 10:54 +1100, Keith Packard wrote: > > Adam Jackson writes: > > > For the actual 1.6 enablement I've been using this for a merged > > > protocol repo: > > > > > > https://cgit.freedesktop.org/~ajax/xorgproto > > > > That's awesome. It sounds like we should do a release of that (pre RandR > > 1.6) right away, and then a release of that with RandR 1.6 merged. Shall > > I just go do that? We're not breaking anything that distros are using as > > the old packages will hang around. > > Yeah, go for it. Got impatient and hacked on this a bit more: https://cgit.freedesktop.org/xorg/proto/xorgproto/ This no longer has all the headers at the top level, because that would make it impossible to use as a meson module (since everyone does #include we have to preserve the paths). Sorry about that. But it also has a meson build that's about six times faster than autotools even though the build is COMPLETELY TRIVIAL, so that's nice. I want to double-check the AC_ARG_ENABLE stuff from xproto, I don't remember how much of that is still relevant to any halfway modern machine. Assuming that all goes smoothly I'll release this tomorrow. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
On Wed, 2018-01-24 at 10:54 +1100, Keith Packard wrote: > Adam Jackson writes: > > For the actual 1.6 enablement I've been using this for a merged > > protocol repo: > > > > https://cgit.freedesktop.org/~ajax/xorgproto > > That's awesome. It sounds like we should do a release of that (pre RandR > 1.6) right away, and then a release of that with RandR 1.6 merged. Shall > I just go do that? We're not breaking anything that distros are using as > the old packages will hang around. Yeah, go for it. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
Adam Jackson writes: > 4 and 6 are: > > Reviewed-by: Adam Jackson > > 3 and 8 would have my r-b too once the review feedback is addressed. 9 > and 10 I think we can expect new versions of anyway, it sounded on IRC > like you'd found some bugs. I've marked the reviewed bugs and merged fixes for the bugs found by your suggested 'xlease' hack: v5: Terminate all leases on server reset. Leases hang around after the associated client exits so that the client doesn't need to occupy an X server client slot and consume a file descriptor once it has gotten the output resources necessary. Any leases still hanging around when the X server resets or shuts down need to be cleaned up by calling the kernel to terminate the lease and freeing any DIX structures. Note that we cannot simply use the existing drmmode_terminate_lease function on each lease as that wants to also reset the video mode, and during server shut down that modesetting: Validate leases on VT enter The kernel doesn't allow any master ioctls to run when another VT is active, including simple things like listing the active leases. To deal with that, we check the list of leases whenever the X server VT is activated. xfree86: hide disabled cursors when resetting after lease termination The lessee may well have played with cursors and left one active on our screen. Just tell the kernel to turn it off. > For the actual 1.6 enablement I've been using this for a merged > protocol repo: > > https://cgit.freedesktop.org/~ajax/xorgproto That's awesome. It sounds like we should do a release of that (pre RandR 1.6) right away, and then a release of that with RandR 1.6 merged. Shall I just go do that? We're not breaking anything that distros are using as the old packages will hang around. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
On Thu, 2017-12-21 at 18:54 -0800, Keith Packard wrote: > Here's the latest version of the DRM lease and non-desktop output code > for the X server. This time, I've gone ahead and implemented a pile of > tests for leases. > > Changes since the last series: > > * Merged non-desktop and lease support into a single patch >sequence. They have a dependency on reporting output connection >status, so it's something of a pain to keep them separate. > > * Added RandR lease tests > > Mesa support for the VK_EXT_acquire_xlib_display is waiting for this > series to land. Merged 1 2 5 and 7: remote: E: failed to find patch for rev 44d5f2eb8a2f92571698adec39ac569b71da5a1b. remote: I: patch #194730 updated using rev a12485ed846b852ca14d17d1e58c8b0f2399e577. remote: I: patch #192308 updated using rev 29f79bedf2c80241ba4b482db6ead08a5709a982. remote: E: failed to find patch for rev 4d5aab66c052795c7f0381a3dfc7293c9a41e441. remote: I: 2 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 627dfc2f8..4d5aab66c master -> master 4 and 6 are: Reviewed-by: Adam Jackson 3 and 8 would have my r-b too once the review feedback is addressed. 9 and 10 I think we can expect new versions of anyway, it sounded on IRC like you'd found some bugs. For the actual 1.6 enablement I've been using this for a merged protocol repo: https://cgit.freedesktop.org/~ajax/xorgproto Which is Keith's "mergeproto" plus some packaging cleanups; if other distribution/OS maintainers would like to take a look at that and make sure it'll work for them, that would be much appreciated. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
Adam Jackson writes: > Well it's still Xephyr, right? Use XI2 to grab whichever devices you > want from the host Xorg. Hrm. I wasn't really thinking of using Xephyr as I need xf86-video-modesetting to drive the leased fd anyways. I guess I can go figure out how the libinput 'seat' stuff works and try that. Should be easy? Then whack up video-modesetting to talk to xcb to get the DRM fd. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
On Wed, 2018-01-17 at 21:24 -0800, Keith Packard wrote: > Adam Jackson writes: > > > Port Xephyr to EGL and create its EGLDisplay from the lease fd? That'd > > be a cute way to do multiseat-on-one-GPU. Unifying the glamor backends > > on EGL and dropping GLX would be a nice cleanup anyway. > > Yeah, would be easy, except for input. Any idea how I can steal some > input devices away from one server and hand them to another? Well it's still Xephyr, right? Use XI2 to grab whichever devices you want from the host Xorg. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
Adam Jackson writes: > I was imagining xrandr could acquire the lease and pause until it was > ^C'd, just to exercise whether the state transitions work without > needing to do anything interesting with the lease. I wrote some test cases that do that in test/randr/randr_lease.c; that's probably more useful as it actually checks to make sure the system responds according to the spec in a few different ways. I could write more tests if you thought of things you'd like to see? > Port Xephyr to EGL and create its EGLDisplay from the lease fd? That'd > be a cute way to do multiseat-on-one-GPU. Unifying the glamor backends > on EGL and dropping GLX would be a nice cleanup anyway. Yeah, would be easy, except for input. Any idea how I can steal some input devices away from one server and hand them to another? -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
On Tue, 2018-01-16 at 14:45 -0800, Keith Packard wrote: > Adam Jackson writes: > > > > Changes since the last series: > > > > > > * Merged non-desktop and lease support into a single patch > > >sequence. They have a dependency on reporting output connection > > >status, so it's something of a pain to keep them separate. > > > > > > * Added RandR lease tests > > > > Is there userspace for this? Patched version of xrandr(1) perhaps? > > I've got xcb patches for the protocol bits, and mesa patches out for > review that use them. I'm not sure how you'd expect xrandr to take > advantage of leasing though? As for non-desktop support, xrandr happily > ignores non-desktop monitors, so that at least works? I was imagining xrandr could acquire the lease and pause until it was ^C'd, just to exercise whether the state transitions work without needing to do anything interesting with the lease. > I think one useful user-space thing I could do that wasn't mesa would be > to create an X server that used a leased output. I'm not sure how I'd > get input devices though. Port Xephyr to EGL and create its EGLDisplay from the lease fd? That'd be a cute way to do multiseat-on-one-GPU. Unifying the glamor backends on EGL and dropping GLX would be a nice cleanup anyway. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
Adam Jackson writes: >> Changes since the last series: >> >> * Merged non-desktop and lease support into a single patch >>sequence. They have a dependency on reporting output connection >>status, so it's something of a pain to keep them separate. >> >> * Added RandR lease tests > > Is there userspace for this? Patched version of xrandr(1) perhaps? I've got xcb patches for the protocol bits, and mesa patches out for review that use them. I'm not sure how you'd expect xrandr to take advantage of leasing though? As for non-desktop support, xrandr happily ignores non-desktop monitors, so that at least works? I think one useful user-space thing I could do that wasn't mesa would be to create an X server that used a leased output. I'm not sure how I'd get input devices though. I'm happy to create more use cases if you can think of some that would be helpful. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
On Thu, 2017-12-21 at 18:54 -0800, Keith Packard wrote: > Here's the latest version of the DRM lease and non-desktop output code > for the X server. This time, I've gone ahead and implemented a pile of > tests for leases. > > Changes since the last series: > > * Merged non-desktop and lease support into a single patch >sequence. They have a dependency on reporting output connection >status, so it's something of a pain to keep them separate. > > * Added RandR lease tests Is there userspace for this? Patched version of xrandr(1) perhaps? - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)
Here's the latest version of the DRM lease and non-desktop output code for the X server. This time, I've gone ahead and implemented a pile of tests for leases. Changes since the last series: * Merged non-desktop and lease support into a single patch sequence. They have a dependency on reporting output connection status, so it's something of a pain to keep them separate. * Added RandR lease tests Mesa support for the VK_EXT_acquire_xlib_display is waiting for this series to land. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
