Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-12 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes:

 Laércio de Sousa (2):
   xfree86: allow fallback to PCI bus probe for graphics devices on 
 non-seat0 X servers (#66851)
   xfree86: add short description about MatchSeat key in xorg.conf man page

 Oleg Samarin (1):
   xfree86: add new key MatchSeat to xorg.conf sections Device, 
 Screen, and ServerLayout

 Peter Hutterer (3):
   systemd-logind: let the logind code decided whether to close an fd
   mi: start calculating the sprite trace from the first child of root
   Xi: don't copy a DeviceEvent into an InternalEvent

I've merged these along with Laércio's warning fixup.

-- 
keith.pack...@intel.com


pgpdhxKykGY6z.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-09 Thread Laércio de Sousa
Patch sent:

http://lists.x.org/archives/xorg-devel/2014-May/042386.html

CANTATE DOMINO CANTICUM NOVUM
QUIA MIRABILIA FECIT

Laércio


2014-05-09 0:31 GMT-03:00 Keith Packard kei...@keithp.com:

 Laércio de Sousa lbsous...@gmail.com writes:

  These warnings are all related to a malformed FIND_SUITABLE macro
  expansion. I can fix it tomorrow.

 Thanks.

 --
 keith.pack...@intel.com

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-08 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes:

 The last two aren't rev-by. If you want to add the tag, feel free to add the
 tag after merging.

I've reviewed both of these; feel free to add as you please, or send
along and I'll add that when I merge. However, I'm getting a bunch of
new warnings now and those will need to be fixed before I can push out
the merge...

 Laércio de Sousa (2):
   xfree86: allow fallback to PCI bus probe for graphics devices on 
 non-seat0 X servers (#66851)
   xfree86: add short description about MatchSeat key in xorg.conf man page

 Oleg Samarin (1):
   xfree86: add new key MatchSeat to xorg.conf sections Device, 
 Screen, and ServerLayout

I think it's this patch which generates several new warnings:

xf86Config.c: In function 'configLayout':
xf86Config.c:1596:29: warning: declaration of 'l' shadows a previous local 
[-Wshadow]
 FIND_SUITABLE (XF86ConfScreenPtr, xf86configptr-conf_screen_lst, 
screen);
 ^
xf86Config.c:1484:23: warning: shadowed declaration is here [-Wshadow]
 XF86ConfLayoutPtr l;
   ^
xf86Config.c:1596:172: warning: suggest parentheses around '' within '||' 
[-Wparentheses]
 FIND_SUITABLE (XF86ConfScreenPtr, xf86configptr-conf_screen_lst, 
screen);


^
xf86Config.c: In function 'configScreen':
xf86Config.c:1838:172: warning: suggest parentheses around '' within '||' 
[-Wparentheses]
 FIND_SUITABLE (XF86ConfDevicePtr, xf86configptr-conf_device_lst, 
conf_screen-scrn_device);


^
xf86Config.c: In function 'xf86HandleConfigFile':
xf86Config.c:2446:5: warning: ISO C90 forbids mixed declarations and code 
[-Wdeclaration-after-statement]
 XF86ConfLayoutPtr layout;
 ^
xf86Config.c:2448:168: warning: suggest parentheses around '' within '||' 
[-Wparentheses]
 FIND_SUITABLE(XF86ConfLayoutPtr, xf86configptr-conf_layout_lst, layout);


^
xf86Config.c:2456:172: warning: suggest parentheses around '' within '||' 
[-Wparentheses]
 FIND_SUITABLE (XF86ConfScreenPtr, xf86configptr-conf_screen_lst, 
screen);


^

 Peter Hutterer (3):
   systemd-logind: let the logind code decided whether to close an fd
   mi: start calculating the sprite trace from the first child of root
   Xi: don't copy a DeviceEvent into an InternalEvent

-- 
keith.pack...@intel.com


pgp1xkg3d16UL.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-08 Thread Laércio de Sousa
Em 08/05/2014 17:03, Keith Packard kei...@keithp.com escreveu:

 Peter Hutterer peter.hutte...@who-t.net writes:

  The last two aren't rev-by. If you want to add the tag, feel free to
add the
  tag after merging.

 I've reviewed both of these; feel free to add as you please, or send
 along and I'll add that when I merge. However, I'm getting a bunch of
 new warnings now and those will need to be fixed before I can push out
 the merge...

  Laércio de Sousa (2):
xfree86: allow fallback to PCI bus probe for graphics devices on
non-seat0 X servers (#66851)
xfree86: add short description about MatchSeat key in xorg.conf
man page
 
  Oleg Samarin (1):
xfree86: add new key MatchSeat to xorg.conf sections Device,
Screen, and ServerLayout

 I think it's this patch which generates several new warnings:

 xf86Config.c: In function 'configLayout':
 xf86Config.c:1596:29: warning: declaration of 'l' shadows a previous
local [-Wshadow]
  FIND_SUITABLE (XF86ConfScreenPtr,
xf86configptr-conf_screen_lst, screen);
  ^
 xf86Config.c:1484:23: warning: shadowed declaration is here [-Wshadow]
  XF86ConfLayoutPtr l;
^
 xf86Config.c:1596:172: warning: suggest parentheses around '' within
'||' [-Wparentheses]
  FIND_SUITABLE (XF86ConfScreenPtr,
xf86configptr-conf_screen_lst, screen);


  ^
 xf86Config.c: In function 'configScreen':
 xf86Config.c:1838:172: warning: suggest parentheses around '' within
'||' [-Wparentheses]
  FIND_SUITABLE (XF86ConfDevicePtr,
xf86configptr-conf_device_lst, conf_screen-scrn_device);


  ^
 xf86Config.c: In function 'xf86HandleConfigFile':
 xf86Config.c:2446:5: warning: ISO C90 forbids mixed declarations and code
[-Wdeclaration-after-statement]
  XF86ConfLayoutPtr layout;
  ^
 xf86Config.c:2448:168: warning: suggest parentheses around '' within
'||' [-Wparentheses]
  FIND_SUITABLE(XF86ConfLayoutPtr, xf86configptr-conf_layout_lst,
layout);


  ^
 xf86Config.c:2456:172: warning: suggest parentheses around '' within
'||' [-Wparentheses]
  FIND_SUITABLE (XF86ConfScreenPtr,
xf86configptr-conf_screen_lst, screen);


  ^

These warnings are all related to a malformed FIND_SUITABLE macro
expansion. I can fix it tomorrow.

  Peter Hutterer (3):
systemd-logind: let the logind code decided whether to close an fd
mi: start calculating the sprite trace from the first child of
root
Xi: don't copy a DeviceEvent into an InternalEvent

 --
 keith.pack...@intel.com

 ___
 xorg-devel@lists.x.org: X.Org development
 Archives: http://lists.x.org/archives/xorg-devel
 Info: http://lists.x.org/mailman/listinfo/xorg-devel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-08 Thread Keith Packard
Laércio de Sousa lbsous...@gmail.com writes:

 These warnings are all related to a malformed FIND_SUITABLE macro
 expansion. I can fix it tomorrow.

Thanks.

-- 
keith.pack...@intel.com


pgpeTDe1BBR9h.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PULL] MatchSeat, logind patch, two invalid memory access

2014-05-04 Thread Peter Hutterer
The last two aren't rev-by. If you want to add the tag, feel free to add the
tag after merging.

The following changes since commit e06fbe4dc81110e01d36f958849c4ab5f2a9df0e:

  dix: remove a now-superfluous comment (2014-04-29 10:06:25 +1000)

are available in the git repository at:

  git://people.freedesktop.org/~whot/xserver for-keith

for you to fetch changes up to 56929f41e6c4cc1b2d72a33d14b4d993e7b613a3:

  Xi: don't copy a DeviceEvent into an InternalEvent (2014-05-05 07:26:33 +1000)


Laércio de Sousa (2):
  xfree86: allow fallback to PCI bus probe for graphics devices on 
non-seat0 X servers (#66851)
  xfree86: add short description about MatchSeat key in xorg.conf man page

Oleg Samarin (1):
  xfree86: add new key MatchSeat to xorg.conf sections Device, Screen, 
and ServerLayout

Peter Hutterer (3):
  systemd-logind: let the logind code decided whether to close an fd
  mi: start calculating the sprite trace from the first child of root
  Xi: don't copy a DeviceEvent into an InternalEvent

 Xi/exevents.c| 16 ++---
 config/config.c  |  6 ++---
 hw/xfree86/common/xf86Bus.c  |  4 ++--
 hw/xfree86/common/xf86Config.c   | 34 
 hw/xfree86/common/xf86Xinput.c   |  9 +++-
 hw/xfree86/common/xf86platformBus.c  |  3 +--
 hw/xfree86/man/xorg.conf.man | 24 
 hw/xfree86/os-support/linux/lnx_platform.c   |  2 +-
 hw/xfree86/os-support/linux/systemd-logind.c |  7 --
 hw/xfree86/parser/Device.c   |  6 +
 hw/xfree86/parser/Layout.c   |  6 +
 hw/xfree86/parser/Screen.c   |  6 +
 hw/xfree86/parser/xf86Parser.h   |  3 +++
 hw/xfree86/parser/xf86tokens.h   |  1 +
 include/systemd-logind.h |  4 ++--
 mi/miwindow.c|  2 +-
 16 files changed, 96 insertions(+), 37 deletions(-)


pgp6AEpywHsDC.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel