Re: [PULL] XQuartz {Add,Remove}EnabledDevice build fixes and other cleanup

2016-09-13 Thread Adam Jackson 
On Tue, 2016-09-13 at 10:09 -0700, Jeremy Huddleston Sequoia wrote:

> The following changes since commit d8e05c04758cbcd7b5c11362cb28ce017d50098b:
> 
>   modesetting: Fall back to primary crtc for vblank for drawables on slave 
> outputs (2016-09-13 11:18:43 -0400)
> 
> are available in the git repository at:
> 
> >   https://github.com/XQuartz/xorg-server.git 
> 
> for you to fetch changes up to 6c0641c7e843182d860c593bf48a88f38bedb291:
> 
>   os/inputthread: Fix setting of cloexec on file descriptors (2016-09-13 
> 10:00:51 -0700)

Merged:

remote: E: failed to find patch for rev 
33d595255d4206df0d136014de33100817cbe344.
remote: E: failed to find patch for rev 
4f4ecd0f41cf1c710d3ef1626b747847e6184f4c.
remote: E: failed to find patch for rev 
7def2fea30060d47780dc1eedc91fada5ae1934f.
remote: I: patch #109979 updated using rev 
a5769de0f5399053e9864b753fa9755220d65ae0.
remote: E: failed to find patch for rev 
065eb6612492bacf4d7caaad90e35dafc2cbf7ea.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   d8e05c0..065eb66  master -> master

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] XQuartz {Add,Remove}EnabledDevice build fixes and other cleanup

2016-09-13 Thread Adam Jackson 
On Tue, 2016-09-13 at 10:09 -0700, Jeremy Huddleston Sequoia wrote:

> Yes, if it is a relative path, things might not go the way we want
> them to, so that's a good point.  The related logic in libxcb has the
> same issue.  If this is something we want to squash, we should do it
> in both places by changing 'if (display_env)' to 'if (display_env &&
> *display_env == '/')'
> 
> Would that make you feel more comfortable?

Yeah. Maybe if we wanted relative paths we'd want to do
strchr(display_env, '/'), but like I say, having a hard time coming up
with a good reason to want that.

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] XQuartz {Add,Remove}EnabledDevice build fixes and other cleanup

2016-09-13 Thread Jeremy Huddleston Sequoia 

> On Sep 13, 2016, at 07:48, Adam Jackson  wrote:
> 
> On Sun, 2016-09-11 at 00:03 -0700, Jeremy Huddleston Sequoia wrote:
> 
>>   os/connection: Improve abstraction for launchd secure sockets
> 
> Mmm, not a huge fan of this one. You're not requiring that $DISPLAY be
> an absolute path, so now server startup might fail if there's a file in
> cwd named ":0.0". Unlikely I admit but still a dumb reason to fail, and
> I can't think of a good reason to want relative paths to work here.

Whoops, I didn't mean to include that one in the pull request as I hadn't 
received review feedback from it yet.  Sorry about that.  I've removed it from 
the PR (updated below to also include 2 patches that I got review on over the 
weekend).

Regarding the change in question, it's not requiring DISPLAY to be an absolute 
path.  If it isn't a path at all, it falls through to the "not a path" case.

Yes, if it is a relative path, things might not go the way we want them to, so 
that's a good point.  The related logic in libxcb has the same issue.  If this 
is something we want to squash, we should do it in both places by changing 'if 
(display_env)' to 'if (display_env && *display_env == '/')'

Would that make you feel more comfortable?



The updated PR without that change is:


The following changes since commit d8e05c04758cbcd7b5c11362cb28ce017d50098b:

  modesetting: Fall back to primary crtc for vblank for drawables on slave 
outputs (2016-09-13 11:18:43 -0400)

are available in the git repository at:

  https://github.com/XQuartz/xorg-server.git 

for you to fetch changes up to 6c0641c7e843182d860c593bf48a88f38bedb291:

  os/inputthread: Fix setting of cloexec on file descriptors (2016-09-13 
10:00:51 -0700)


Jeremy Huddleston Sequoia (5):
  XQuartz: Fix the issue where the h key could be come "stuck" after hiding 
XQuartz with cmd-h
  XQuartz: Cleanup CPPFLAGS that are no longer necessary on darwin
  Xquartz: Update for removal of AddEnabledDevice and RemoveEnabledDevice
  Xext/shm: Fix usage of F_GETFD to match standard
  os/inputthread: Fix setting of cloexec on file descriptors

 Xext/shm.c |  3 ++-
 hw/xquartz/X11Application.m|  9 +
 hw/xquartz/darwin.c| 17 +++--
 hw/xquartz/pbproxy/Makefile.am |  5 ++---
 os/inputthread.c   | 15 +--
 5 files changed, 37 insertions(+), 12 deletions(-)




smime.p7s
Description: S/MIME cryptographic signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] XQuartz {Add,Remove}EnabledDevice build fixes and other cleanup

2016-09-13 Thread Adam Jackson 
On Sun, 2016-09-11 at 00:03 -0700, Jeremy Huddleston Sequoia wrote:

>   os/connection: Improve abstraction for launchd secure sockets

Mmm, not a huge fan of this one. You're not requiring that $DISPLAY be
an absolute path, so now server startup might fail if there's a file in
cwd named ":0.0". Unlikely I admit but still a dumb reason to fail, and
I can't think of a good reason to want relative paths to work here.

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PULL] XQuartz {Add, Remove}EnabledDevice build fixes and other cleanup

2016-09-11 Thread Jeremy Huddleston Sequoia 
The following changes since commit 527c6baa294d17c5eca1d87ac941844872e90dac:

  xkb: fix check for appending '|' character when applying rules (2016-09-07 
15:16:13 +1000)

are available in the git repository at:

  https://github.com/XQuartz/xorg-server.git 

for you to fetch changes up to dd85834e3995671da908e825eaa7a228d11f0b3d:

  xquartz: Update for removal of AddEnabledDevice and RemoveEnabledDevice 
(2016-09-10 23:37:46 -0700)


Jeremy Huddleston Sequoia (4):
  XQuartz: Fix the issue where the h key could be come "stuck" after hiding 
XQuartz with cmd-h
  XQuartz: Cleanup CPPFLAGS that are no longer necessary on darwin
  os/connection: Improve abstraction for launchd secure sockets
  xquartz: Update for removal of AddEnabledDevice and RemoveEnabledDevice

 hw/xquartz/X11Application.m|  9 +
 hw/xquartz/darwin.c| 17 +++--
 hw/xquartz/pbproxy/Makefile.am |  5 ++---
 os/connection.c| 31 ++-
 4 files changed, 48 insertions(+), 14 deletions(-)



smime.p7s
Description: S/MIME cryptographic signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel