Re: [PULL] input fixes for 1.9, unloved.
On Mon, Aug 09, 2010 at 09:00:27PM -0700, Keith Packard wrote: > On Tue, 10 Aug 2010 12:04:35 +1000, Peter Hutterer > wrote: > > > > xkb: post-fix PointerKeys button events with a DeviceChangedEvent. > > > exposed by 14327858391ebe929b806efb53ad79e789361883, devices with more > > > valuators than the XTEST pointer device now skip events. > > Where is the first DCE event coming from? And, how about > FakePointerMotion? Does that need DCE afterwards as well? > You realize these code paths are a disaster, right? this is a rhetorical question, right? > > > > xkb: if the button isn't down, don't fake an event. > > > not strictly necessary for 1.9 but saves us a lot of effort, given that > > > the > > > ratio of physical releases to required XTEST releases is about a million > > > to > > > one. > > Seems reasonable to me. > > Reviewed-by: Keith Packard I've amended this one to fit on top of the v2 of the post-fix patch, the hunks are the same, just the context changed. > > > Xi: reset the unused classes pointer after copying > > > fixes a bug exposed by the first patch above. > > If the other patch exposes a bug, then this patch should be applied > first. > > Reviewed-by: Keith Packard > > (I think I might even understand this -- the unused_classes essentially > holds structures that might be used when flipping devices around) > > > > Patches have been on the list, rumours have it the few people who looked > > > at > > > them ran away screaming before throwing Reviewed-by tags my way. > > I'm with them. thanks for the reviews though, much appreciated. Cheers, Peter ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL] input fixes for 1.9, unloved.
On Tue, 10 Aug 2010 12:04:35 +1000, Peter Hutterer wrote: > > xkb: post-fix PointerKeys button events with a DeviceChangedEvent. > > exposed by 14327858391ebe929b806efb53ad79e789361883, devices with more > > valuators than the XTEST pointer device now skip events. Where is the first DCE event coming from? And, how about FakePointerMotion? Does that need DCE afterwards as well? You realize these code paths are a disaster, right? > > xkb: if the button isn't down, don't fake an event. > > not strictly necessary for 1.9 but saves us a lot of effort, given that the > > ratio of physical releases to required XTEST releases is about a million to > > one. Seems reasonable to me. Reviewed-by: Keith Packard > > Xi: reset the unused classes pointer after copying > > fixes a bug exposed by the first patch above. If the other patch exposes a bug, then this patch should be applied first. Reviewed-by: Keith Packard (I think I might even understand this -- the unused_classes essentially holds structures that might be used when flipping devices around) > > Patches have been on the list, rumours have it the few people who looked at > > them ran away screaming before throwing Reviewed-by tags my way. I'm with them. -- keith.pack...@intel.com pgpThvl9U51jX.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL] input fixes for 1.9, unloved.
On Fri, Jul 30, 2010 at 04:31:17PM +1000, Peter Hutterer wrote: > Keith, > > please pull and/or review the patches below. They are all fixes for 1.9. ping? the missing DCE postfix prevents devices with more than 2 valuators from working properly. Cheers, Peter > xkb: post-fix PointerKeys button events with a DeviceChangedEvent. > exposed by 14327858391ebe929b806efb53ad79e789361883, devices with more > valuators than the XTEST pointer device now skip events. > > xkb: if the button isn't down, don't fake an event. > not strictly necessary for 1.9 but saves us a lot of effort, given that the > ratio of physical releases to required XTEST releases is about a million to > one. > Xi: reset the unused classes pointer after copying > fixes a bug exposed by the first patch above. > > Patches have been on the list, rumours have it the few people who looked at > them ran away screaming before throwing Reviewed-by tags my way. > > Cheers, > Peter > > > The following changes since commit 750d4e82a0c1161292d24216bcff200cd6647611: > > XQuartz: xpbproxy: Don't take down the whole server on an IO error > (2010-07-29 11:41:32 -0700) > > are available in the git repository at: > git://people.freedesktop.org/~whot/xserver.git for-keith > > Peter Hutterer (3): > xkb: post-fix PointerKeys button events with a DeviceChangedEvent. > xkb: if the button isn't down, don't fake an event. > Xi: reset the unused classes pointer after copying > > Xi/exevents.c|6 ++ > xkb/xkbActions.c | 31 --- > 2 files changed, 30 insertions(+), 7 deletions(-) ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PULL] input fixes for 1.9, unloved.
Keith, please pull and/or review the patches below. They are all fixes for 1.9. xkb: post-fix PointerKeys button events with a DeviceChangedEvent. exposed by 14327858391ebe929b806efb53ad79e789361883, devices with more valuators than the XTEST pointer device now skip events. xkb: if the button isn't down, don't fake an event. not strictly necessary for 1.9 but saves us a lot of effort, given that the ratio of physical releases to required XTEST releases is about a million to one. Xi: reset the unused classes pointer after copying fixes a bug exposed by the first patch above. Patches have been on the list, rumours have it the few people who looked at them ran away screaming before throwing Reviewed-by tags my way. Cheers, Peter The following changes since commit 750d4e82a0c1161292d24216bcff200cd6647611: XQuartz: xpbproxy: Don't take down the whole server on an IO error (2010-07-29 11:41:32 -0700) are available in the git repository at: git://people.freedesktop.org/~whot/xserver.git for-keith Peter Hutterer (3): xkb: post-fix PointerKeys button events with a DeviceChangedEvent. xkb: if the button isn't down, don't fake an event. Xi: reset the unused classes pointer after copying Xi/exevents.c|6 ++ xkb/xkbActions.c | 31 --- 2 files changed, 30 insertions(+), 7 deletions(-) ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
