Re: [PATCH] glamor: don't do copy if we have 0 boxes to copy.

[Dave Airlie]

On 20 January 2016 at 03:56, Eric Anholt  wrote:
> Dave Airlie  writes:
>
>> From: Dave Airlie 
>>
>> This happens if you run twm + mplayer + xclock and drag
>> the clock over the mplayer. If we don't catch it, we cause
>> an illegal draw elements command to be passed to GL.
>
> What exactly is the error?  I was thinking it would be something about
> count == 0, but that's not an error apparently.  If there is one about
> count == 0, shouldn't we just have
> glamor_gldrawarrays_quads_using_indices() do the short circuit so the
> callers don't have to worry about it?

Why do all the lowlevel work when we can catch it before then?

essentially glamor_priv->ib_size is 0, and count is 0, so we don't set
up an IB., then we call glDrawElements without a bound IB, and it
gets upset.

Dave.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] glamor: don't do copy if we have 0 boxes to copy.

[Eric Anholt]

Dave Airlie  writes:

> From: Dave Airlie 
>
> This happens if you run twm + mplayer + xclock and drag
> the clock over the mplayer. If we don't catch it, we cause
> an illegal draw elements command to be passed to GL.

What exactly is the error?  I was thinking it would be something about
count == 0, but that's not an error apparently.  If there is one about
count == 0, shouldn't we just have
glamor_gldrawarrays_quads_using_indices() do the short circuit so the
callers don't have to worry about it?


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel