Re: [PATCH 2/6] XKB: Simplify a loop in ProcXkbGetKbdByName

2011-05-10 Thread Cyril Brulebois 
Hi,

Daniel Stone  (10/05/2011):
> Yes.  I could probably call it out in the commit message if that
> would help?

for a random passerby like I am, that'd be nice; but I'm also happy as
it is if everything is like intended. :)

Mraw,
KiBi.


signature.asc
Description: Digital signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/6] XKB: Simplify a loop in ProcXkbGetKbdByName

2011-05-09 Thread Daniel Stone 
Hi,

On Mon, May 09, 2011 at 06:34:09PM +0200, Cyril Brulebois wrote:
> Sorry I'm late but:
> 
> Daniel Stone  (05/05/2011):
> > Replace:
> > for (stuff; things; etc) {
> > if (misc || other) {
> > [...]
> > }
> > }
> > with:
> > for (stuff; things; etc) {
> > if (!misc && !other)
> > continue;
> > [...]
> > }
> 
> that says nothing about that:
> 
> > -if ((tmpd == dev) || (!IsMaster(tmpd) && GetMaster(tmpd, 
> > MASTER_KEYBOARD) == dev)) {
> > +if (tmpd != dev && GetMaster(tmpd, MASTER_KEYBOARD) != dev)
> 
> You're losing one part here; was that on purpose?

Yes.  I could probably call it out in the commit message if that would
help?

Cheers,
Daniel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/6] XKB: Simplify a loop in ProcXkbGetKbdByName

2011-05-09 Thread Cyril Brulebois 
Sorry I'm late but:

Daniel Stone  (05/05/2011):
> Replace:
> for (stuff; things; etc) {
> if (misc || other) {
> [...]
> }
> }
> with:
> for (stuff; things; etc) {
> if (!misc && !other)
> continue;
> [...]
> }

that says nothing about that:

> -if ((tmpd == dev) || (!IsMaster(tmpd) && GetMaster(tmpd, 
> MASTER_KEYBOARD) == dev)) {
> +if (tmpd != dev && GetMaster(tmpd, MASTER_KEYBOARD) != dev)

You're losing one part here; was that on purpose?

Mraw,
KiBi.


signature.asc
Description: Digital signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel