Re: [PATCH v2] NEED_SYNC_REPLY flag should be in Xim not in Xic

2011-10-11 Thread Jeremy Huddleston 
On Oct 11, 2011, at 18:34, Choe Hwanjin wrote:

 I've made my patch again against libX11 git master
 22ba43d198dcca86c88eb15a56fc7d8fc47c422e.
 This patch already has changes that revert commit
 1a1a42a3ca1dfaf42f1094936b71c140fc030fcb.
 I don't see any significant differences between your patch and mine.

I just sent what was in SuSE's logs.  I'm just confused by the multiple 
versions and thought that was the final one.

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH v2] NEED_SYNC_REPLY flag should be in Xim not in Xic

2011-10-11 Thread Choe Hwanjin 
I've made my patch again against libX11 git master
22ba43d198dcca86c88eb15a56fc7d8fc47c422e.
This patch already has changes that revert commit
1a1a42a3ca1dfaf42f1094936b71c140fc030fcb.
I don't see any significant differences between your patch and mine.

And your patch have some problem.
See below.

2011/10/12 Jeremy Huddleston jerem...@apple.com:
 @@ -708,7 +704,7 @@ _XimCommitRecv(

 (void)_XimRespSyncReply(ic, flag);

 -MARK_FABLICATED(ic);
 +MARK_FABRICATED(ic);

 ev.type = KeyPress;
 ev.send_event = False;

MARK_FABRICATED(ic); should be MARK_FABRICATED(im);
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel