Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-23 Thread Eric Anholt 
Alan Coopersmith  writes:

> On 11/22/16 04:58 PM, Eric Anholt wrote:
>> Adam Jackson  writes:
>>
>>> Signed-off-by: Adam Jackson 
>>> ---
>>>  configure.ac | 5 +
>>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 6fd853b..93c81a6 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -2138,10 +2138,7 @@ AM_CONDITIONAL([XORG_DRIVER_MODESETTING], [test 
>>> "x$XORG_DRIVER_MODESETTING" = xy
>>>
>>>  dnl glamor
>>>  if test "x$GLAMOR" = xauto; then
>>> -   if test "x$XORG" = xyes; then
>>> -   GLAMOR=yes
>>> -   fi
>>> -   if test "x$XEPHYR" = xyes; then
>>> +   if echo "$XORG" "$XEPHYR" "$XWAYLAND" | grep -q yes ; then
>>> GLAMOR=yes
>>> fi
>>>  fi
>>
>> Doesn't that want a "> /dev/null" to not spit the 'yes' into the
>> configure output?  Other than that, this is great.
>
> Isn't that what the -q option to grep does?

Missed that.  In that case,

Reviewed-by: Eric Anholt 



signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-23 Thread Pekka Paalanen 
On Tue, 22 Nov 2016 10:51:24 -0500
Adam Jackson  wrote:

> Signed-off-by: Adam Jackson 
> ---
>  configure.ac | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 6fd853b..93c81a6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2138,10 +2138,7 @@ AM_CONDITIONAL([XORG_DRIVER_MODESETTING], [test 
> "x$XORG_DRIVER_MODESETTING" = xy
>  
>  dnl glamor
>  if test "x$GLAMOR" = xauto; then
> - if test "x$XORG" = xyes; then
> - GLAMOR=yes
> - fi
> - if test "x$XEPHYR" = xyes; then
> + if echo "$XORG" "$XEPHYR" "$XWAYLAND" | grep -q yes ; then
>   GLAMOR=yes
>   fi
>  fi

Hi Adam,

thanks for this, works nicely enabling glamor when I build only Xwayland.

Reviewed-by: Pekka Paalanen 
Tested-by: Pekka Paalanen 


Thanks,
pq


pgpLkUWYo2740.pgp
Description: OpenPGP digital signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-22 Thread Alan Coopersmith 

On 11/22/16 04:58 PM, Eric Anholt wrote:

Adam Jackson  writes:


Signed-off-by: Adam Jackson 
---
 configure.ac | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 6fd853b..93c81a6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2138,10 +2138,7 @@ AM_CONDITIONAL([XORG_DRIVER_MODESETTING], [test 
"x$XORG_DRIVER_MODESETTING" = xy

 dnl glamor
 if test "x$GLAMOR" = xauto; then
-   if test "x$XORG" = xyes; then
-   GLAMOR=yes
-   fi
-   if test "x$XEPHYR" = xyes; then
+   if echo "$XORG" "$XEPHYR" "$XWAYLAND" | grep -q yes ; then
GLAMOR=yes
fi
 fi


Doesn't that want a "> /dev/null" to not spit the 'yes' into the
configure output?  Other than that, this is great.


Isn't that what the -q option to grep does?

--
-Alan Coopersmith-  alan.coopersm...@oracle.com
 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-22 Thread Eric Anholt 
Adam Jackson  writes:

> Signed-off-by: Adam Jackson 
> ---
>  configure.ac | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 6fd853b..93c81a6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2138,10 +2138,7 @@ AM_CONDITIONAL([XORG_DRIVER_MODESETTING], [test 
> "x$XORG_DRIVER_MODESETTING" = xy
>  
>  dnl glamor
>  if test "x$GLAMOR" = xauto; then
> - if test "x$XORG" = xyes; then
> - GLAMOR=yes
> - fi
> - if test "x$XEPHYR" = xyes; then
> + if echo "$XORG" "$XEPHYR" "$XWAYLAND" | grep -q yes ; then
>   GLAMOR=yes
>   fi
>  fi

Doesn't that want a "> /dev/null" to not spit the 'yes' into the
configure output?  Other than that, this is great.


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-22 Thread Daniel Stone 
On 22 November 2016 at 15:51, Adam Jackson  wrote:
> Signed-off-by: Adam Jackson 

Acked-by: Daniel Stone 
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel