Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

2011-09-15 Thread Jamey Sharp 
Reviewed-by: Jamey Sharp 

On Thu, Sep 15, 2011 at 11:20:21PM +0600, Alexandr Shadchin wrote:
> Signed-off-by: Alexandr Shadchin 
> ---
>  hw/xfree86/os-support/bsd/bsd_bell.c |4 
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/xfree86/os-support/bsd/bsd_bell.c 
> b/hw/xfree86/os-support/bsd/bsd_bell.c
> index 55eb752..fb457db 100644
> --- a/hw/xfree86/os-support/bsd/bsd_bell.c
> +++ b/hw/xfree86/os-support/bsd/bsd_bell.c
> @@ -37,10 +37,6 @@
>  #include "xf86Priv.h"
>  #include "xf86_OSlib.h"
>  
> -#ifdef WSCONS_SUPPORT
> -#define KBD_FD(i) ((i).kbdFd != -1 ? (i).kbdFd : (i).consoleFd)
> -#endif
> -
>  void
>  xf86OSRingBell(int loudness, int pitch, int duration)
>  {
> -- 
> 1.7.6
> 
> ___
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


signature.asc
Description: Digital signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

2011-09-15 Thread Jeremy Huddleston 
I review this in the sense that the comments match the src changes and look 
well formed.  Hopefully another BSD developer can vouch for whether they 
actually "do the right thing" rather than just "do the stated thing"

Reviewed-by: Jeremy Huddleston 

On Sep 15, 2011, at 12:20 PM, Alexandr Shadchin wrote:

> Signed-off-by: Alexandr Shadchin 
> ---
> hw/xfree86/os-support/bsd/bsd_bell.c |4 
> 1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/xfree86/os-support/bsd/bsd_bell.c 
> b/hw/xfree86/os-support/bsd/bsd_bell.c
> index 55eb752..fb457db 100644
> --- a/hw/xfree86/os-support/bsd/bsd_bell.c
> +++ b/hw/xfree86/os-support/bsd/bsd_bell.c
> @@ -37,10 +37,6 @@
> #include "xf86Priv.h"
> #include "xf86_OSlib.h"
> 
> -#ifdef WSCONS_SUPPORT
> -#define KBD_FD(i) ((i).kbdFd != -1 ? (i).kbdFd : (i).consoleFd)
> -#endif
> -
> void
> xf86OSRingBell(int loudness, int pitch, int duration)
> {
> -- 
> 1.7.6
> 
> ___
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel



---
Jeremy Huddleston

Rebuild Sudan
 - Board of Directors
 - http://www.rebuildsudan.org

Berkeley Foundation for Opportunities in Information Technology
 - Advisory Board
 - http://www.bfoit.org

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

2011-09-17 Thread Matthieu Herrb 
On Thu, Sep 15, 2011 at 11:20:21PM +0600, Alexandr Shadchin wrote:
> Signed-off-by: Alexandr Shadchin 

For the serie:

Tested-by: Matthieu Herrb 

(On OpenBSD/i386 and amd64 only, but the changes for other platforms
look ok too).
-- 
Matthieu Herrb
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

2011-09-17 Thread Matthieu Herrb 
On Sat, Sep 17, 2011 at 01:29:58PM +0200, Matthieu Herrb wrote:
> On Thu, Sep 15, 2011 at 11:20:21PM +0600, Alexandr Shadchin wrote:
> > Signed-off-by: Alexandr Shadchin 
> 
> For the serie:
> 
> Tested-by: Matthieu Herrb 
> 
> (On OpenBSD/i386 and amd64 only, but the changes for other platforms
> look ok too).

Note that this breaks the kbd driver ABI on BSD systems, since xf86Info
changes. 

(But maybe accessing xf86Info directly from the kbd driver is a
violation of the ABI by itself...)
-- 
Matthieu Herrb
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel