Re: convert some more users to the screen conversion functions.

2012-05-18 Thread Dave Airlie
On Fri, May 18, 2012 at 12:09 AM, Keith Packard kei...@keithp.com wrote:
 Dave Airlie airl...@gmail.com writes:

 These are just some more simple patches to move to using the Screen-Scrn
 and Scrn-Screen conversion functions in various parts of the server.

 I'm wondering if you've tested these to see if the server builds without
 publishing the two global arrays any more.

Well these + all the ABI changes + some other misc bits, I could
remove xf86Screens from being exported,
screenInfo is required for protocol extensions, but we can probably
work on wrapping it a bit,

With dynamic GPU screens, drivers doing protocol extensions will need
to provide an impedance layer for that anyways.

Dave.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


Re: convert some more users to the screen conversion functions.

2012-05-18 Thread Keith Packard
Dave Airlie airl...@gmail.com writes:

 On Fri, May 18, 2012 at 12:09 AM, Keith Packard kei...@keithp.com wrote:

 Well these + all the ABI changes + some other misc bits, I could
 remove xf86Screens from being exported,
 screenInfo is required for protocol extensions, but we can probably
 work on wrapping it a bit,

wondering if you can pull the screens out of screenInfo at least. If
we're changing the desired API/ABI, it might be good to enforce it with
the linker :-)

 With dynamic GPU screens, drivers doing protocol extensions will need
 to provide an impedance layer for that anyways.

yeah, that's gonna be fun.

-- 
keith.pack...@intel.com


pgpZKgrCe3OZC.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: convert some more users to the screen conversion functions.

2012-05-18 Thread Dave Airlie
On Fri, May 18, 2012 at 4:50 PM, Keith Packard kei...@keithp.com wrote:
 Dave Airlie airl...@gmail.com writes:

 On Fri, May 18, 2012 at 12:09 AM, Keith Packard kei...@keithp.com wrote:

 Well these + all the ABI changes + some other misc bits, I could
 remove xf86Screens from being exported,
 screenInfo is required for protocol extensions, but we can probably
 work on wrapping it a bit,

 wondering if you can pull the screens out of screenInfo at least. If
 we're changing the desired API/ABI, it might be good to enforce it with
 the linker :-)

Not really, xf86Screens yes, but screenInfo.screens will still
represent protocol screens going forward,

and people adding extensions in their drivers will still need access to it.

Dave.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


Re: convert some more users to the screen conversion functions.

2012-05-18 Thread Keith Packard
Dave Airlie airl...@gmail.com writes:

 Not really, xf86Screens yes, but screenInfo.screens will still
 represent protocol screens going forward,

yeah, there are over 500 references to screenInfo.screens in the server
source code.

 and people adding extensions in their drivers will still need access
 to it.

Of coruse.

-- 
keith.pack...@intel.com


pgp37YKZEG6CC.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: convert some more users to the screen conversion functions.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes:

 These are just some more simple patches to move to using the Screen-Scrn
 and Scrn-Screen conversion functions in various parts of the server.

I'm wondering if you've tested these to see if the server builds without
publishing the two global arrays any more.

-- 
keith.pack...@intel.com


pgparNxHhFa5e.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: convert some more users to the screen conversion functions.

2012-05-15 Thread Adam Jackson

On 5/14/12 8:00 AM, Dave Airlie wrote:

These are just some more simple patches to move to using the Screen-Scrn
and Scrn-Screen conversion functions in various parts of the server.

The last is an API change but should be fine from ABI pov.

These are last set of patches before major ABI breakage set.


For the series:

Reviewed-by: Adam Jackson a...@redhat.com

- ajax

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel