segfault after commit GLX: Enable GLX 1.4 on DRI2

2009-10-01 Thread Markus Amsler 
After

commit ad5c0d9efa47476ed5cf75c82265c73919e468b4
Author: Ian Romanick 
Date:   Tue Sep 29 16:43:43 2009 -0700
GLX: Enable GLX 1.4 on DRI2

I'm getting segfaults at server startup in glx/glxext.c:373:

for (p = __glXProviderStack; p != NULL; p = p->next) {
__GLXscreen *glxScreen;

glxScreen = p->screenProbe(pScreen);
if (glxScreen != NULL) {
LogMessage(X_INFO,
   "GLX: Initialized %s GL provider for screen 
%d\n",
   p->name, i);
break;
}

if (glxScreen->GLXminor < glxMinorVersion)
glxMinorVersion = glxScreen->GLXminor;
}


This code doesn't make sense because if glxScreen is NULL it runs 
straight into an segfault with glxScreen->GLXminor

Markus
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel

Re: segfault after commit GLX: Enable GLX 1.4 on DRI2

2009-10-01 Thread Ian Romanick 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Markus Amsler wrote:
> After
> 
> commit ad5c0d9efa47476ed5cf75c82265c73919e468b4
> Author: Ian Romanick 
> Date:   Tue Sep 29 16:43:43 2009 -0700
> GLX: Enable GLX 1.4 on DRI2
> 
> I'm getting segfaults at server startup in glx/glxext.c:373:
> 
> for (p = __glXProviderStack; p != NULL; p = p->next) {
> __GLXscreen *glxScreen;
> 
> glxScreen = p->screenProbe(pScreen);
> if (glxScreen != NULL) {
> LogMessage(X_INFO,
>"GLX: Initialized %s GL provider for screen 
> %d\n",
>p->name, i);
> break;
> }
> 
> if (glxScreen->GLXminor < glxMinorVersion)
> glxMinorVersion = glxScreen->GLXminor;
> }
> 
> 
> This code doesn't make sense because if glxScreen is NULL it runs 
> straight into an segfault with glxScreen->GLXminor

This should be fixed by Dave's patch.  Look for the message with the
subject "[PATCH] glx: fixup deref of null pointer when glx screen init
fails."
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrE7AAACgkQX1gOwKyEAw/R1wCbB/pIYeMbX7p9TEdFOkAXm4mR
HCEAn2pybOke8/0+dNT6tDEn5+RuGd6L
=3wez
-END PGP SIGNATURE-
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel