Re: xdm <-> xdmcp
On Mon, 2010-12-20 at 08:56 -0500, Adam Jackson wrote: > The ones I pushed hadn't been nacked, I didn't think? Regardless, > yeah, > revert. > Correct. A number of similar patches were posted within a 6 day period with various reviewers responding to various patches. That leaves one patch for which I posted a revert and would appreciate a review. http://lists.x.org/archives/xorg-devel/2010-December/017299.html My main concern is introducing 2 ways of exporting/hiding symbols that are far apart (Makefile and source code). It's just error prone. Other libraries use _X_EXPORT and _X_HIDDEN and we should stick to this method, even if a "one liner in the makefile" appears to be a short term gain. Thanks Gaetan signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xdm <-> xdmcp
On Sat, 2010-12-18 at 10:59 -0500, Gaetan Nadon wrote: > On Fri, 2010-12-17 at 08:35 -0500, Trevor Woerner wrote: > > Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find > > the following symbols: > > _XdmcpAuthSetup > > _XdmcpAuthDoIt > > _XdmcpWrapperToOddParity > > I don't understand why this patch, and a few other similar ones, were > pushed as they were Nacked by 4 reviewers. They should be reverted and > redone properly. The problem that occurred is exactly what happens > when relying on a naming convention. Sooner or later it will break. > All other libraries do it in the source code. The ones I pushed hadn't been nacked, I didn't think? Regardless, yeah, revert. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xdm <-> xdmcp
On Fri, Dec 17, 2010 at 08:35:27 -0500, Trevor Woerner wrote: > The following commit in lib/libXdmcp: > > commit b64cac63e0bcdd87bbfd19678552fd7ed1a3b58f > Author: Cristian RodrÃguez > Date: Tue Dec 14 15:40:20 2010 -0500 > > Export only public API symbols > > Reviewed-by: Adam Jackson > Signed-off-by: Cristian RodrÃguez > > Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find > the following symbols: > _XdmcpAuthSetup > _XdmcpAuthDoIt > _XdmcpWrapperToOddParity Reverted. Thanks. Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xdm <-> xdmcp
On Fri, 2010-12-17 at 08:35 -0500, Trevor Woerner wrote: > The following commit in lib/libXdmcp: > > commit b64cac63e0bcdd87bbfd19678552fd7ed1a3b58f > Author: Cristian RodrÃguez > Date: Tue Dec 14 15:40:20 2010 -0500 > > Export only public API symbols > > Reviewed-by: Adam Jackson > Signed-off-by: Cristian RodrÃguez > > Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find > the following symbols: > _XdmcpAuthSetup > _XdmcpAuthDoIt > _XdmcpWrapperToOddParity I don't understand why this patch, and a few other similar ones, were pushed as they were Nacked by 4 reviewers. They should be reverted and redone properly. The problem that occurred is exactly what happens when relying on a naming convention. Sooner or later it will break. All other libraries do it in the source code. Gaetan > ___ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
xdm <-> xdmcp
The following commit in lib/libXdmcp: commit b64cac63e0bcdd87bbfd19678552fd7ed1a3b58f Author: Cristian RodrÃguez Date: Tue Dec 14 15:40:20 2010 -0500 Export only public API symbols Reviewed-by: Adam Jackson Signed-off-by: Cristian RodrÃguez Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find the following symbols: _XdmcpAuthSetup _XdmcpAuthDoIt _XdmcpWrapperToOddParity ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
