[PATCH xf86-video-amdgpu] Link against libgbm
From: Michel Dänzer Fixes unresolved symbol "gbm_create_device". Reported-and-Tested-by: Brian Paterni Signed-off-by: Michel Dänzer --- configure.ac| 1 + src/Makefile.am | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ead206e..946c70e 100644 --- a/configure.ac +++ b/configure.ac @@ -73,6 +73,7 @@ XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto) # Checks for libraries. PKG_CHECK_MODULES(LIBDRM, [libdrm >= 2.4.46]) PKG_CHECK_MODULES(LIBDRM_AMDGPU, [libdrm_amdgpu]) +PKG_CHECK_MODULES(GBM, [gbm]) # Obtain compiler/linker options for the driver dependencies PKG_CHECK_MODULES(XORG, [xorg-server >= 1.7 xproto fontsproto xf86driproto $REQUIRED_MODULES]) diff --git a/src/Makefile.am b/src/Makefile.am index 817da2d..8715eb3 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -26,11 +26,12 @@ # _ladir passes a dummy rpath to libtool so the thing will actually link # TODO: -nostdlib/-Bstatic/-lgcc platform magic, not installing the .a, etc. -amdgpu_drv_la_LIBADD = $(PCIACCESS_LIBS) $(LIBDRM_AMDGPU_LIBS) +amdgpu_drv_la_LIBADD = $(PCIACCESS_LIBS) $(LIBDRM_AMDGPU_LIBS) $(GBM_LIBS) AMDGPU_KMS_SRCS=amdgpu_dri2.c amdgpu_kms.c drmmode_display.c amdgpu_bo_helper.c AM_CFLAGS = \ +@GBM_CFLAGS@ \ @LIBDRM_AMDGPU_CFLAGS@ \ @XORG_CFLAGS@ \ @LIBUDEV_CFLAGS@ -- 2.1.4 ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati
Re: [PATCH 3/3] present: Disable check for compatible tiling flags.
[ Adding the xorg-driver-ati mailing list, please post DDX driver
patches there ]
On 09.05.2015 14:24, Mario Kleiner wrote:
> Commit 5921ba4ca705a0d919515626088f3948cc4848c1
> "Don't flip between BOs with different tiling parameters"
> breaks page flipping completely, even on a simple non-prime
> configuration, at least on the tested Radeon HD 4670, due to
> incompatible tiling flags between pixmap and screen pixmap.
>
> This is just a hack which fixes pageflipping on that gpu,
> not intended for merging, just to illustrate that something
> is missing here.
>
> Signed-off-by: Mario Kleiner
> ---
> src/radeon_present.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/radeon_present.c b/src/radeon_present.c
> index 53819e0..53634ad 100644
> --- a/src/radeon_present.c
> +++ b/src/radeon_present.c
> @@ -257,11 +257,12 @@ radeon_present_check_flip(RRCrtcPtr crtc, WindowPtr
> window, PixmapPtr pixmap,
> /* The kernel driver doesn't handle flipping between BOs with different
> * tiling parameters correctly yet
> */
> +/*
> screen_pixmap = screen->GetScreenPixmap(screen);
> if (radeon_present_get_pixmap_tiling_flags(info, pixmap) !=
> radeon_present_get_pixmap_tiling_flags(info, screen_pixmap))
> return FALSE;
> -
> +*/
> if (crtc) {
> drmmode_crtc_private_ptr drmmode_crtc = get_drmmode_crtc(scrn, crtc);
>
>
We probably need to ignore more bits in
radeon_present_get_pixmap_tiling_flags(). What does it currently return
for each pixmap for you in the failing case?
Patches 1 and 2 look good, I'm planning to push them soon, thanks!
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-driver-ati
[Bug 90299] Xorg crashes when running xscreensaver-demo (during preview of certain screensavers)
https://bugs.freedesktop.org/show_bug.cgi?id=90299 Max changed: What|Removed |Added Attachment #115672|0 |1 is obsolete|| --- Comment #11 from Max --- Created attachment 115674 --> https://bugs.freedesktop.org/attachment.cgi?id=115674&action=edit GDB log of crash 2 -- You are receiving this mail because: You are the assignee for the bug. ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati
[Bug 90299] Xorg crashes when running xscreensaver-demo (during preview of certain screensavers)
https://bugs.freedesktop.org/show_bug.cgi?id=90299 --- Comment #10 from Max --- Slightly more verbose output: Program received signal SIGSEGV, Segmentation fault. 0x7fa4e581620e in fbBltOne ( src=0x1d62064, srcStride=0, srcX=0, dst=0x5dcc8, dstStride=493, dstX=0, dstBpp=32, width=10848, height=254, fgand=0, fgxor=13253692, bgand=0, bgxor=8768060) at fbbltone.c:334 334WRITE(dst, FbOpaqueStipple(mask, fgxor, bgxor)); #0 0x7fa4e581620e in fbBltOne ( src=0x1d62064, srcStride=0, srcX=0, dst=0x5dcc8, dstStride=493, dstX=0, dstBpp=32, width=10848, height=254, fgand=0, fgxor=13253692, bgand=0, bgxor=8768060) at fbbltone.c:334 #1 0x7fa4e581857a in fbCopy1toN ( pSrcDrawable=0x1d61ff0, pDstDrawable=0x1d07c80, pGC=0x1d1f460, pbox=0x7ffc8c4faed0, nbox=0, dx=-372, dy=-416, reverse=0, upsidedown=0, bitplane=1, closure=0x0) at fbcopy.c:123 #2 0x7fa4eafbac02 in glamor_copy_bail (src=0x1d61ff0, dst=0x1d07c80, gc=0x1d1f460, box=0x7ffc8c4faed0, nbox=1, dx=-372, dy=-416, reverse=0, upsidedown=0, bitplane=1, closure=0x0) at glamor_copy.c:171 #3 0x7fa4eafbbe46 in glamor_copy ( src=0x1d61ff0, dst=0x1d07c80, gc=0x1d1f460, box=0x7ffc8c4faed0, nbox=1, dx=-372, dy=-416, reverse=0, upsidedown=0, bitplane=1, closure=0x0) at glamor_copy.c:661 #4 0x005f2191 in miCopyRegion ( pSrcDrawable=0x1d61ff0, pDstDrawable=0x1d07c80, pGC=0x1d1f460, pDstRegion=0x7ffc8c4faed0, dx=-372, dy=-416, copyProc=0x7fa4eafbbdae , bitPlane=1, closure=0x0) at micopy.c:121 #5 0x005f26cc in miDoCopy ( pSrcDrawable=0x1d61ff0, pDstDrawable=0x1d07c80, pGC=0x1d1f460, xIn=0, yIn=0, widthSrc=339, heightSrc=255, xOut=372, yOut=416, copyProc=0x7fa4eafbbdae , bitPlane=1, closure=0x0) at micopy.c:296 #6 0x7fa4eafbbf6f in glamor_copy_plane (src=0x1d61ff0, dst=0x1d07c80, gc=0x1d1f460, srcx=0, srcy=0, width=339, height=255, dstx=0, dsty=0, bitplane=1) at glamor_copy.c:681 #7 0x00570635 in damageCopyPlane ( pSrc=0x1d61ff0, pDst=0x1d07c80, pGC=0x1d1f460, srcx=0, srcy=0, width=339, height=255, dstx=0, dsty=0, bitPlane=1) at damage.c:797 #8 0x00436173 in ProcCopyPlane ( client=0x1d2efd0) at dispatch.c:1719 #9 0x00432c68 in Dispatch () at dispatch.c:432 #10 0x00440d1d in dix_main ( argc=10, argv=0x7ffc8c4fb278, envp=0x7ffc8c4fb2d0) at main.c:298 #11 0x0042372e in main (argc=10, argv=0x7ffc8c4fb278, envp=0x7ffc8c4fb2d0) at stubmain.c:34 Continuing. -- You are receiving this mail because: You are the assignee for the bug. ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati
[Bug 90299] Xorg crashes when running xscreensaver-demo (during preview of certain screensavers)
https://bugs.freedesktop.org/show_bug.cgi?id=90299 --- Comment #9 from Max --- My distro using sources from: http://xorg.freedesktop.org/releases/individual/xserver/xorg-server-1.17.1.tar.bz2 Same as I use. -- You are receiving this mail because: You are the assignee for the bug. ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati
[Bug 90299] Xorg crashes when running xscreensaver-demo (during preview of certain screensavers)
https://bugs.freedesktop.org/show_bug.cgi?id=90299 --- Comment #8 from Max --- Here is my configuration parameters for the xorg-server build: CFLAGS='-O0 -g3' ./configure --prefix=/usr \ --enable-ipv6 \ --enable-dri \ --enable-dmx \ --enable-xvfb \ --enable-xnest \ --enable-composite \ --enable-xcsecurity \ --enable-libunwind \ --enable-xorg \ --enable-xephyr \ --enable-glamor \ --enable-xwayland \ --enable-glx-tls \ --enable-kdrive \ --enable-kdrive-evdev \ --enable-kdrive-kbd \ --enable-kdrive-mouse \ --enable-config-udev \ --enable-systemd-logind \ --enable-suid-wrapper \ --disable-install-setuid \ --enable-record \ --disable-xfbdev \ --disable-xfake \ --disable-static \ --libexecdir=/usr/lib/xorg-server \ --sysconfdir=/etc \ --localstatedir=/var \ --with-xkb-path=/usr/share/X11/xkb \ --with-xkb-output=/var/lib/xkb \ --with-fontrootdir=/usr/share/fonts \ --with-sha1=libgcrypt -- You are receiving this mail because: You are the assignee for the bug. ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati
[Bug 90299] Xorg crashes when running xscreensaver-demo (during preview of certain screensavers)
https://bugs.freedesktop.org/show_bug.cgi?id=90299 --- Comment #7 from Max --- Created attachment 115672 --> https://bugs.freedesktop.org/attachment.cgi?id=115672&action=edit GDB log of crash GDB output uploaded in the attachments. Here the backtrace itself: Program received signal SIGSEGV, Segmentation fault. 0x7f75c6ef620e in fbBltOne ( src=0x244fd14, srcStride=0, srcX=0, dst=0x5dcc8, dstStride=493, dstX=0, dstBpp=32, width=10848, height=254, fgand=0, fgxor=12925755, bgand=0, bgxor=8570171) at fbbltone.c:334 334fbbltone.c: No such file or directory. #0 0x7f75c6ef620e in fbBltOne ( src=0x244fd14, srcStride=0, srcX=0, dst=0x5dcc8, dstStride=493, dstX=0, dstBpp=32, width=10848, height=254, fgand=0, fgxor=12925755, bgand=0, bgxor=8570171) at fbbltone.c:334 #1 0x7f75c6ef857a in fbCopy1toN ( pSrcDrawable=0x244fca0, pDstDrawable=0x2486360, pGC=0x24818e0, pbox=0x7ffc29396d90, nbox=0, dx=-372, dy=-683, reverse=0, upsidedown=0, bitplane=1, closure=0x0) at fbcopy.c:123 #2 0x7f75cc69ac02 in glamor_copy_bail (src=0x244fca0, dst=0x2486360, gc=0x24818e0, box=0x7ffc29396d90, nbox=1, dx=-372, dy=-683, reverse=0, upsidedown=0, bitplane=1, closure=0x0) at glamor_copy.c:171 #3 0x7f75cc69be46 in glamor_copy ( src=0x244fca0, dst=0x2486360, gc=0x24818e0, box=0x7ffc29396d90, nbox=1, dx=-372, dy=-683, reverse=0, upsidedown=0, bitplane=1, closure=0x0) at glamor_copy.c:661 #4 0x005f2191 in miCopyRegion ( pSrcDrawable=0x244fca0, pDstDrawable=0x2486360, pGC=0x24818e0, pDstRegion=0x7ffc29396d90, dx=-372, dy=-683, copyProc=0x7f75cc69bdae , bitPlane=1, closure=0x0) at micopy.c:121 #5 0x005f26cc in miDoCopy ( pSrcDrawable=0x244fca0, pDstDrawable=0x2486360, pGC=0x24818e0, xIn=0, yIn=0, widthSrc=339, heightSrc=255, xOut=372, yOut=683, copyProc=0x7f75cc69bdae , bitPlane=1, closure=0x0) at micopy.c:296 #6 0x7f75cc69bf6f in glamor_copy_plane (src=0x244fca0, dst=0x2486360, gc=0x24818e0, srcx=0, srcy=0, width=339, height=255, dstx=0, dsty=0, bitplane=1) at glamor_copy.c:681 #7 0x00570635 in damageCopyPlane ( pSrc=0x244fca0, pDst=0x2486360, pGC=0x24818e0, srcx=0, srcy=0, width=339, height=255, dstx=0, dsty=0, bitPlane=1) at damage.c:797 #8 0x00436173 in ProcCopyPlane ( client=0x23937e0) at dispatch.c:1719 #9 0x00432c68 in Dispatch () at dispatch.c:432 #10 0x00440d1d in dix_main ( argc=10, argv=0x7ffc29397138, envp=0x7ffc29397190) at main.c:298 #11 0x0042372e in main (argc=10, argv=0x7ffc29397138, envp=0x7ffc29397190) at stubmain.c:34 -- You are receiving this mail because: You are the assignee for the bug. ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati
