[Xpert]bug (?) in xf86pciBus.c

2002-09-04 Thread Andy Isaacson

I have a Vaio r505te laptop, with the i810 chipset.  I'm running FreeBSD
4.5.  dmesg, XFree86.0.log, and XF86Config are at
http://web.hexapodia.org/~adi/sart/freebsd/

XFree86 (head of CVS as of September 3) was locking up after printing
Setting vga for screen 0..  I fixed it by adding this patch:

Index: hw/xfree86/common/xf86pciBus.c
===
RCS file: /cvsup/XFree86/xc/programs/Xserver/hw/xfree86/common/xf86pciBus.c,v
retrieving revision 3.54
diff -u -r3.54 xf86pciBus.c
--- hw/xfree86/common/xf86pciBus.c  2002/08/27 22:07:06 3.54
+++ hw/xfree86/common/xf86pciBus.c  2002/09/05 05:37:24
@@ -665,7 +665,7 @@
 ptr-current = NULL;
 
 /* walk down */
-while (ptr-primary) { /* no enable for top bus */
+while (ptr-primary  ptr != ptr-primary) { /* no enable for top bus */
if (ptr-primary-current != ptr) {
if (ptr-primary-current  ptr-primary-current-disable_f)
ptr-primary-current-disable_f(ptr-primary-current);


Would anyone like me to run any tests, or try out test patches, to help
figure out what went wrong here?  I don't understand how ptr ==
ptr-primary could possibly happen.

-andy
___
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert



Re: [Xpert]bug (?) in xf86pciBus.c

2002-09-04 Thread Marc Aurele La France

On Thu, 5 Sep 2002, Andy Isaacson wrote:

 I have a Vaio r505te laptop, with the i810 chipset.  I'm running FreeBSD
 4.5.  dmesg, XFree86.0.log, and XF86Config are at
 http://web.hexapodia.org/~adi/sart/freebsd/

 XFree86 (head of CVS as of September 3) was locking up after printing
 Setting vga for screen 0..  I fixed it by adding this patch:

 Index: hw/xfree86/common/xf86pciBus.c
 ===
 RCS file: /cvsup/XFree86/xc/programs/Xserver/hw/xfree86/common/xf86pciBus.c,v
 retrieving revision 3.54
 diff -u -r3.54 xf86pciBus.c
 --- hw/xfree86/common/xf86pciBus.c2002/08/27 22:07:06 3.54
 +++ hw/xfree86/common/xf86pciBus.c2002/09/05 05:37:24
 @@ -665,7 +665,7 @@
  ptr-current = NULL;

  /* walk down */
 -while (ptr-primary) { /* no enable for top bus */
 +while (ptr-primary  ptr != ptr-primary) { /* no enable for top bus */
   if (ptr-primary-current != ptr) {
   if (ptr-primary-current  ptr-primary-current-disable_f)
   ptr-primary-current-disable_f(ptr-primary-current);

 Would anyone like me to run any tests, or try out test patches, to help
 figure out what went wrong here?  I don't understand how ptr ==
 ptr-primary could possibly happen.

This is a known issue that I hope to address fairly shortly.

Marc.

+--+---+
|  Marc Aurele La France   |  work:   1-780-492-9310   |
|  Computing and Network Services  |  fax:1-780-492-1729   |
|  352 General Services Building   |  email:  [EMAIL PROTECTED]  |
|  University of Alberta   +---+
|  Edmonton, Alberta   |   |
|  T6G 2H1 | Standard disclaimers apply|
|  CANADA  |   |
+--+---+
XFree86 Core Team member.  ATI driver and X server internals.

___
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert