Re: [xslt] [PATCH] New-line terminate error message that missed this convention

[Nick Wellnhofer]

On 12/05/2017 16:10, Jan Pokorný wrote:

That could confuse library users that set their own error handler,
because there are already cases in libxslt that push a single message
in chunks (the same way as libxml2 does) and the user may be interested
in performing the message reconstruction on its own.


Applied here:

https://git.gnome.org/browse/libxslt/commit/?id=896caefc40111ac225a36500fe464f5d18a955c8

Thanks for the patch,

Nick

___
xslt mailing list, project page http://xmlsoft.org/XSLT/
xslt@gnome.org
https://mail.gnome.org/mailman/listinfo/xslt

[xslt] [PATCH] New-line terminate error message that missed this convention

[Jan Pokorný]

That could confuse library users that set their own error handler,
because there are already cases in libxslt that push a single message
in chunks (the same way as libxml2 does) and the user may be interested
in performing the message reconstruction on its own.

Quick scan only discovered this occurrence, but there may be more.

Signed-off-by: Jan Pokorný 
---
 libxslt/numbers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libxslt/numbers.c b/libxslt/numbers.c
index e78c46b..548bbf1 100644
--- a/libxslt/numbers.c
+++ b/libxslt/numbers.c
@@ -222,7 +222,7 @@ xsltNumberFormatDecimal(xmlBufferPtr buffer,
 }
 if (i < 0)
 xsltGenericError(xsltGenericErrorContext,
-   "xsltNumberFormatDecimal: Internal buffer size exceeded");
+   "xsltNumberFormatDecimal: Internal buffer size exceeded\n");
 xmlBufferCat(buffer, pointer);
 }
 
-- 
2.4.11

___
xslt mailing list, project page http://xmlsoft.org/XSLT/
xslt@gnome.org
https://mail.gnome.org/mailman/listinfo/xslt