Re: [Yade-dev] [Branch ~yade-dev/yade/trunk] Rev 2570: 1. Fix requestErase of erased interaction (thanks to Anton for reporting)

2010-11-26 Thread Anton Gladky 
Hi, Vaclav!

It seems, I have got a crash again, when started to delete particles.
But I cant give a backtrace, because of
https://bugs.launchpad.net/yade/+bug/669095

Can we do a backporting of that bug fix to the current trunk?

Anton



On Thu, Nov 25, 2010 at 9:57 AM,  wrote:

> 
> revno: 2570
> fixes bug(s): https://launchpad.net/bugs/681018
> committer: Václav Šmilauer 
> branch nick: yade
> timestamp: Thu 2010-11-25 09:56:11 +0100
> message:
>  1. Fix requestErase of erased interaction (thanks to Anton for reporting)
> modified:
>  core/InteractionContainer.cpp
>
>
> --
> lp:yade
> https://code.launchpad.net/~yade-dev/yade/trunk
>
> Your team Yade developers is subscribed to branch lp:yade.
> To unsubscribe from this branch go to
> https://code.launchpad.net/~yade-dev/yade/trunk/+edit-subscription
>
> === modified file 'core/InteractionContainer.cpp'
> --- core/InteractionContainer.cpp   2010-11-24 19:54:29 +
> +++ core/InteractionContainer.cpp   2010-11-25 08:56:11 +
> @@ -84,7 +84,8 @@
>
>
>  void InteractionContainer::requestErase(Body::id_t id1, Body::id_t id2,
> bool force){
> -   find(id1,id2)->reset(); IdsForce v={id1,id2,force};
> +   const shared_ptr& I=find(id1,id2); if(!I) return;
> +   I->reset(); IdsForce v={id1,id2,force};
>#ifdef YADE_OPENMP
>threadsPendingErase[omp_get_thread_num()].push_back(v);
>#else
>
>
> ___
> Mailing list: 
> https://launchpad.net/~yade-dev
> Post to : yade-dev@lists.launchpad.net
> Unsubscribe : 
> https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Yade-dev] [Branch ~yade-dev/yade/trunk] Rev 2570: 1. Fix requestErase of erased interaction (thanks to Anton for reporting)

2010-11-25 Thread Anton Gladky 
Ok, I will try. But I did not test packages yet. Can anyone try to start
your simulations from packaged version? We do really need it!

It is very simple, just:

sudo sudo add-apt-repository ppa:yade-pkg/stable; sudo apt-get install
yade-0.60

Anton



2010/11/25 Václav Šmilauer 

>  Should last commits be imported to 0.60?
>>
> No, 0.60 is not affected, that was bugs I introduced recently.
>
> BTW go for the final 0.60 packages, if you have a while. It would be nice
> to try with gcc (to have openmp), but if it is too much hassle, just do it
> just with clang.
>
> Cheers, Vaclav
>
>
>
> ___
> Mailing list: 
> https://launchpad.net/~yade-dev
> Post to : yade-dev@lists.launchpad.net
> Unsubscribe : 
> https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Yade-dev] [Branch ~yade-dev/yade/trunk] Rev 2570: 1. Fix requestErase of erased interaction (thanks to Anton for reporting)

2010-11-25 Thread Václav Šmilauer 

Should last commits be imported to 0.60?

No, 0.60 is not affected, that was bugs I introduced recently.

BTW go for the final 0.60 packages, if you have a while. It would be 
nice to try with gcc (to have openmp), but if it is too much hassle, 
just do it just with clang.


Cheers, Vaclav


___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Yade-dev] [Branch ~yade-dev/yade/trunk] Rev 2570: 1. Fix requestErase of erased interaction (thanks to Anton for reporting)

2010-11-25 Thread Anton Gladky 
Thanks, Vaclav!

Should last commits be imported to 0.60?

Anton



On Thu, Nov 25, 2010 at 9:57 AM,  wrote:

> 
> revno: 2570
> fixes bug(s): https://launchpad.net/bugs/681018
> committer: Václav Šmilauer 
> branch nick: yade
> timestamp: Thu 2010-11-25 09:56:11 +0100
> message:
>  1. Fix requestErase of erased interaction (thanks to Anton for reporting)
> modified:
>  core/InteractionContainer.cpp
>
>
> --
> lp:yade
> https://code.launchpad.net/~yade-dev/yade/trunk
>
> Your team Yade developers is subscribed to branch lp:yade.
> To unsubscribe from this branch go to
> https://code.launchpad.net/~yade-dev/yade/trunk/+edit-subscription
>
> === modified file 'core/InteractionContainer.cpp'
> --- core/InteractionContainer.cpp   2010-11-24 19:54:29 +
> +++ core/InteractionContainer.cpp   2010-11-25 08:56:11 +
> @@ -84,7 +84,8 @@
>
>
>  void InteractionContainer::requestErase(Body::id_t id1, Body::id_t id2,
> bool force){
> -   find(id1,id2)->reset(); IdsForce v={id1,id2,force};
> +   const shared_ptr& I=find(id1,id2); if(!I) return;
> +   I->reset(); IdsForce v={id1,id2,force};
>#ifdef YADE_OPENMP
>threadsPendingErase[omp_get_thread_num()].push_back(v);
>#else
>
>
> ___
> Mailing list: 
> https://launchpad.net/~yade-dev
> Post to : yade-dev@lists.launchpad.net
> Unsubscribe : 
> https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp