[Yahoo-eng-team] [Bug 1547380] [NEW] Correlate address scope with network
Public bug reported: With address scope being enabled, networks now are in one ipv4 address scope and one ipv6 address scope. But now, it is difficult to find out the address scopes that the network is in. User have to check in this way: network->subnet->subnet pool -> address scope. This bug is to add a read-only, derived attribute to the network as part of the address scopes extension that will show related address scopes when viewing a network through the API. ** Affects: neutron Importance: Undecided Assignee: Hong Hui Xiao (xiaohhui) Status: New ** Tags: address-scopes l3-ipam-dhcp ** Changed in: neutron Assignee: (unassigned) => Hong Hui Xiao (xiaohhui) ** Tags added: l3-ipam ** Tags removed: l3-ipam ** Tags added: l3-ipam-dhcp ** Tags added: address-scopes -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1547380 Title: Correlate address scope with network Status in neutron: New Bug description: With address scope being enabled, networks now are in one ipv4 address scope and one ipv6 address scope. But now, it is difficult to find out the address scopes that the network is in. User have to check in this way: network->subnet->subnet pool -> address scope. This bug is to add a read-only, derived attribute to the network as part of the address scopes extension that will show related address scopes when viewing a network through the API. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1547380/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1547406] [NEW] eslint should be upgraded
Public bug reported: The eslint package is frozen to version 1.2.1, which was released the 20th of August of 2015. The newer versions (last 1.x version is 1.10.3) fixes a lot of issues and a lot of checks which are not working correctly or which are totally missing: http://eslint.org/docs/rules/operator-linebreak.html Which is activated on eslint-config-openstack but was never checked: https://github.com/openstack/horizon/blob/master/horizon%2Fstatic%2Fhorizon%2Fjs%2Fhorizon.quota.js#L103 Also it provides a new config flag "--max-warnings" which would be incredibly useful so we can put a limit to the number of warning that we get and enforce a new check. ** Affects: horizon Importance: Undecided Assignee: Itxaka Serrano (itxakaserrano) Status: New ** Changed in: horizon Assignee: (unassigned) => Itxaka Serrano (itxakaserrano) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1547406 Title: eslint should be upgraded Status in OpenStack Dashboard (Horizon): New Bug description: The eslint package is frozen to version 1.2.1, which was released the 20th of August of 2015. The newer versions (last 1.x version is 1.10.3) fixes a lot of issues and a lot of checks which are not working correctly or which are totally missing: http://eslint.org/docs/rules/operator-linebreak.html Which is activated on eslint-config-openstack but was never checked: https://github.com/openstack/horizon/blob/master/horizon%2Fstatic%2Fhorizon%2Fjs%2Fhorizon.quota.js#L103 Also it provides a new config flag "--max-warnings" which would be incredibly useful so we can put a limit to the number of warning that we get and enforce a new check. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1547406/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1547412] [NEW] Router interfaces exists on all the controllers after making L3 agent down on active controller i.e duplicate ip's present with duplication of ping
Public bug reported: Steps to reproduce: 1)Create a router 2)Add router interface to subnet 3)boot a vm 4)create a floating ip and associate it to vm port id 5)Make l3 agent down on active controller stack@padawan-ccp-c1-m2-mgmt:~$ neutron l3-agent-list-hosting-router 23ec6a25-b578-4630-86ba-3a544293385b --- id hostadmin_state_up alive ha_state --- 5d47d95e-3750-4007-86b3-a724092cfd85padawan-ccp-c1-m3-mgmt True active 24dd994c-5e67-41b7-acd6-8766b50f838dpadawan-ccp-c1-m2-mgmt Truexxx standby --- stack@padawan-ccp-c1-m2-mgmt:~$ sudo ip netns exec qrouter-23ec6a25-b578-4630-86ba-3a544293385b ifconfig ha-b6dcf491-e6 Link encap:Ethernet HWaddr fa:16:3e:ce:ff:13 inet addr:169.254.192.5 Bcast:169.254.255.255 Mask:255.255.192.0 inet6 addr: fe80::f816:3eff:fece:ff13/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:3650 errors:0 dropped:391 overruns:0 frame:0 TX packets:404 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:229496 (224.1 KiB) TX bytes:22476 (21.9 KiB) lo Link encap:Local Loopback inet addr:127.0.0.1 Mask:255.0.0.0 inet6 addr: ::1/128 Scope:Host UP LOOPBACK RUNNING MTU:65536 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) qg-3d627c6b-86 Link encap:Ethernet HWaddr fa:16:3e:70:95:f3 inet addr:10.36.0.24 Bcast:0.0.0.0 Mask:255.255.0.0 inet6 addr: fe80::f816:3eff:fe70:95f3/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:8961 errors:0 dropped:8 overruns:0 frame:0 TX packets:249 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:600352 (586.2 KiB) TX bytes:20626 (20.1 KiB) qr-ba518ea4-f7 Link encap:Ethernet HWaddr fa:16:3e:9f:89:aa inet addr:7.7.7.1 Bcast:0.0.0.0 Mask:255.255.255.0 inet6 addr: fe80::f816:3eff:fe9f:89aa/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:923 errors:0 dropped:1 overruns:0 frame:0 TX packets:395 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:79946 (78.0 KiB) TX bytes:38625 (37.7 KiB) stack@padawan-ccp-c1-m3-mgmt:~$ sudo ip netns exec qrouter-23ec6a25-b578-4630-86ba-3a544293385b ifconfig ha-47cfce0e-c5 Link encap:Ethernet HWaddr fa:16:3e:db:39:24 inet addr:169.254.192.6 Bcast:169.254.255.255 Mask:255.255.192.0 inet6 addr: fe80::f816:3eff:fedb:3924/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:3223 errors:0 dropped:581 overruns:0 frame:0 TX packets:833 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:196426 (191.8 KiB) TX bytes:46062 (44.9 KiB) lo Link encap:Local Loopback inet addr:127.0.0.1 Mask:255.0.0.0 inet6 addr: ::1/128 Scope:Host UP LOOPBACK RUNNING MTU:65536 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) qg-3d627c6b-86 Link encap:Ethernet HWaddr fa:16:3e:70:95:f3 inet addr:10.36.0.24 Bcast:0.0.0.0 Mask:255.255.0.0 inet6 addr: fe80::f816:3eff:fe70:95f3/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:2522 errors:0 dropped:0 overruns:0 frame:0 TX packets:1059 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:213140 (208.1 KiB) TX bytes:98562 (96.2 KiB) qr-ba518ea4-f7 Link encap:Ethernet HWaddr fa:16:3e:9f:89:aa inet addr:7.7.7.1 Bcast:0.0.0.0 Mask:255.255.255.0 inet6 addr: fe80::f816:3eff:fe9f:89aa/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:1462 errors:0 dropped:0 overruns:0 frame:0 TX packets:1035 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:132248 (129.1 KiB) TX bytes:97302 (95.0 KiB) == checking if there is any loss in network traffic when L3 agent comes back. And verifying the master ownership of the HA router. There is a duplicate ip in the network Three things to discuss here, 1) Before making l3 agent down these are the status of controllers m2 = active m1 = stand_by m3 = stand_by I made m2 l3 agent down and started again, There is a 4 packet loss and the status of the controllers ofter making m2 l3 agent down is m2 = stand_by m1 = active m3 = active 2 ) Before making l3 agent down, m1 = active m3 = active m2 standby I made l3 agent down of m1 and m3 controllers and started again, there is duplicate of ip address on controllers and there is no packet loss After making l3 agent down here is the status of the controllers m2 = active m1 = active m3 = active 3) Before making m2's L3 agent down m2 = active m1 = active m3 = active stack@padawa
[Yahoo-eng-team] [Bug 1532086] Re: Use print('value') instead of print 'value' in python3
** Changed in: congress Status: New => Invalid -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1532086 Title: Use print('value') instead of print 'value' in python3 Status in Bandit: Invalid Status in congress: Invalid Status in Murano: Invalid Status in OpenStack Compute (nova): Won't Fix Status in Trove: Invalid Bug description: Do not use print 'some string' in python3, python3 will complain. Use print('some string') instead, because that will work on both python2 n python3. It will help in adding support for python3. Example:- File : nova/tools/xenserver/stress_test.py Line : 166 print "%s, finished in %.2f secs" % (result, duration) To manage notifications about this bug go to: https://bugs.launchpad.net/bandit/+bug/1532086/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1547415] [NEW] eslint warnings should have a treshold
Public bug reported: We should make eslint warnings to have a threshold to avoid adding more and more warnings to our javascript code. Right now we are at 465 warning and it does not seem to decrease over time. A limit should be put in place to avoid increasing the number of warnings over time. ** Affects: horizon Importance: Undecided Assignee: Itxaka Serrano (itxakaserrano) Status: New ** Changed in: horizon Assignee: (unassigned) => Itxaka Serrano (itxakaserrano) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1547415 Title: eslint warnings should have a treshold Status in OpenStack Dashboard (Horizon): New Bug description: We should make eslint warnings to have a threshold to avoid adding more and more warnings to our javascript code. Right now we are at 465 warning and it does not seem to decrease over time. A limit should be put in place to avoid increasing the number of warnings over time. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1547415/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1544522] Re: Don't use Mock.called_once_with that does not exist
Reviewed: https://review.openstack.org/280279 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fd0ed209d214c2a4f825eda9dd0b97234f75875a Submitter: Jenkins Branch:master commit fd0ed209d214c2a4f825eda9dd0b97234f75875a Author: Bo Wang Date: Mon Feb 15 23:05:20 2016 +0800 Stop using non-existent method of Mock There is no method called_once_with() in Mock object. Use assert_called_once_with() instead. Change-Id: I263c407ba2a82f53aace5f71cb27ad8974335e24 Closes-Bug: #1544522 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1544522 Title: Don't use Mock.called_once_with that does not exist Status in Cinder: Fix Released Status in neutron: Fix Released Status in octavia: In Progress Status in python-designateclient: In Progress Status in python-openstackclient: In Progress Status in Rally: Fix Released Status in Sahara: Fix Released Status in Trove: In Progress Bug description: class mock.Mock does not exist method "called_once_with", it just exists method "assert_called_once_with". Currently there are still some places where we use called_once_with method, we should correct it. NOTE: called_once_with() does nothing because it's a mock object. To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1544522/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1547486] [NEW] ARPSpoofOFCtlTestCase functional gate tests failing intermittently
Public bug reported: Tests inside neutron.tests.functional.agent.test_ovs_flows.ARPSpoofOFCtlTestCase seems to fail intermittently. The root cause seems like to be the same for all the tests... Here are two different stack traces from two different patches... - 2016-02-19 09:49:54.288 | 2016-02-19 09:49:54.264 | == 2016-02-19 09:49:54.312 | 2016-02-19 09:49:54.279 | Failed 1 tests - output below: 2016-02-19 09:49:54.321 | 2016-02-19 09:49:54.292 | == 2016-02-19 09:49:54.332 | 2016-02-19 09:49:54.308 | 2016-02-19 09:49:54.335 | 2016-02-19 09:49:54.310 | neutron.tests.functional.agent.test_ovs_flows.ARPSpoofOFCtlTestCase.test_arp_spoof_disable_network_port(native) 2016-02-19 09:49:54.339 | 2016-02-19 09:49:54.312 | --- 2016-02-19 09:49:54.339 | 2016-02-19 09:49:54.314 | 2016-02-19 09:49:54.343 | 2016-02-19 09:49:54.316 | Captured traceback: 2016-02-19 09:49:54.375 | 2016-02-19 09:49:54.317 | ~~~ 2016-02-19 09:49:54.375 | 2016-02-19 09:49:54.322 | Traceback (most recent call last): 2016-02-19 09:49:54.375 | 2016-02-19 09:49:54.328 | File "neutron/tests/functional/agent/test_ovs_flows.py", line 242, in test_arp_spoof_disable_network_port 2016-02-19 09:49:54.375 | 2016-02-19 09:49:54.351 | net_helpers.assert_ping(self.src_namespace, self.dst_addr, count=2) 2016-02-19 09:49:54.378 | 2016-02-19 09:49:54.354 | File "neutron/tests/common/net_helpers.py", line 93, in assert_ping 2016-02-19 09:49:54.380 | 2016-02-19 09:49:54.357 | dst_ip]) 2016-02-19 09:49:54.385 | 2016-02-19 09:49:54.361 | File "neutron/agent/linux/ip_lib.py", line 885, in execute 2016-02-19 09:49:54.386 | 2016-02-19 09:49:54.363 | log_fail_as_error=log_fail_as_error, **kwargs) 2016-02-19 09:49:54.389 | 2016-02-19 09:49:54.365 | File "neutron/agent/linux/utils.py", line 140, in execute 2016-02-19 09:49:54.392 | 2016-02-19 09:49:54.368 | raise RuntimeError(msg) 2016-02-19 09:49:54.395 | 2016-02-19 09:49:54.371 | RuntimeError: Exit code: 1; Stdin: ; Stdout: PING 192.168.0.2 (192.168.0.2) 56(84) bytes of data. 2016-02-19 09:49:54.397 | 2016-02-19 09:49:54.374 | 2016-02-19 09:49:54.420 | 2016-02-19 09:49:54.376 | --- 192.168.0.2 ping statistics --- 2016-02-19 09:49:54.421 | 2016-02-19 09:49:54.378 | 2 packets transmitted, 0 received, 100% packet loss, time 1005ms 2016-02-19 09:49:54.421 | 2016-02-19 09:49:54.379 | 2016-02-19 09:49:54.421 | 2016-02-19 09:49:54.382 | ; Stderr: - - 2016-02-19 09:12:55.965 | 2016-02-19 09:12:55.947 | == 2016-02-19 09:12:55.972 | 2016-02-19 09:12:55.951 | Failed 1 tests - output below: 2016-02-19 09:12:55.977 | 2016-02-19 09:12:55.959 | == 2016-02-19 09:12:55.986 | 2016-02-19 09:12:55.967 | 2016-02-19 09:12:56.007 | 2016-02-19 09:12:55.976 | neutron.tests.functional.agent.test_ovs_flows.ARPSpoofOFCtlTestCase.test_arp_spoof_doesnt_block_normal_traffic(native) 2016-02-19 09:12:56.007 | 2016-02-19 09:12:55.978 | -- 2016-02-19 09:12:56.009 | 2016-02-19 09:12:55.990 | 2016-02-19 09:12:56.025 | 2016-02-19 09:12:56.006 | Captured pythonlogging: 2016-02-19 09:12:56.034 | 2016-02-19 09:12:56.016 | ~~~ 2016-02-19 09:12:56.036 | 2016-02-19 09:12:56.018 |DEBUG [oslo_policy._cache_handler] Reloading cached file /opt/stack/new/neutron/neutron/tests/etc/policy.json 2016-02-19 09:12:56.038 | 2016-02-19 09:12:56.020 |DEBUG [oslo_policy.policy] Reloaded policy file: /opt/stack/new/neutron/neutron/tests/etc/policy.json 2016-02-19 09:12:56.046 | 2016-02-19 09:12:56.028 | 2016-02-19 09:12:56.051 | 2016-02-19 09:12:56.030 | 2016-02-19 09:12:56.060 | 2016-02-19 09:12:56.036 | Captured traceback: 2016-02-19 09:12:56.062 | 2016-02-19 09:12:56.044 | ~~~ 2016-02-19 09:12:56.066 | 2016-02-19 09:12:56.048 | Traceback (most recent call last): 2016-02-19 09:12:56.071 | 2016-02-19 09:12:56.053 | File "neutron/tests/functional/agent/test_ovs_flows.py", line 145, in test_arp_spoof_doesnt_block_normal_traffic 2016-02-19 09:12:56.073 | 2016-02-19 09:12:56.055 |
[Yahoo-eng-team] [Bug 1533904] Re: Disassociate floatingip in HA router might get error
Reviewed: https://review.openstack.org/269988 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=77f84fa9353dbf1d4c248c97ba59e857facefdb2 Submitter: Jenkins Branch:master commit 77f84fa9353dbf1d4c248c97ba59e857facefdb2 Author: Hong Hui Xiao Date: Tue Jan 19 22:17:20 2016 -0500 Remove floatingip address only when the address has been configured For HA router, adding a floatingip will add a vip to keepalived, then keepalived will add the ip address to port. So there is a time window that the qg device in qrouter namespace will not have the address of floatingip. If user delete the floatingip at the time window, ip command will fail, because it tries to remove an ip address that doesn't exist on the qg device. The fix here is to check if the ip address is on the qg device, before removing the ip address. A functional test is added to address the issue. Change-Id: I72996d9a77f5f17b4d7a19d5be20b3f97f90dcba Closes-bug: #1533904 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1533904 Title: Disassociate floatingip in HA router might get error Status in neutron: Fix Released Bug description: With master code, I try to disassociate floatingip in HA router. But see following error in log. 2016-01-14 00:19:52.708 ERROR neutron.agent.linux.utils [-] Exit code: 2; Stdin: ; Stdout: ; Stderr: RTNETLINK answers: Cannot assign requested address 2016-01-14 00:19:52.710 ERROR neutron.agent.l3.router_info [-] Failed to process floating IPs. 2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info Traceback (most recent call last): 2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info File "/opt/stack/neutron/neutron/agent/l3/router_info.py", line 672, in process_external 2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info fip_statuses = self.configure_fip_addresses(interface_name) 2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info File "/opt/stack/neutron/neutron/agent/l3/router_info.py", line 251, in configure_fip_addresses 2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info raise n_exc.FloatingIpSetupException('L3 agent failure to setup ' 2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info FloatingIpSetupException: L3 agent failure to setup floating IPs 2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1533904/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp