[Yahoo-eng-team] [Bug 1845986] [NEW] SEV does not enable IOMMU on SCSI controller

2019-09-30 Thread Adam Spiers
Public bug reported:

https://review.opendev.org/#/c/644565/ added logic to
libvirt/designer.py for enabling iommu for certain devices where virtio
is used.  This is required for AMD SEV[0].  However it missed the case
of a SCSI controller where the model is virtio-scsi, e.g.:



As with other virtio devices, here a child element needs to be added to
the config when SEV is enabled:



[0] http://specs.openstack.org/openstack/nova-specs/specs/train/approved
/amd-sev-libvirt-support.html#proposed-change

** Affects: nova
 Importance: Undecided
 Assignee: Adam Spiers (adam.spiers)
 Status: In Progress


** Tags: sev

** Changed in: nova
 Assignee: (unassigned) => Adam Spiers (adam.spiers)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1845986

Title:
  SEV does not enable IOMMU on SCSI controller

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  https://review.opendev.org/#/c/644565/ added logic to
  libvirt/designer.py for enabling iommu for certain devices where
  virtio is used.  This is required for AMD SEV[0].  However it missed
  the case of a SCSI controller where the model is virtio-scsi, e.g.:

  

  As with other virtio devices, here a child element needs to be added
  to the config when SEV is enabled:

  

  [0] http://specs.openstack.org/openstack/nova-
  specs/specs/train/approved/amd-sev-libvirt-support.html#proposed-
  change

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1845986/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1838689] [NEW] rpc_workers default value ignores setting of api_workers

2019-08-01 Thread Adam Spiers
Public bug reported:

The help for the rpc_workers config option is:

Number of RPC worker processes for service.  If not specified, the
default is equal to half the number of API workers.

However, this does not accurately describe the current behaviour, which
is to default to half the _default_ number of API workers.  This can
make a big difference; for example on a 256-CPU machine with 256GB of
RAM which has api_workers configured to 8 but rpc_workers not configured
to anything, this will result in 64 RPC workers, which is 8 for every
API worker!

** Affects: neutron
 Importance: Undecided
 Assignee: Adam Spiers (adam.spiers)
 Status: New

** Changed in: neutron
 Assignee: (unassigned) => Adam Spiers (adam.spiers)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1838689

Title:
  rpc_workers default value ignores setting of api_workers

Status in neutron:
  New

Bug description:
  The help for the rpc_workers config option is:

  Number of RPC worker processes for service.  If not specified, the
  default is equal to half the number of API workers.

  However, this does not accurately describe the current behaviour,
  which is to default to half the _default_ number of API workers.  This
  can make a big difference; for example on a 256-CPU machine with 256GB
  of RAM which has api_workers configured to 8 but rpc_workers not
  configured to anything, this will result in 64 RPC workers, which is 8
  for every API worker!

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1838689/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1796857] [NEW] ImagePropertiesFilter docs refer to legacy properties

2018-10-09 Thread Adam Spiers
Public bug reported:

https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#imagepropertiesfilter
refers to the 'architecture', 'hypervisor_type',
'hypervisor_version_requires', and 'vm_mode' properties; however the
source code at
https://github.com/openstack/nova/blob/05c379173569d2ea91741f3468d531d4edf7ef9d/nova/objects/image_meta.py#L474
shows that these are legacy properties which now have preferred
alternatives:

# The keys are the legacy property names and
# the values are the current preferred names
_legacy_property_map = {
'architecture': 'hw_architecture',
[... snipped ...]
'vm_mode': 'hw_vm_mode',
[... snipped ...]
'hypervisor_version_requires': 'img_hv_requested_version',
'hypervisor_type': 'img_hv_type',
}

Therefore presumably the docs should be updated to refer to the new
properties.  If someone can confirm this is correct, I'm happy to push
the doc fix for review.

** Affects: nova
 Importance: Undecided
 Status: New


** Tags: doc

** Summary changed:

- ImagePropertiesFilter refers to legacy properties
+ ImagePropertiesFilter docs refer to legacy properties

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1796857

Title:
  ImagePropertiesFilter docs refer to legacy properties

Status in OpenStack Compute (nova):
  New

Bug description:
  
https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#imagepropertiesfilter
  refers to the 'architecture', 'hypervisor_type',
  'hypervisor_version_requires', and 'vm_mode' properties; however the
  source code at
  
https://github.com/openstack/nova/blob/05c379173569d2ea91741f3468d531d4edf7ef9d/nova/objects/image_meta.py#L474
  shows that these are legacy properties which now have preferred
  alternatives:

  # The keys are the legacy property names and
  # the values are the current preferred names
  _legacy_property_map = {
  'architecture': 'hw_architecture',
  [... snipped ...]
  'vm_mode': 'hw_vm_mode',
  [... snipped ...]
  'hypervisor_version_requires': 'img_hv_requested_version',
  'hypervisor_type': 'img_hv_type',
  }

  Therefore presumably the docs should be updated to refer to the new
  properties.  If someone can confirm this is correct, I'm happy to push
  the doc fix for review.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1796857/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp