[Yahoo-eng-team] [Bug 1517839] Re: Make CONF.set_override with paramter enforce_type=True by default

2016-01-11 Thread Chaozhe Chen 
** Also affects: ceilometer
   Importance: Undecided
   Status: New

** Also affects: cloudkitty
   Importance: Undecided
   Status: New

** Changed in: cloudkitty
 Assignee: (unassigned) => Chaozhe Chen (chaozhe-chen)

** Changed in: ceilometer
 Assignee: (unassigned) => Chaozhe Chen (chaozhe-chen)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1517839

Title:
  Make CONF.set_override with paramter enforce_type=True by default

Status in Ceilometer:
  New
Status in cloudkitty:
  New
Status in Gnocchi:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in oslo.config:
  New
Status in oslo.messaging:
  Fix Released
Status in Rally:
  Fix Released

Bug description:
  1. Problems :
 oslo_config provides method CONF.set_override[1] , developers usually use 
it to change config option's value in tests. That's convenient .
 By default  parameter enforce_type=False,  it doesn't check any type or 
value of override. If set enforce_type=True , will check parameter
 override's type and value.  In production code(running time code),  
oslo_config  always checks  config option's value.
 In short, we test and run code in different ways. so there's  gap:  config 
option with wrong type or invalid value can pass tests when
 parameter enforce_type = False in consuming projects.  that means some 
invalid or wrong tests are in our code base.
 There is nova POC result when I enable "enforce_type=true" [2],  and I 
must fix them in [3]

 [1] 
https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2173
 [2] 
http://logs.openstack.org/16/242416/1/check/gate-nova-python27/97b5eff/testr_results.html.gz
 [3]  https://review.openstack.org/#/c/242416/  
https://review.openstack.org/#/c/242717/  
https://review.openstack.org/#/c/243061/

  2. Proposal 
 1) Make  method CONF.set_override with  enforce_type=True  in consuming 
projects. and  fix violations when  enforce_type=True in each project.

2) Make  method CONF.set_override with  enforce_type=True by default
  in oslo_config

 Hope some one from consuming projects can help make
  enforce_type=True in consuming projects and fix violations,

 You can find more details and comments  in
  https://etherpad.openstack.org/p/enforce_type_true_by_default

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1517839/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1540254] Re: "#flake8: noqa" is using incorrectly

2016-02-09 Thread Chaozhe Chen 
** Also affects: designate
   Importance: Undecided
   Status: New

** Changed in: designate
 Assignee: (unassigned) => Chaozhe Chen (chaozhe-chen)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1540254

Title:
  "#flake8: noqa" is using incorrectly

Status in Designate:
  In Progress
Status in OpenStack Dashboard (Horizon):
  In Progress
Status in python-heatclient:
  Fix Released
Status in python-novaclient:
  Fix Released

Bug description:
  "# flake8: noqa" option disables all checks for the whole file. To
  disable one line we should use "# noqa".

  Refer to: https://pypi.python.org/pypi/flake8
  
https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb

To manage notifications about this bug go to:
https://bugs.launchpad.net/designate/+bug/1540254/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1544522] Re: Don't use Mock.called_once_with that does not exist

2016-02-17 Thread Chaozhe Chen 
** Also affects: trove
   Importance: Undecided
   Status: New

** Changed in: trove
 Assignee: (unassigned) => Chaozhe Chen (chaozhe-chen)

** Also affects: designate
   Importance: Undecided
   Status: New

** No longer affects: designate

** Also affects: python-designateclient
   Importance: Undecided
   Status: New

** Changed in: python-designateclient
 Assignee: (unassigned) => Chaozhe Chen (chaozhe-chen)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1544522

Title:
  Don't use Mock.called_once_with that does not exist

Status in Cinder:
  Fix Released
Status in neutron:
  In Progress
Status in octavia:
  In Progress
Status in python-designateclient:
  In Progress
Status in Sahara:
  Fix Released
Status in Trove:
  In Progress

Bug description:
  class mock.Mock does not exist method "called_once_with", it just
  exists method "assert_called_once_with". Currently there are still
  some places where we use called_once_with method, we should correct
  it.

  NOTE: called_once_with() does nothing because it's a mock object.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1544522/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1544522] Re: Don't use Mock.called_once_with that does not exist

2016-02-17 Thread Chaozhe Chen 
** Also affects: rally
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1544522

Title:
  Don't use Mock.called_once_with that does not exist

Status in Cinder:
  Fix Released
Status in neutron:
  In Progress
Status in octavia:
  In Progress
Status in python-designateclient:
  In Progress
Status in Rally:
  New
Status in Sahara:
  Fix Released
Status in Trove:
  In Progress

Bug description:
  class mock.Mock does not exist method "called_once_with", it just
  exists method "assert_called_once_with". Currently there are still
  some places where we use called_once_with method, we should correct
  it.

  NOTE: called_once_with() does nothing because it's a mock object.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1544522/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1440773] Re: Remove WritableLogger as eventlet has a real logger interface in 0.17.2

2016-02-22 Thread Chaozhe Chen 
** Also affects: trove
   Importance: Undecided
   Status: New

** Changed in: trove
 Assignee: (unassigned) => Chaozhe Chen (chaozhe-chen)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1440773

Title:
  Remove WritableLogger as eventlet has a real logger interface in
  0.17.2

Status in Cinder:
  Fix Released
Status in Glance:
  Fix Released
Status in Manila:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in oslo.log:
  Fix Released
Status in Trove:
  In Progress

Bug description:
  Info from Sean on IRC:

  the patch to use a real logger interface in eventlet has been released
  in 0.17.2, which means we should be able to phase out
  https://github.com/openstack/oslo.log/blob/master/oslo_log/loggers.py

  Eventlet PR was:
  https://github.com/eventlet/eventlet/pull/75

  thanks,
  dims

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1440773/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1440773] Re: Remove WritableLogger as eventlet has a real logger interface in 0.17.2

2016-02-22 Thread Chaozhe Chen 
** Also affects: heat
   Importance: Undecided
   Status: New

** Changed in: heat
 Assignee: (unassigned) => Chaozhe Chen (chaozhe-chen)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1440773

Title:
  Remove WritableLogger as eventlet has a real logger interface in
  0.17.2

Status in Cinder:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  In Progress
Status in Manila:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in oslo.log:
  Fix Released
Status in Trove:
  In Progress

Bug description:
  Info from Sean on IRC:

  the patch to use a real logger interface in eventlet has been released
  in 0.17.2, which means we should be able to phase out
  https://github.com/openstack/oslo.log/blob/master/oslo_log/loggers.py

  Eventlet PR was:
  https://github.com/eventlet/eventlet/pull/75

  thanks,
  dims

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1440773/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1527583] [NEW] 'get_client_class' is deprecated

2015-12-18 Thread Chaozhe Chen 
Public bug reported:

I found error raise in novaclient tox test:

Captured stderr:

novaclient/client.py:788: UserWarning: 'get_client_class' is deprecated. 
Please use `novaclient.client.Client` instead.
  warnings.warn(_LW("'get_client_class' is deprecated. "

It's a warning about function 'get_client_class' is deprecated.

** Affects: nova
 Importance: Undecided
 Assignee: Chaozhe Chen (chaozhe-chen)
 Status: New

** Changed in: nova
 Assignee: (unassigned) => Chaozhe Chen (chaozhe-chen)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1527583

Title:
  'get_client_class' is deprecated

Status in OpenStack Compute (nova):
  New

Bug description:
  I found error raise in novaclient tox test:

  Captured stderr:
  
  novaclient/client.py:788: UserWarning: 'get_client_class' is deprecated. 
Please use `novaclient.client.Client` instead.
warnings.warn(_LW("'get_client_class' is deprecated. "

  It's a warning about function 'get_client_class' is deprecated.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1527583/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1527583] Re: 'get_client_class' is deprecated

2015-12-18 Thread Chaozhe Chen 
** Changed in: nova
   Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1527583

Title:
  'get_client_class' is deprecated

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  I found error raise in novaclient tox test:

  Captured stderr:
  
  novaclient/client.py:788: UserWarning: 'get_client_class' is deprecated. 
Please use `novaclient.client.Client` instead.
warnings.warn(_LW("'get_client_class' is deprecated. "

  It's a warning about function 'get_client_class' is deprecated.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1527583/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp