[Yahoo-eng-team] [Bug 1321378] Re: keystone user-role-* operations fails when user no longer exists in backend

2016-09-28 Thread QiangTang 
** Changed in: python-openstackclient
   Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1321378

Title:
  keystone user-role-* operations fails when user no longer exists in
  backend

Status in OpenStack Identity (keystone):
  Fix Released
Status in python-keystoneclient:
  Invalid
Status in python-openstackclient:
  Invalid

Bug description:
  When using an external user catalog (in our case, AD), if the user is
  removed on the backend catalog, the user-role-* keystone CLI commands
  no longer work, because keystone cannot look up the user.

  The specific situation is a user had been granted roles on some
  projects, but then that user left the company and was removed from the
  backend directory.  When going back to remove the roles assigned to
  that user, the keystone commands fail.

  It may still be possible to do these operations directly through the
  API, I didn't check that.  But ultimately was able to work around it
  by directly removing the entries in the keystone user_project_metadata
  table.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1321378/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1475722] Re: Never use MagicMock

2016-09-21 Thread QiangTang 
** Also affects: neutron
   Importance: Undecided
   Status: New

** Changed in: neutron
 Assignee: (unassigned) => QiangTang (qtang)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1475722

Title:
  Never use MagicMock

Status in Aodh:
  New
Status in Barbican:
  In Progress
Status in Ceilometer:
  New
Status in Cinder:
  New
Status in Designate:
  New
Status in Glance:
  New
Status in OpenStack Dashboard (Horizon):
  In Progress
Status in OpenStack Identity (keystone):
  In Progress
Status in keystonemiddleware:
  In Progress
Status in Mistral:
  In Progress
Status in Murano:
  In Progress
Status in neutron:
  New
Status in OpenStack Compute (nova):
  New
Status in Panko:
  New
Status in python-barbicanclient:
  In Progress
Status in python-ceilometerclient:
  New
Status in python-heatclient:
  In Progress
Status in python-mistralclient:
  In Progress
Status in python-muranoclient:
  In Progress
Status in python-neutronclient:
  In Progress
Status in python-novaclient:
  New
Status in python-openstackclient:
  Fix Released
Status in OpenStack SDK:
  Fix Committed
Status in python-swiftclient:
  In Progress
Status in python-troveclient:
  In Progress
Status in Rally:
  New
Status in OpenStack Object Storage (swift):
  New
Status in tempest:
  New
Status in OpenStack DBaaS (Trove):
  New

Bug description:
  They magically allow things to pass. This is bad.

  Any usage should be replaced with the Mock class and explicit
  attributes should be set on it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/aodh/+bug/1475722/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1558690] Re: project set works for invalid properties

2016-08-17 Thread QiangTang 
** Changed in: python-openstackclient
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1558690

Title:
  project set works for invalid properties

Status in OpenStack Identity (keystone):
  Won't Fix
Status in python-openstackclient:
  Fix Released

Bug description:
  openstack project set accepts invalid properties, and even somehow
  sets their values

  # openstack project set ABC --property xyz=pqr
  # openstack project show ABC
  +-+--+
  | Field   | Value|
  +-+--+
  | description |  |
  | domain_id   | ef8acb82bebd4c4abdc6b2056440b596 |
  | enabled | True |
  | id  | 315700c2a1384b1ca21543504e3513bb |
  | is_domain   | False|
  | name| ABC  |
  | xyz | pqr  |
  +-+--+

  As seen above, the new "xyz" field was created with the specified
  value. This is not a valid property and should not have been created.

  Also, specifying an invalid property without a value did not return an
  error:

  # openstack project set ABC --property QQQ
  # openstack project show ABC
  +-+--+
  | Field   | Value|
  +-+--+
  | description |  |
  | domain_id   | ef8acb82bebd4c4abdc6b2056440b596 |
  | enabled | True |
  | id  | 315700c2a1384b1ca21543504e3513bb |
  | is_domain   | False|
  | name| ABC  |
  | xyz | pqr  |
  +-+--+

  openstackclient version = 1.5.0
  keystone version = mitaka

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1558690/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1605444] Re: Should check null key when set key-value pair in property

2016-07-25 Thread QiangTang 
** Also affects: python-glanceclient
   Importance: Undecided
   Status: New

** Changed in: python-glanceclient
 Assignee: (unassigned) => QiangTang (qtang)

** Changed in: glance
   Status: New => Invalid

** No longer affects: glance

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1605444

Title:
  Should check null key when set key-value pair in property

Status in python-glanceclient:
  New

Bug description:
  root@controller01:~# glance image-update ubuntu-14.04-server-amd64 --property 
=
  +---+--+
  | Property  | Value|
  +---+--+
  | Property ''   | None |
  | Property 'vmware_adaptertype' | lsiLogic |
  | Property 'vmware_disktype'| streamOptimized  |
  | checksum  | 7b26c526f6f7c8ab874ad55b2698dee0 |
  | container_format  | bare |
  | created_at| 2016-07-21T07:37:42.00   |
  | deleted   | False|
  | deleted_at| None |
  | disk_format   | vmdk |
  | id| 2fb0b8a1-1634-499d-95ee-2451ec23893e |
  | is_public | True |
  | min_disk  | 5|
  | min_ram   | 512  |
  | name  | ubuntu-14.04-server-amd64|
  | owner | 5b53ee384ebc4212b4086241e1075dea |
  | protected | False|
  | size  | 971606528|
  | status| active   |
  | updated_at| 2016-07-22T02:25:46.00   |
  | virtual_size  | None |
  +---+--+

  The null key set success as the result.
  But null key is meaningless to the user which also belong to the invalid 
input in other components, like cinder and nova flavor as below:

  root@controller01:~# nova flavor-key m1.tiny set =
  ERROR (CommandError): Invalid key: "". Keys may only contain letters, 
numbers, spaces, underscores, periods, colons and hyphens.

  So for the consistent openstack UE and error handling, glance cli site
  better to add the null key check.

To manage notifications about this bug go to:
https://bugs.launchpad.net/python-glanceclient/+bug/1605444/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1605444] [NEW] Should check null key when set key-value pair in property

2016-07-21 Thread QiangTang 
Public bug reported:

root@controller01:~# glance image-update ubuntu-14.04-server-amd64 --property =
+---+--+
| Property  | Value|
+---+--+
| Property ''   | None |
| Property 'vmware_adaptertype' | lsiLogic |
| Property 'vmware_disktype'| streamOptimized  |
| checksum  | 7b26c526f6f7c8ab874ad55b2698dee0 |
| container_format  | bare |
| created_at| 2016-07-21T07:37:42.00   |
| deleted   | False|
| deleted_at| None |
| disk_format   | vmdk |
| id| 2fb0b8a1-1634-499d-95ee-2451ec23893e |
| is_public | True |
| min_disk  | 5|
| min_ram   | 512  |
| name  | ubuntu-14.04-server-amd64|
| owner | 5b53ee384ebc4212b4086241e1075dea |
| protected | False|
| size  | 971606528|
| status| active   |
| updated_at| 2016-07-22T02:25:46.00   |
| virtual_size  | None |
+---+--+

The null key set success as the result.
But null key is meaningless to the user which also belong to the invalid input 
in other components, like cinder and nova flavor as below:

root@controller01:~# nova flavor-key m1.tiny set =
ERROR (CommandError): Invalid key: "". Keys may only contain letters, numbers, 
spaces, underscores, periods, colons and hyphens.

So for the consistent openstack UE and error handling, glance cli site
better to add the null key check.

** Affects: glance
     Importance: Undecided
 Assignee: QiangTang (qtang)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => QiangTang (qtang)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1605444

Title:
  Should check null key when set key-value pair in property

Status in Glance:
  New

Bug description:
  root@controller01:~# glance image-update ubuntu-14.04-server-amd64 --property 
=
  +---+--+
  | Property  | Value|
  +---+--+
  | Property ''   | None |
  | Property 'vmware_adaptertype' | lsiLogic |
  | Property 'vmware_disktype'| streamOptimized  |
  | checksum  | 7b26c526f6f7c8ab874ad55b2698dee0 |
  | container_format  | bare |
  | created_at| 2016-07-21T07:37:42.00   |
  | deleted   | False|
  | deleted_at| None |
  | disk_format   | vmdk |
  | id| 2fb0b8a1-1634-499d-95ee-2451ec23893e |
  | is_public | True |
  | min_disk  | 5|
  | min_ram   | 512  |
  | name  | ubuntu-14.04-server-amd64|
  | owner | 5b53ee384ebc4212b4086241e1075dea |
  | protected | False|
  | size  | 971606528|
  | status| active   |
  | updated_at| 2016-07-22T02:25:46.00   |
  | virtual_size  | None |
  +---+--+

  The null key set success as the result.
  But null key is meaningless to the user which also belong to the invalid 
input in other components, like cinder and nova flavor as below:

  root@controller01:~# nova flavor-key m1.tiny set =
  ERROR (CommandError): Inva