[Yahoo-eng-team] [Bug 1717918] [NEW] Failed to create sahara cluster if reauthentication_auth_method =trusts
Public bug reported: set reauthentication_auth_method =trusts heat stack-create sahara_cluster -f sahara_cluster.yaml sahara-engine came into error when to get image, with following error: Forbidden: You are not authorized to perform the requested action: Using trust-scoped token to create another token. Create a new trust-scoped token instead. (HTTP 403) The error log is very clear, heat passed trust scoped token to sahara. Setting "reauthentication_auth_method =trusts" works well for other components but sahara. sahara_cluster.yaml: heat_template_version: 2015-04-30 resources: sahara_cluster: type: OS::Sahara::Cluster properties: name: rdo plugin_name: spark hadoop_version: 1.6.0 default_image_id: 4ae3ae1a-ca7f-428b-ae2b-782fb81a9dd2 cluster_template_id: 7c8f8453-0934-4270-917f-7e3188320a9a key_name: stack neutron_management_network: private use_autoconfig: true ** Affects: heat Importance: Undecided Status: New ** Affects: keystone Importance: Undecided Status: New ** Affects: sahara Importance: Undecided Status: New ** Also affects: sahara Importance: Undecided Status: New ** Also affects: keystone Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1717918 Title: Failed to create sahara cluster if reauthentication_auth_method =trusts Status in OpenStack Heat: New Status in OpenStack Identity (keystone): New Status in Sahara: New Bug description: set reauthentication_auth_method =trusts heat stack-create sahara_cluster -f sahara_cluster.yaml sahara-engine came into error when to get image, with following error: Forbidden: You are not authorized to perform the requested action: Using trust-scoped token to create another token. Create a new trust-scoped token instead. (HTTP 403) The error log is very clear, heat passed trust scoped token to sahara. Setting "reauthentication_auth_method =trusts" works well for other components but sahara. sahara_cluster.yaml: heat_template_version: 2015-04-30 resources: sahara_cluster: type: OS::Sahara::Cluster properties: name: rdo plugin_name: spark hadoop_version: 1.6.0 default_image_id: 4ae3ae1a-ca7f-428b-ae2b-782fb81a9dd2 cluster_template_id: 7c8f8453-0934-4270-917f-7e3188320a9a key_name: stack neutron_management_network: private use_autoconfig: true To manage notifications about this bug go to: https://bugs.launchpad.net/heat/+bug/1717918/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1582561] [NEW] Collapse/Expand a dashboard/panel-group will reload ng-panel page
Public bug reported: Use project/ng-images as example, to reproduce: 1. enable ng-images, set DISABLED=False in /enabled/_1051_project_ng_images_panel.py 2. go into page "/project/ngimages/" 3. click left sidebar to collapse or expand a dashboard or panel-group. such as expand project/network panel group. 4. The url changed to "/project/ngimages/#sidebar-accordion-project-network" which resulted in that current page ng-images reloaded again(call api, throw toast messages to user) The reson is that the new url "/#sidebar-accordion-" match the url[1]. I did not find out how to change the url to make "/project/ngimages/#sidebar-accordion-project-network" miss. But if it's unnecessary, we could remove the href for the dashboard and panel-group in sidebar. [1]https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/images.module.js#L190. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1582561 Title: Collapse/Expand a dashboard/panel-group will reload ng-panel page Status in OpenStack Dashboard (Horizon): New Bug description: Use project/ng-images as example, to reproduce: 1. enable ng-images, set DISABLED=False in /enabled/_1051_project_ng_images_panel.py 2. go into page "/project/ngimages/" 3. click left sidebar to collapse or expand a dashboard or panel-group. such as expand project/network panel group. 4. The url changed to "/project/ngimages/#sidebar-accordion-project-network" which resulted in that current page ng-images reloaded again(call api, throw toast messages to user) The reson is that the new url "/#sidebar-accordion-" match the url[1]. I did not find out how to change the url to make "/project/ngimages/#sidebar-accordion-project-network" miss. But if it's unnecessary, we could remove the href for the dashboard and panel-group in sidebar. [1]https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/images.module.js#L190. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1582561/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1569185] [NEW] update_cell() in user table should be refactored
Public bug reported: update_cell() is called by inline edit user. 1. should only update the changed cell instead of whole user data 2. there is no project column in table so it will never be updated remove 'project' to unnecessary api call. ref: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L420 3. avoid set email to empty string. ref: https://bugs.launchpad.net/horizon/+bug/1265805 ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: In Progress ** Summary changed: - update cell of user should be refactored + update_cell() in user table should be refactored ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1569185 Title: update_cell() in user table should be refactored Status in OpenStack Dashboard (Horizon): In Progress Bug description: update_cell() is called by inline edit user. 1. should only update the changed cell instead of whole user data 2. there is no project column in table so it will never be updated remove 'project' to unnecessary api call. ref: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L420 3. avoid set email to empty string. ref: https://bugs.launchpad.net/horizon/+bug/1265805 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1569185/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1568747] [NEW] Default SESSION_ENGINE in deployment.rst is out of sync with that in settings.py
Public bug reported: Value of SESSION_ENGINE in settings.py had been changed from "cache" to "signed_cookies" in patch: https://review.openstack.org/#/c/6473/12. Related Default SESSION_ENGINE in deployment.rst is out of sync, fix it. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: In Progress ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) ** Description changed: Value of SESSION_ENGINE in settings.py had been changed from "cache" to "signed_cookies" in patch: https://review.openstack.org/#/c/6473/12. - Related info in deployment.rst is out of sync, fix it. + + Related Default SESSION_ENGINE in deployment.rst is out of sync, fix it. -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1568747 Title: Default SESSION_ENGINE in deployment.rst is out of sync with that in settings.py Status in OpenStack Dashboard (Horizon): In Progress Bug description: Value of SESSION_ENGINE in settings.py had been changed from "cache" to "signed_cookies" in patch: https://review.openstack.org/#/c/6473/12. Related Default SESSION_ENGINE in deployment.rst is out of sync, fix it. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1568747/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1563654] [NEW] scss files can not be automatically discovered
Public bug reported: Ref:http://docs.openstack.org/developer/horizon/tutorials/plugin.html. There are some configure settings for plugin development. AUTO_DISCOVER_STATIC_FILES = True ADD_JS_FILES = [ ] ADD_SCSS_FILES = [ ] Ref: https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L123 if AUTO_DISCOVER_STATIC_FILES == True, both static resources including js files and scss files under myplugin/static/ should be discovered to be compressed. But now only js files could be discovered, scss files are left. ref: https://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L79. That result in we must add scss files of plugin into ADD_SCSS_FILES. ref: https://github.com/openstack/magnum- ui/blob/master/enabled/_50_project_containers_panelgroup.py#L34 IMO this is not what we want, both js and scss files should be discovered automatically. And "ADD_JS_FILES" and "ADD_SCSS_FILES" are used for specific files not in myplugin/static/. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) ** Description changed: Ref:http://docs.openstack.org/developer/horizon/tutorials/plugin.html. There are some configure settings for plugin development. AUTO_DISCOVER_STATIC_FILES = True ADD_JS_FILES = [ ] ADD_SCSS_FILES = [ ] Ref: https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L123 - if AUTO_DISCOVER_STATIC_FILES == True, both static resources including js files and scss files under myplugin/static/ should be discovered to be compressed. + if AUTO_DISCOVER_STATIC_FILES == True, both static resources including js files and scss files under myplugin/static/ should be discovered to be compressed. But now only js files could be discovered, scss files are left. ref: https://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L79. That result in we must add scss files of plugin into ADD_SCSS_FILES. + ref: https://github.com/openstack/magnum- + ui/blob/master/enabled/_50_project_containers_panelgroup.py#L34 + + IMO this is not what we want, both js and scss files should be + discovered automatically. And "ADD_JS_FILES" and "ADD_SCSS_FILES" are + used for specific files not in myplugin/static/. -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1563654 Title: scss files can not be automatically discovered Status in OpenStack Dashboard (Horizon): New Bug description: Ref:http://docs.openstack.org/developer/horizon/tutorials/plugin.html. There are some configure settings for plugin development. AUTO_DISCOVER_STATIC_FILES = True ADD_JS_FILES = [ ] ADD_SCSS_FILES = [ ] Ref: https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L123 if AUTO_DISCOVER_STATIC_FILES == True, both static resources including js files and scss files under myplugin/static/ should be discovered to be compressed. But now only js files could be discovered, scss files are left. ref: https://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L79. That result in we must add scss files of plugin into ADD_SCSS_FILES. ref: https://github.com/openstack/magnum- ui/blob/master/enabled/_50_project_containers_panelgroup.py#L34 IMO this is not what we want, both js and scss files should be discovered automatically. And "ADD_JS_FILES" and "ADD_SCSS_FILES" are used for specific files not in myplugin/static/. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1563654/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1562834] [NEW] There are some trivial errors in doc/tutorials/plugin.rst
Public bug reported: 1. ADD_JS_FILES is not menthoned but only ADD_SCSS_FILES http://docs.openstack.org/developer/horizon/tutorials/plugin.html#file-structure http://docs.openstack.org/developer/horizon/tutorials/plugin.html#mypanel-scss 2. static files under static/ could be discovery automatically 3. "div" should not in scss file. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1562834 Title: There are some trivial errors in doc/tutorials/plugin.rst Status in OpenStack Dashboard (Horizon): New Bug description: 1. ADD_JS_FILES is not menthoned but only ADD_SCSS_FILES http://docs.openstack.org/developer/horizon/tutorials/plugin.html#file-structure http://docs.openstack.org/developer/horizon/tutorials/plugin.html#mypanel-scss 2. static files under static/ could be discovery automatically 3. "div" should not in scss file. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1562834/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1560449] [NEW] Link of Django logging directive in deployment.rst is out of date
Public bug reported: Current link is out of date. It's 404 Page not found now. Change it to a link regardless of specific django version ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: In Progress ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1560449 Title: Link of Django logging directive in deployment.rst is out of date Status in OpenStack Dashboard (Horizon): In Progress Bug description: Current link is out of date. It's 404 Page not found now. Change it to a link regardless of specific django version To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1560449/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1525472] Re: Taking into account the exception with status_code
has been fixed in this patch: https://review.openstack.org/#/c/256140/35 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1525472 Title: Taking into account the exception with status_code Status in OpenStack Dashboard (Horizon): Fix Released Bug description: When an exception occurs in ajax[1], we get status code from only two kinds of exceptions: exception with property 'http_status' or 'code'. To make it easier to distinguish between different error, we should take into account the exception with 'status_code', such as NotAuthorized[2]. [1]: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/utils.py#L136 [2]: https://github.com/openstack/horizon/blob/master/horizon/exceptions.py#L119 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1525472/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1553148] [NEW] Annotaion in rest create_user is confusing
Public bug reported: email is an optional argument, both '' and None could successfully create a new user with no email info. The difference is: If email=None, the value will be NULL in db. If email='', there is no value of email column in db. Clear current annotation "# not sure why email is forced to None, but other code does it" ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: In Progress ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1553148 Title: Annotaion in rest create_user is confusing Status in OpenStack Dashboard (Horizon): In Progress Bug description: email is an optional argument, both '' and None could successfully create a new user with no email info. The difference is: If email=None, the value will be NULL in db. If email='', there is no value of email column in db. Clear current annotation "# not sure why email is forced to None, but other code does it" To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1553148/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1540254] Re: "#flake8: noqa" is using incorrectly
** Also affects: murano Importance: Undecided Status: New ** Changed in: murano Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1540254 Title: "#flake8: noqa" is using incorrectly Status in Designate: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in Murano: In Progress Status in python-heatclient: Fix Released Status in python-novaclient: Fix Released Bug description: "# flake8: noqa" option disables all checks for the whole file. To disable one line we should use "# noqa". Refer to: https://pypi.python.org/pypi/flake8 https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb To manage notifications about this bug go to: https://bugs.launchpad.net/designate/+bug/1540254/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1544522] Re: Don't use Mock.called_once_with that does not exist
** Also affects: octavia Importance: Undecided Status: New ** Changed in: octavia Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1544522 Title: Don't use Mock.called_once_with that does not exist Status in Cinder: Fix Released Status in neutron: In Progress Status in octavia: In Progress Status in Sahara: Fix Released Bug description: class mock.Mock does not exist method "called_once_with", it just exists method "assert_called_once_with". Currently there are still some places where we use called_once_with method, we should correct it. NOTE: called_once_with() does nothing because it's a mock object. To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1544522/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1280522] Re: Replace assertEqual(None, *) with assertIsNone in tests
** Also affects: octavia Importance: Undecided Status: New ** Changed in: octavia Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1280522 Title: Replace assertEqual(None, *) with assertIsNone in tests Status in Anchor: Fix Released Status in bifrost: Fix Committed Status in Blazar: In Progress Status in Cinder: Fix Released Status in congress: Fix Released Status in dox: New Status in Glance: Fix Released Status in glance_store: Fix Released Status in heat: Fix Released Status in heat-cfntools: Fix Released Status in Heat Translator: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in Ironic: Fix Released Status in ironic-python-agent: Fix Released Status in OpenStack Identity (keystone): Fix Released Status in keystoneauth: Fix Released Status in kolla-mesos: Fix Released Status in Manila: Fix Released Status in networking-cisco: Fix Released Status in OpenStack Compute (nova): Fix Released Status in octavia: In Progress Status in ooi: In Progress Status in os-client-config: Fix Released Status in python-barbicanclient: In Progress Status in python-ceilometerclient: Fix Released Status in python-cinderclient: Fix Released Status in python-congressclient: Fix Released Status in python-cueclient: Fix Released Status in python-designateclient: Fix Released Status in python-glanceclient: Fix Released Status in python-heatclient: Fix Released Status in python-ironicclient: Fix Released Status in python-manilaclient: Fix Released Status in python-neutronclient: Fix Released Status in python-openstackclient: In Progress Status in OpenStack SDK: In Progress Status in python-swiftclient: Fix Released Status in python-troveclient: Fix Released Status in Python client library for Zaqar: Fix Released Status in refstack: In Progress Status in Sahara: Fix Released Status in Solum: Fix Released Status in Stackalytics: In Progress Status in tempest: Fix Released Status in Trove: Fix Released Status in tuskar: Fix Released Status in zaqar: Fix Released Status in designate package in Ubuntu: New Status in python-tuskarclient package in Ubuntu: Fix Committed Bug description: Replace assertEqual(None, *) with assertIsNone in tests to have more clear messages in case of failure. To manage notifications about this bug go to: https://bugs.launchpad.net/anchor/+bug/1280522/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1540254] [NEW] "#flake8: noqa" is using incorrectly
Public bug reported: "# flake8: noqa" option disables all checks for the whole file. To disable one line we should use "# noqa". Refer to: https://pypi.python.org/pypi/flake8 https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1540254 Title: "#flake8: noqa" is using incorrectly Status in OpenStack Dashboard (Horizon): New Bug description: "# flake8: noqa" option disables all checks for the whole file. To disable one line we should use "# noqa". Refer to: https://pypi.python.org/pypi/flake8 https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1540254/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1540254] Re: "#flake8: noqa" is using incorrectly
** Also affects: python-heatclient Importance: Undecided Status: New ** Changed in: python-heatclient Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1540254 Title: "#flake8: noqa" is using incorrectly Status in OpenStack Dashboard (Horizon): New Status in python-heatclient: New Bug description: "# flake8: noqa" option disables all checks for the whole file. To disable one line we should use "# noqa". Refer to: https://pypi.python.org/pypi/flake8 https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1540254/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1540254] Re: "#flake8: noqa" is using incorrectly
** Also affects: python-novaclient Importance: Undecided Status: New ** Changed in: python-novaclient Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1540254 Title: "#flake8: noqa" is using incorrectly Status in OpenStack Dashboard (Horizon): In Progress Status in python-heatclient: In Progress Status in python-novaclient: New Bug description: "# flake8: noqa" option disables all checks for the whole file. To disable one line we should use "# noqa". Refer to: https://pypi.python.org/pypi/flake8 https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1540254/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1538932] [NEW] source.scss file does not take effect since it does not match source.html
Public bug reported: openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.html: ... But currently the source.scss is: [ng-controller="LaunchInstanceSourceController"] { td.hi-light { color: #0084d1; } ... } Any change of scss file(such as: color: red) does not take effect since the two files do not match. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: In Progress ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1538932 Title: source.scss file does not take effect since it does not match source.html Status in OpenStack Dashboard (Horizon): In Progress Bug description: openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.html: ... But currently the source.scss is: [ng-controller="LaunchInstanceSourceController"] { td.hi-light { color: #0084d1; } ... } Any change of scss file(such as: color: red) does not take effect since the two files do not match. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1538932/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1537641] [NEW] Change number of hacking rule for Horizon Specific Commandments
Public bug reported: Current is M3**, change to H3**. 'H' is the first capital from 'Horizon' That is more informative and consistent with other projects. nova: https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L26 glance: https://github.com/openstack/glance/blob/master/glance/hacking/checks.py#L24 ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) ** Description changed: - Current is M3**, change to H3**. 'H' the first capital from 'Horizon' - That is more informative and consistent with other project + Current is M3**, change to H3**. 'H' is the first capital from + 'Horizon' That is more informative and consistent with other project ** Description changed: Current is M3**, change to H3**. 'H' is the first capital from - 'Horizon' That is more informative and consistent with other project + 'Horizon' That is more informative and consistent with other projects. ** Description changed: - Current is M3**, change to H3**. 'H' is the first capital from - 'Horizon' That is more informative and consistent with other projects. + Current is M3**, change to H3**. 'H' is the first capital from 'Horizon' That is more informative and consistent with other projects. + nova: https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L26 + glance: https://github.com/openstack/glance/blob/master/glance/hacking/checks.py#L24 -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1537641 Title: Change number of hacking rule for Horizon Specific Commandments Status in OpenStack Dashboard (Horizon): New Bug description: Current is M3**, change to H3**. 'H' is the first capital from 'Horizon' That is more informative and consistent with other projects. nova: https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L26 glance: https://github.com/openstack/glance/blob/master/glance/hacking/checks.py#L24 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1537641/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1536878] [NEW] Fix codes with the annotation "FIXME"
Public bug reported: openstack/horizon / openstack_dashboard/dashboards/identity/projects/tables.py class TenantFilterAction(tables.FilterAction): def filter(self, table, tenants, filter_string): """Really naive case-insensitive search.""" # FIXME(gabriel): This should be smarter. Written for demo purposes. q = filter_string.lower() def comp(tenant): if q in tenant.name.lower(): return True return False return filter(comp, tenants) ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1536878 Title: Fix codes with the annotation "FIXME" Status in OpenStack Dashboard (Horizon): New Bug description: openstack/horizon / openstack_dashboard/dashboards/identity/projects/tables.py class TenantFilterAction(tables.FilterAction): def filter(self, table, tenants, filter_string): """Really naive case-insensitive search.""" # FIXME(gabriel): This should be smarter. Written for demo purposes. q = filter_string.lower() def comp(tenant): if q in tenant.name.lower(): return True return False return filter(comp, tenants) To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1536878/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1533514] [NEW] FilterAction does not filter rows as specified fields
Public bug reported: In Identity/Projects panel page, input filter string into Filter box. The result rows are not expected. Refer to: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/tables.py#L171 It expected the rows which filed "tenant.name" containing the input string. However, except "tenant.name" any other fileds containing the string in the rows has been selected as result. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Attachment added: "filteraction.png" https://bugs.launchpad.net/bugs/1533514/+attachment/4549042/+files/filteraction.png ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) ** Description changed: In Identity/Projects panel page, input filter string into Filter box. - The filtered rows are not expected. + The result rows are not expected. Refer to: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/tables.py#L171 - It want the rows in which only filed "tenant.name" containing the input + It expected the rows which filed "tenant.name" containing the input string. However, except "tenant.name" any other fileds containing the string in the rows has been selected as result. -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1533514 Title: FilterAction does not filter rows as specified fields Status in OpenStack Dashboard (Horizon): New Bug description: In Identity/Projects panel page, input filter string into Filter box. The result rows are not expected. Refer to: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/tables.py#L171 It expected the rows which filed "tenant.name" containing the input string. However, except "tenant.name" any other fileds containing the string in the rows has been selected as result. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1533514/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1532068] [NEW] Quota: Set total instances be unlimited but "no quota" displayed
Public bug reported: Modify project quota, set value of instances be unlimited. Create vm in ng-launchinstance page, it displayed "Total Instances (no quota)", that make user misunderstood. IMO, "Total Instances (No Limit)" is better that is consistent with what displayed in Project/Compute/Overview page. refer to: https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_limit_summary.html#L23 ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1532068 Title: Quota: Set total instances be unlimited but "no quota" displayed Status in OpenStack Dashboard (Horizon): New Bug description: Modify project quota, set value of instances be unlimited. Create vm in ng-launchinstance page, it displayed "Total Instances (no quota)", that make user misunderstood. IMO, "Total Instances (No Limit)" is better that is consistent with what displayed in Project/Compute/Overview page. refer to: https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_limit_summary.html#L23 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1532068/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1531095] [NEW] Fix help text in "Create Network" and "Update Subnet" dialogs
Public bug reported: In "Create Network" dialog, "Network" tab, the current help text: "Create a new network. " "In addition, a subnet associated with the network " "can be created in the next panel." > it's at the next tab not panel ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1531095 Title: Fix help text in "Create Network" and "Update Subnet" dialogs Status in OpenStack Dashboard (Horizon): New Bug description: In "Create Network" dialog, "Network" tab, the current help text: "Create a new network. " "In addition, a subnet associated with the network " "can be created in the next panel." > it's at the next tab not panel To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1531095/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1531109] [NEW] Fix error info when to create or update subnet
Public bug reported: Network address source could be manual or subnetpool. If api.neutron.is_extension_supported(request, 'subnet_allocation') == False, widget subnetpool which label is"Address Pool" will be hide, but error info still is ('Specify "Network Address", "Address pool" or clear "Create Subnet" checkbox.'), that will be misunderstand. In the other hand, it is allowed to supply empty subnetpool_id when to create subnet, refer to: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/networks/workflows.py#L285. So we do not need "Address pool" in error info. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1531109 Title: Fix error info when to create or update subnet Status in OpenStack Dashboard (Horizon): New Bug description: Network address source could be manual or subnetpool. If api.neutron.is_extension_supported(request, 'subnet_allocation') == False, widget subnetpool which label is"Address Pool" will be hide, but error info still is ('Specify "Network Address", "Address pool" or clear "Create Subnet" checkbox.'), that will be misunderstand. In the other hand, it is allowed to supply empty subnetpool_id when to create subnet, refer to: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/networks/workflows.py#L285. So we do not need "Address pool" in error info. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1531109/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1529541] [NEW] Remove unused logging import in horizon
Public bug reported: Remove unused logging import in horizon codes ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1529541 Title: Remove unused logging import in horizon Status in OpenStack Dashboard (Horizon): New Bug description: Remove unused logging import in horizon codes To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1529541/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1529556] [NEW] Remove unused services injecting in javascript files
Public bug reported: Find that in file: "openstack_dashboard/dashboards/project/static/dashboard/project/workflow /launch-instance/launch-instance-model.service.js". It injected unused service 'horizon.app.core.openstack-service-api.keystone'. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1529556 Title: Remove unused services injecting in javascript files Status in OpenStack Dashboard (Horizon): New Bug description: Find that in file: "openstack_dashboard/dashboards/project/static/dashboard/project/workflow /launch-instance/launch-instance-model.service.js". It injected unused service 'horizon.app.core.openstack-service-api.keystone'. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1529556/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1529012] [NEW] Miss policy checks in image panels
Public bug reported: There is no policy checking code in image panels: project/images, project/ngimages, admin/images. As ngusers code: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.controller.js#L54. We should add policy checks of "get_images" in image panels ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1529012 Title: Miss policy checks in image panels Status in OpenStack Dashboard (Horizon): New Bug description: There is no policy checking code in image panels: project/images, project/ngimages, admin/images. As ngusers code: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.controller.js#L54. We should add policy checks of "get_images" in image panels To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1529012/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1529007] [NEW] policy topic document has been out of date
Public bug reported: When I tried fix policy related bugs(#1411239) found that horizon/doc/source/topics/policy.rst has been out of date. We do not use "oslo-incubator" in horizon now. There is file "openstack_dashboard/openstack/common/policy.py" in hoirzon Refer to: https://github.com/openstack/horizon/blob/master/doc/source/topics/policy.rst ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Description changed: + When I tried fix policy related bugs(#1411239) found that + horizon/doc/source/topics/policy.rst has been out of date. + + We do not use "oslo-incubator" in horizon now. + There is file "openstack_dashboard/openstack/common/policy.py" in hoirzon + Refer to: https://github.com/openstack/horizon/blob/master/doc/source/topics/policy.rst - - We do not use "oslo-incubator" in horizon now. There is file - "openstack_dashboard/openstack/common/policy.py" in hoirzon ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1529007 Title: policy topic document has been out of date Status in OpenStack Dashboard (Horizon): New Bug description: When I tried fix policy related bugs(#1411239) found that horizon/doc/source/topics/policy.rst has been out of date. We do not use "oslo-incubator" in horizon now. There is file "openstack_dashboard/openstack/common/policy.py" in hoirzon Refer to: https://github.com/openstack/horizon/blob/master/doc/source/topics/policy.rst To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1529007/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1528777] [NEW] Remove not required packages in requirements.txt
Public bug reported: We need remove the not using packages in requirements.txt, Otherwise the requirements.txt will be updated when global requirements updated unnecessarily. ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) ** Description changed: - Remove the not using packages in requirements.txt, Otherwise - the requirements.txt will be updated when global requirements updated. + We need remove the not using packages in requirements.txt, Otherwise + the requirements.txt will be updated when global requirements updated unnecessarily. -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1528777 Title: Remove not required packages in requirements.txt Status in OpenStack Dashboard (Horizon): New Bug description: We need remove the not using packages in requirements.txt, Otherwise the requirements.txt will be updated when global requirements updated unnecessarily. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1528777/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1527042] [NEW] All customizable configurations should be above "from local.local_settings import *"
Public bug reported: In my deployed environment, I add some configure items at end of file dashboard/settings.py as default values. Try to overwrite some in openstack_dashboard/local/local_settings.py but failed. I find the following codes do the overwriting work: try: from local.local_settings import * # noqa except ImportError: logging.warning("No local_settings file found.") To ensure overwrite working, all the default configurations in settings.py(could be customized in local_settings.py) should be above line:"from local.local_settings import *". So we should move all customizable configurations above "from local.local_settings import *". ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) ** Description changed: In my deployed environment, I add some configure items at end of file dashboard/settings.py as default values. Try to overwrite some in openstack_dashboard/local/local_settings.py but failed. I find the following codes do the overwriting work: try: - from local.local_settings import * # noqa + from local.local_settings import * # noqa except ImportError: - logging.warning("No local_settings file found.") + logging.warning("No local_settings file found.") - To ensure overwrite working, all the customizable configurations should - be above "from local.local_settings import *". + To ensure overwrite working, all the default configurations in + settings.py(could be customized in local_settings.py) should be above + line:"from local.local_settings import *". - So we should move all customizable configurations should be above "from + So we should move all customizable configurations to be above "from local.local_settings import *". ** Description changed: In my deployed environment, I add some configure items at end of file dashboard/settings.py as default values. Try to overwrite some in openstack_dashboard/local/local_settings.py but failed. I find the following codes do the overwriting work: try: from local.local_settings import * # noqa except ImportError: logging.warning("No local_settings file found.") To ensure overwrite working, all the default configurations in settings.py(could be customized in local_settings.py) should be above line:"from local.local_settings import *". - So we should move all customizable configurations to be above "from + So we should move all customizable configurations above "from local.local_settings import *". -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1527042 Title: All customizable configurations should be above "from local.local_settings import *" Status in OpenStack Dashboard (Horizon): New Bug description: In my deployed environment, I add some configure items at end of file dashboard/settings.py as default values. Try to overwrite some in openstack_dashboard/local/local_settings.py but failed. I find the following codes do the overwriting work: try: from local.local_settings import * # noqa except ImportError: logging.warning("No local_settings file found.") To ensure overwrite working, all the default configurations in settings.py(could be customized in local_settings.py) should be above line:"from local.local_settings import *". So we should move all customizable configurations above "from local.local_settings import *". To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1527042/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1526140] [NEW] Should not use mutable default arguments in function definitions
Public bug reported: Refer to: http://docs.python-guide.org/en/latest/writing/gotchas/. We should not use mutable default arguments in function definitions. So we need remove the default arguments "[]" and "{}" in function definitions. "[]" has been removed in patch: https://review.openstack.org/#/c/256931/2. We also need fix the code incorrectly using "{}". ** Affects: horizon Importance: Undecided Assignee: Wang Bo (chestack) Status: New ** Changed in: horizon Assignee: (unassigned) => Wang Bo (chestack) ** Description changed: - Refer to: http://docs.python-guide.org/en/latest/writing/gotchas/. we - should not use mutable default arguments in function definitions. + Refer to: http://docs.python-guide.org/en/latest/writing/gotchas/. + We should not use mutable default arguments in function definitions. So we need remove the default arguments "[]" and "{}" in function definitions. "[]" has been removed in patch: - https://review.openstack.org/#/c/256931/2. We need fix the left "{}" - usage. + https://review.openstack.org/#/c/256931/2. We also need fix the code + incorrectly using "{}". -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1526140 Title: Should not use mutable default arguments in function definitions Status in OpenStack Dashboard (Horizon): New Bug description: Refer to: http://docs.python-guide.org/en/latest/writing/gotchas/. We should not use mutable default arguments in function definitions. So we need remove the default arguments "[]" and "{}" in function definitions. "[]" has been removed in patch: https://review.openstack.org/#/c/256931/2. We also need fix the code incorrectly using "{}". To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1526140/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1374362] [NEW] Need add ipset into requirements.txt because it's enabled default
Public bug reported: Since this patch https://review.openstack.org/#/c/111877 has been merged. Neutron ovs-agent used ipset to apply securitygroup rules on compute node now. If ipset was not installed on compute node, it will report this error: File /usr/lib/python2.6/site-packages/neutron/agent/linux/iptables_manager.py, line 424, in _apply_synchronized 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent root_helper=self.root_helper) 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent File /usr/lib/python2.6/site-packages/neutron/agent/linux/utils.py, line 81, in execute 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent raise RuntimeError(m) 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent RuntimeError: 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'iptables-restore', '-c'] 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Exit code: 1 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Stdout: '' 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Stderr: 'iptables-restore v1.4.7: Kernel module ip_set is not loaded in.\n\n' I think it need to add ipset into requirements.txt to ensure it could be installed when neutron ovs-agent installed. ** Affects: neutron Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1374362 Title: Need add ipset into requirements.txt because it's enabled default Status in OpenStack Neutron (virtual network service): New Bug description: Since this patch https://review.openstack.org/#/c/111877 has been merged. Neutron ovs-agent used ipset to apply securitygroup rules on compute node now. If ipset was not installed on compute node, it will report this error: File /usr/lib/python2.6/site-packages/neutron/agent/linux/iptables_manager.py, line 424, in _apply_synchronized 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent root_helper=self.root_helper) 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent File /usr/lib/python2.6/site-packages/neutron/agent/linux/utils.py, line 81, in execute 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent raise RuntimeError(m) 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent RuntimeError: 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'iptables-restore', '-c'] 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Exit code: 1 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Stdout: '' 2014-09-25 02:15:20.668 18151 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Stderr: 'iptables-restore v1.4.7: Kernel module ip_set is not loaded in.\n\n' I think it need to add ipset into requirements.txt to ensure it could be installed when neutron ovs-agent installed. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1374362/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1350751] [NEW] Nova responses unexpected error messages when fail to create flavor
Public bug reported: The response message is unexpected(not easy to understand) if the requested resource exceeded limitation when to create new flavor. Following are examples: 1. requested ram exceeded limitation: Run nova --debug flavor-create ram_test 10 99 20 1, the response info is: RESP BODY: {badRequest: {message: Invalid input received: memory_mb must be = 2147483647, code: 400}} 2. requested disk exceeded limitation: nova --debug flavor-create ram_test 10 1024 200 1 RESP BODY: {badRequest: {message: Invalid input received: root_gb must be = 2147483647, code: 400}} I think memory_mb and root_gb in above response messages are unexpected, ram and disk could be better to user. Hope for your comments. Thanks! ** Affects: nova Importance: Undecided Assignee: Wang Bo (chrische) Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1350751 Title: Nova responses unexpected error messages when fail to create flavor Status in OpenStack Compute (Nova): New Bug description: The response message is unexpected(not easy to understand) if the requested resource exceeded limitation when to create new flavor. Following are examples: 1. requested ram exceeded limitation: Run nova --debug flavor-create ram_test 10 99 20 1, the response info is: RESP BODY: {badRequest: {message: Invalid input received: memory_mb must be = 2147483647, code: 400}} 2. requested disk exceeded limitation: nova --debug flavor-create ram_test 10 1024 200 1 RESP BODY: {badRequest: {message: Invalid input received: root_gb must be = 2147483647, code: 400}} I think memory_mb and root_gb in above response messages are unexpected, ram and disk could be better to user. Hope for your comments. Thanks! To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1350751/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1318498] [NEW] Neutron db migration failed due to reorg pending if engine is DB2.
Public bug reported: Since db2 limitation, table will be in reorg pending state after some continuous alter table operations(add column, drop column). This means that the table is inaccessible for almost all operations until you perform a REORG. When run neutron db upgrade, from 4ca36cfc898c to 157a5d299379, the alembic scripts in that range added 3 columns and dropped 1 column for table ml2_port_bindings. That resulted in failure of table ml2_port_bindings in reorg pending state. Same problem for downgrade migration. environment: Openstack icehouse + DB2 10.5. We can't restrict community developers how to operate tables and this only happen on DB2 but not other engines. So we could only test the alembic scripts on DB2 and fix it. ** Affects: neutron Importance: Undecided Assignee: Wang Bo (chrische) Status: New ** Changed in: neutron Assignee: (unassigned) = Wang Bo (chrische) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1318498 Title: Neutron db migration failed due to reorg pending if engine is DB2. Status in OpenStack Neutron (virtual network service): New Bug description: Since db2 limitation, table will be in reorg pending state after some continuous alter table operations(add column, drop column). This means that the table is inaccessible for almost all operations until you perform a REORG. When run neutron db upgrade, from 4ca36cfc898c to 157a5d299379, the alembic scripts in that range added 3 columns and dropped 1 column for table ml2_port_bindings. That resulted in failure of table ml2_port_bindings in reorg pending state. Same problem for downgrade migration. environment: Openstack icehouse + DB2 10.5. We can't restrict community developers how to operate tables and this only happen on DB2 but not other engines. So we could only test the alembic scripts on DB2 and fix it. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1318498/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1314015] [NEW] It returned RESP:202 even if NoValidHost exception raised when run nova resize
Public bug reported: When I run nova --debug resize instanceid flavorid, nova scheduler will raise NoValidHost exception If there is no enough resource available on any computer node for the flavor requested. Then nova conductor will catch the exception and report Warning messages as follows: WARNING nova.scheduler.utils [req-c0d5f130-c5a9-41b7-8fe4-4d08be4cc774 9ed1534f040c43e98293f6bc6b632e96 bd5848810607480d968b6d1ca9a36637] Failed to compute_task_migrate_server: No valid host was found. However, it will return HTTP 202 response in the nova client log. I think this is bug that nova resize failed but return 202 which is Normal Response Code. By the way, why CoreFilter(but RamFilter is there) isn't default in scheduler_default_filters? If that scheduler will not check the vcpu resource when run nova resize. cfg.ListOpt('scheduler_default_filters', default=[ 'RetryFilter', 'AvailabilityZoneFilter', 'RamFilter', 'ComputeFilter', 'ComputeCapabilitiesFilter', 'ImagePropertiesFilter' ], ** Affects: nova Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1314015 Title: It returned RESP:202 even if NoValidHost exception raised when run nova resize Status in OpenStack Compute (Nova): New Bug description: When I run nova --debug resize instanceid flavorid, nova scheduler will raise NoValidHost exception If there is no enough resource available on any computer node for the flavor requested. Then nova conductor will catch the exception and report Warning messages as follows: WARNING nova.scheduler.utils [req-c0d5f130-c5a9-41b7-8fe4-4d08be4cc774 9ed1534f040c43e98293f6bc6b632e96 bd5848810607480d968b6d1ca9a36637] Failed to compute_task_migrate_server: No valid host was found. However, it will return HTTP 202 response in the nova client log. I think this is bug that nova resize failed but return 202 which is Normal Response Code. By the way, why CoreFilter(but RamFilter is there) isn't default in scheduler_default_filters? If that scheduler will not check the vcpu resource when run nova resize. cfg.ListOpt('scheduler_default_filters', default=[ 'RetryFilter', 'AvailabilityZoneFilter', 'RamFilter', 'ComputeFilter', 'ComputeCapabilitiesFilter', 'ImagePropertiesFilter' ], To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1314015/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp