[Yahoo-eng-team] [Bug 1494895] [NEW] The sqlalchemy migrate script 042_ has bad file permissions

2015-09-11 Thread Wayne
Public bug reported:

042_add_changes_to_reinstall_unique_metadef_constraints.py has file permissions 
of 755 (rwxrwxr-x).
These should be changed to 644 (rw-r--r--).

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: In Progress

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1494895

Title:
  The sqlalchemy migrate script 042_ has bad file permissions

Status in Glance:
  In Progress

Bug description:
  042_add_changes_to_reinstall_unique_metadef_constraints.py has file 
permissions of 755 (rwxrwxr-x).
  These should be changed to 644 (rw-r--r--).

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1494895/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1471048] [NEW] glance metadef resource-type-associate fails in postgresql

2015-07-02 Thread Wayne
Public bug reported:

The following failure appears in the glance-api.log file when trying to run:
glance --os-image-api-version 2 md-resource-type-associate --name 
name-of-resource name-of-namespace
in postgresql (this error does NOT appear if running mysql or sqlite).

DBAPIError exception wrapped from (ProgrammingError) column "protected" is of 
type boolean but expression is of type integer
LINE 1: ...'2015-07-02T23:46:18.125563'::timestamp, 'myrt3', 0) RETURNING...
 ^
HINT:  You will need to rewrite or cast the expression.
 'INSERT INTO metadef_resource_types (created_at, updated_at, name, protected) 
VALUES (%(created_at)s, %(updated_at)s, %(name)s, %(protected)s) RETURNING 
metadef_resource_types.id' {'created_at': datetime.datetime(2015, 7, 2, 23, 46, 
18, 125552), 'protected': 0, 'updated_at': datetime.datetime(2015, 7, 2, 23, 
46, 18, 125563), 'name': u'myrt3'}

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1471048

Title:
  glance metadef resource-type-associate fails in postgresql

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  The following failure appears in the glance-api.log file when trying to run:
  glance --os-image-api-version 2 md-resource-type-associate --name 
name-of-resource name-of-namespace
  in postgresql (this error does NOT appear if running mysql or sqlite).

  DBAPIError exception wrapped from (ProgrammingError) column "protected" is of 
type boolean but expression is of type integer
  LINE 1: ...'2015-07-02T23:46:18.125563'::timestamp, 'myrt3', 0) RETURNING...
   ^
  HINT:  You will need to rewrite or cast the expression.
   'INSERT INTO metadef_resource_types (created_at, updated_at, name, 
protected) VALUES (%(created_at)s, %(updated_at)s, %(name)s, %(protected)s) 
RETURNING metadef_resource_types.id' {'created_at': datetime.datetime(2015, 7, 
2, 23, 46, 18, 125552), 'protected': 0, 'updated_at': datetime.datetime(2015, 
7, 2, 23, 46, 18, 125563), 'name': u'myrt3'}

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1471048/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1468946] [NEW] glance metadef tables need unique constraints

2015-06-25 Thread Wayne
Public bug reported:

Sometime during Kilo, the unique constraints on
metadef_namespaces (namespace)
metadef_objects(namespace_id, name)
metadef_properties(namespace_id, name)
metadef_tags(namespace_id, name)
metadef_resource_types(name)
were removed.
I believe this was done erroneously to make the migrate_repo/versions/scripts 
match the db/sqlalchemy/models_metadef.py definitions. Unfortunately, the 
schema scripts were correct with the unique constraints and what should have 
changed was the models_metadef.py.
This bug, puts one more migrate script in place which will rename any duplicate 
records it finds to make them unique and then re-establishes the unique 
constraints. It also, fixes models_metadef.py and adds in tests to create 
duplicates which should result in an HTTPConflict.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New


** Tags: metadef

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1468946

Title:
  glance metadef tables need unique constraints

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  Sometime during Kilo, the unique constraints on
  metadef_namespaces (namespace)
  metadef_objects(namespace_id, name)
  metadef_properties(namespace_id, name)
  metadef_tags(namespace_id, name)
  metadef_resource_types(name)
  were removed.
  I believe this was done erroneously to make the migrate_repo/versions/scripts 
match the db/sqlalchemy/models_metadef.py definitions. Unfortunately, the 
schema scripts were correct with the unique constraints and what should have 
changed was the models_metadef.py.
  This bug, puts one more migrate script in place which will rename any 
duplicate records it finds to make them unique and then re-establishes the 
unique constraints. It also, fixes models_metadef.py and adds in tests to 
create duplicates which should result in an HTTPConflict.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1468946/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1434761] Re: glance-manage db load_metadefs does not load all resource_type_associations

2015-04-07 Thread Wayne
** Changed in: glance
   Status: Fix Released => Fix Committed

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1434761

Title:
  glance-manage db load_metadefs does not load all
  resource_type_associations

Status in OpenStack Image Registry and Delivery Service (Glance):
  Fix Committed

Bug description:
  The glance-manage db load_metadefs should create
  metadef_namespace_resource_types entries for all
  resource_type_associations listed in a given .json file.
  Unfortunately, load_metadefs only creates a
  metadef_namespace_resource_types entry if the associated resource_type
  is new.

  There are 6 resource_types and as a result only 6
  metadef_namespace_resource_types records are generated instead of the
  expected 31 (as of this writing).

  The bug fix should generate all metadef_namespace_resource_types.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1434761/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1434761] Re: glance-manage db load_metadefs does not load all resource_type_associations

2015-04-07 Thread Wayne
** Changed in: glance
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1434761

Title:
  glance-manage db load_metadefs does not load all
  resource_type_associations

Status in OpenStack Image Registry and Delivery Service (Glance):
  Fix Released

Bug description:
  The glance-manage db load_metadefs should create
  metadef_namespace_resource_types entries for all
  resource_type_associations listed in a given .json file.
  Unfortunately, load_metadefs only creates a
  metadef_namespace_resource_types entry if the associated resource_type
  is new.

  There are 6 resource_types and as a result only 6
  metadef_namespace_resource_types records are generated instead of the
  expected 31 (as of this writing).

  The bug fix should generate all metadef_namespace_resource_types.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1434761/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1436877] [NEW] metadef JSON files need updating for the Kilo release

2015-03-26 Thread Wayne
Public bug reported:

Since Juno, some new hardware properties have been added to Nova that
should be included in the Kilo versions of the metadef JSON files. This
bug, would add in new properties or objects found in Nova and update
properties or objects if the definitions have changed.

** Affects: glance
 Importance: Undecided
 Status: New


** Tags: metadef

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1436877

Title:
  metadef JSON files need updating for the Kilo release

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  Since Juno, some new hardware properties have been added to Nova that
  should be included in the Kilo versions of the metadef JSON files.
  This bug, would add in new properties or objects found in Nova and
  update properties or objects if the definitions have changed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1436877/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1434761] [NEW] glance-manage db load_metadefs does not load all resource_type_associations

2015-03-20 Thread Wayne
Public bug reported:

The glance-manage db load_metadefs should create
metadef_namespace_resource_types entries for all
resource_type_associations listed in a given .json file. Unfortunately,
load_metadefs only creates a metadef_namespace_resource_types entry if
the associated resource_type is new.

There are 6 resource_types and as a result only 6
metadef_namespace_resource_types records are generated instead of the
expected 31 (as of this writing).

The bug fix should generate all metadef_namespace_resource_types.

** Affects: glance
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1434761

Title:
  glance-manage db load_metadefs does not load all
  resource_type_associations

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  The glance-manage db load_metadefs should create
  metadef_namespace_resource_types entries for all
  resource_type_associations listed in a given .json file.
  Unfortunately, load_metadefs only creates a
  metadef_namespace_resource_types entry if the associated resource_type
  is new.

  There are 6 resource_types and as a result only 6
  metadef_namespace_resource_types records are generated instead of the
  expected 31 (as of this writing).

  The bug fix should generate all metadef_namespace_resource_types.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1434761/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1419945] [NEW] metadef tags create api does not match blue-print

2015-02-09 Thread Wayne
Public bug reported:

The blueprint for metadef tags shows:
Create / Replace all tags in a specific namespace
POST /metadefs/namespaces/{namespace}/tags/
and
Add tag in a specific namespace:
POST /metadefs/namespaces/{namespace}/tags/{tag}

Unfortunately, these were implemented as:
Create / Replace all tags in a specific namespace
PUT  /metadefs/namespaces/{namespace}/tags/
and
POST  /metadefs/namespaces/{namespace}/tags/

This bug seeks to rectify this situation and use the correct action/URI.
Even though the metadef tag library has been checked in, the associated 
python-glanceclient check in has not been approved yet. Additionally, the specs 
for the metadef tag changes have not been posted anywhere yet, so, hopefully 
this can be changed with minimal impact.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1419945

Title:
  metadef tags create api does not match blue-print

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  The blueprint for metadef tags shows:
  Create / Replace all tags in a specific namespace
  POST /metadefs/namespaces/{namespace}/tags/
  and
  Add tag in a specific namespace:  
  POST /metadefs/namespaces/{namespace}/tags/{tag}

  Unfortunately, these were implemented as:
  Create / Replace all tags in a specific namespace
  PUT  /metadefs/namespaces/{namespace}/tags/
  and
  POST  /metadefs/namespaces/{namespace}/tags/

  This bug seeks to rectify this situation and use the correct action/URI.
  Even though the metadef tag library has been checked in, the associated 
python-glanceclient check in has not been approved yet. Additionally, the specs 
for the metadef tag changes have not been posted anywhere yet, so, hopefully 
this can be changed with minimal impact.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1419945/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1414875] [NEW] The api.authorization.MetadefTagProxy.__init__ method is redundant.

2015-01-26 Thread Wayne
Public bug reported:

Currently, the MetadefTagProxy in api/authorization has an __init__ def
which simply calls glance.domain.proxy.MetadefTag.__init__. This is
redundant as this will automatically happen if __init__ is called
because MetadefTagProxy inheriits __init__ from MetadefTag.

The MetadefTagProxy.__init__ method can be replaced with pass.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: In Progress

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

** Changed in: glance
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1414875

Title:
  The api.authorization.MetadefTagProxy.__init__ method is redundant.

Status in OpenStack Image Registry and Delivery Service (Glance):
  In Progress

Bug description:
  Currently, the MetadefTagProxy in api/authorization has an __init__
  def which simply calls glance.domain.proxy.MetadefTag.__init__. This
  is redundant as this will automatically happen if __init__ is called
  because MetadefTagProxy inheriits __init__ from MetadefTag.

  The MetadefTagProxy.__init__ method can be replaced with pass.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1414875/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1404311] [NEW] gce metadata api doesn't properly stream binary data

2014-12-19 Thread Wayne Witzel III
Public bug reported:

While implementing the GCE provider for Juju we found that the metadata
API breaks when trying to retrieve certain binary formats. In our case
the gz of user-data. The API only streams out the first 5 bytes,
encounters what it preceives as a EOF/nil character and truncates the
rest of the request.

We've opened an issue with Google directly, but in the meantime a work
around is to allow an explicit encoding to be set for the user-data
field of the GCE metadata. This will allow use to base64 encode the
binary blob, which the API returns the entire contents of without issue.

** Affects: cloud-init
 Importance: Undecided
 Status: New

** Branch linked: lp:~wwitzel3/cloud-init/gce

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1404311

Title:
  gce metadata api doesn't properly stream binary data

Status in Init scripts for use on cloud images:
  New

Bug description:
  While implementing the GCE provider for Juju we found that the
  metadata API breaks when trying to retrieve certain binary formats. In
  our case the gz of user-data. The API only streams out the first 5
  bytes, encounters what it preceives as a EOF/nil character and
  truncates the rest of the request.

  We've opened an issue with Google directly, but in the meantime a work
  around is to allow an explicit encoding to be set for the user-data
  field of the GCE metadata. This will allow use to base64 encode the
  binary blob, which the API returns the entire contents of without
  issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1404311/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1403426] [NEW] The MetadefPropery Proxy object is missing created_at, updated_at

2014-12-17 Thread Wayne
Public bug reported:

In the glance/domain/proxy.py module, the MetadefProperty class doesn't contain 
the created_at nor updated_at fields.
They should be added to match the other classes.

** Affects: glance
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1403426

Title:
  The MetadefPropery Proxy object is missing created_at, updated_at

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  In the glance/domain/proxy.py module, the MetadefProperty class doesn't 
contain the created_at nor updated_at fields.
  They should be added to match the other classes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1403426/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1392485] [NEW] metadef modules should only use - from wsme.rest import json

2014-11-13 Thread Wayne
Public bug reported:

Several metadef module routines use:
from wsme.rest.json import fromjson
from wsme.rest.json import tojson

To follow the import rules at http://docs.openstack.org/developer/hacking/ 
(only import modules), these should be replaced with:
from wsme.rest import json

** Affects: glance
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1392485

Title:
  metadef modules should only use - from wsme.rest import json

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  Several metadef module routines use:
  from wsme.rest.json import fromjson
  from wsme.rest.json import tojson

  To follow the import rules at http://docs.openstack.org/developer/hacking/ 
(only import modules), these should be replaced with:
  from wsme.rest import json

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1392485/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1391691] [NEW] Add Metadef Tag Support

2014-11-11 Thread Wayne
Public bug reported:

This defect will introduce the first round of support for Metadef Tags.
Both DB and API CRUD operations for the metadef_tags table will be
supported.

The metadef_tags table is:
CREATE TABLE `metadef_tags` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`namespace_id` int(11) NOT NULL,
`name` varchar(80) NOT NULL,
`created_at` timestamp NOT NULL,
`updated_at` timestamp
)

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1391691

Title:
  Add Metadef Tag Support

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  This defect will introduce the first round of support for Metadef
  Tags. Both DB and API CRUD operations for the metadef_tags table will
  be supported.

  The metadef_tags table is:
  CREATE TABLE `metadef_tags` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `namespace_id` int(11) NOT NULL,
  `name` varchar(80) NOT NULL,
  `created_at` timestamp NOT NULL,
  `updated_at` timestamp
  )

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1391691/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1378968] [NEW] Metadef schema column name is a reserved word in MySQL

2014-10-08 Thread Wayne
Public bug reported:

The metadef_properties and metadef_objects tables both have a column
named schema. Unfortunately, schema is a reserved word in some
relational database products, including MySQL and PostgreSQL. The
metadef_properties.schema and metadef_objects.schema columns should be
renamed to a non reserved word.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1378968

Title:
  Metadef schema column name is a reserved word in MySQL

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  The metadef_properties and metadef_objects tables both have a column
  named schema. Unfortunately, schema is a reserved word in some
  relational database products, including MySQL and PostgreSQL. The
  metadef_properties.schema and metadef_objects.schema columns should be
  renamed to a non reserved word.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1378968/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1371837] [NEW] Metadef ORM classes should use a common delete

2014-09-19 Thread Wayne
Public bug reported:

The metadef db delete functions typically have code like this:
session.delete(db_rec)
session.flush()

To be consistent with the ORM classes save() function implementation, it would 
be better to add a delete function
to the base metadef ORM class (i.e., GlanceMetadefBase).

Background - Both GlanceBase and GlanceMetadefBase ORM classes call 
oslo.db.sqlalchemy.models.ModelBase.save() for create/update.
There is no function for hard deletes in ModelBase.

The ModelBase.save function is simply:
def save(self, session)
with session.begin(subtransactions=True):
session.add(self)
session.flush()
Note: See comments in ModelBase.save for more details on the need for "with 
session.begin(subtransactions=True_"

The new GlanceMetadefBase.delete() function should be implemented in a
way that is consistent with the oslo ModelBase.save function
implementation.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1371837

Title:
  Metadef ORM classes should use a common delete

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  The metadef db delete functions typically have code like this:
  session.delete(db_rec)
  session.flush()

  To be consistent with the ORM classes save() function implementation, it 
would be better to add a delete function
  to the base metadef ORM class (i.e., GlanceMetadefBase).

  Background - Both GlanceBase and GlanceMetadefBase ORM classes call 
oslo.db.sqlalchemy.models.ModelBase.save() for create/update.
  There is no function for hard deletes in ModelBase.

  The ModelBase.save function is simply:
  def save(self, session)
  with session.begin(subtransactions=True):
  session.add(self)
  session.flush()
  Note: See comments in ModelBase.save for more details on the need for "with 
session.begin(subtransactions=True_"

  The new GlanceMetadefBase.delete() function should be implemented in a
  way that is consistent with the oslo ModelBase.save function
  implementation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1371837/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1370099] [NEW] Refactor metadef namespace _select_namespaces_query to include filtering

2014-09-16 Thread Wayne
Public bug reported:

Move the filtering logic out of _get_all into the
_select_namespaces_query def so that all query building logic is in the
same method.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1370099

Title:
  Refactor metadef namespace _select_namespaces_query to include
  filtering

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  Move the filtering logic out of _get_all into the
  _select_namespaces_query def so that all query building logic is in
  the same method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1370099/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1370058] [NEW] Refactor metadef ORM as_dict method to to_dict for consistency

2014-09-16 Thread Wayne
Public bug reported:

The Metadef ORM classes should refactor as_dict to to_dict to be
consistent with other glance ORM classes.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1370058

Title:
  Refactor metadef ORM as_dict method to to_dict for consistency

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  The Metadef ORM classes should refactor as_dict to to_dict to be
  consistent with other glance ORM classes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1370058/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1368479] [NEW] Metadef Property and Object schema columns should use JSONEncodedDict

2014-09-11 Thread Wayne
Public bug reported:

The MetadefProperty and MetadefObject ORM classes currently specify the
JSON schema columns as type Text. It is preferred to use the
JSONEncodedDict Type Decorator instead.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1368479

Title:
  Metadef Property and Object schema columns should use JSONEncodedDict

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  The MetadefProperty and MetadefObject ORM classes currently specify
  the JSON schema columns as type Text. It is preferred to use the
  JSONEncodedDict Type Decorator instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1368479/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1367650] [NEW] Use existing Metadef{type}NotFound Exceptions instead of MetadefRecordNotFound

2014-09-10 Thread Wayne
Public bug reported:

Currently, when metadef namespaces, objects or properties are not found
by ID a general MetadefRecordNotFound exception is thrown. It is better
use the existing MetadefNamespace/Object/PropertyNotFound Exceptions
instead of the too general MetadefRecordNotFound exception.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1367650

Title:
  Use existing Metadef{type}NotFound Exceptions instead of
  MetadefRecordNotFound

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  Currently, when metadef namespaces, objects or properties are not
  found by ID a general MetadefRecordNotFound exception is thrown. It is
  better use the existing MetadefNamespace/Object/PropertyNotFound
  Exceptions instead of the too general MetadefRecordNotFound exception.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1367650/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1367619] [NEW] MetadefNamespace.namespaces column should indicate nullable=False

2014-09-10 Thread Wayne
Public bug reported:

The metadef_namespaces table definition indicates the namespace column
as not accepting nulls. The related MetadefNamespace ORM class should
also indicate that the namespace column does not accept nulls with
"nullable=False" in the column definition.

** Affects: glance
 Importance: Undecided
 Assignee: Wayne (wayne-okuma)
 Status: New

** Changed in: glance
 Assignee: (unassigned) => Wayne (wayne-okuma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1367619

Title:
  MetadefNamespace.namespaces column should indicate nullable=False

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  The metadef_namespaces table definition indicates the namespace column
  as not accepting nulls. The related MetadefNamespace ORM class should
  also indicate that the namespace column does not accept nulls with
  "nullable=False" in the column definition.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1367619/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp