[Yahoo-eng-team] [Bug 1584558] Re: Some config options in codes use double quotes but most of the options use single quotes and that need to be normalized
** Changed in: ceilometer Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1584558 Title: Some config options in codes use double quotes but most of the options use single quotes and that need to be normalized Status in Ceilometer: Won't Fix Status in Cinder: In Progress Status in Glance: Fix Released Status in heat: In Progress Status in OpenStack Compute (nova): In Progress Bug description: description: most options like this use '': volume_manager_opts = [ cfg.StrOpt('volume_driver', default='cinder.volume.drivers.lvm.LVMISCSIDriver', help='Driver to use for volume creation'), cfg.IntOpt('migration_create_volume_timeout_secs', default=300, help='Timeout for creating the volume to migrate to ' 'when performing volume migration (seconds)'), cfg.BoolOpt('volume_service_inithost_offload', default=False, help='Offload pending volume delete during ' 'volume service startup'), cfg.StrOpt('zoning_mode', default='none', help='FC Zoning mode configured'), cfg.StrOpt('extra_capabilities', default='{}', help='User defined capabilities, a JSON formatted string ' 'specifying key/value pairs. The key/value pairs can ' 'be used by the CapabilitiesFilter to select between ' 'backends when requests specify volume types. For ' 'example, specifying a service level or the geographical ' 'location of a backend, then creating a volume type to ' 'allow the user to select by these different ' 'properties.'), ] but some option like this use "" store_type_opts = [ cfg.ListOpt("store_type_preference", default=[], help=_("The store names to use to get store preference order. " "The name must be registered by one of the stores " "defined by the 'stores' config option. " "This option will be applied when you using " "'store_type' option as image location strategy " "defined by the 'location_strategy' config option.")) ] profiler_opts = [ cfg.BoolOpt("enabled", default=False, help=_('If False fully disable profiling feature.')), cfg.BoolOpt("trace_sqlalchemy", default=False, help=_("If False doesn't trace SQL requests.")) ] I think it's need to normalize To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1584558/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1574493] [NEW] keystone tox -epy27 fail in devstack environment
Public bug reported: reproduce steps: 1. clone devstack, enable keystone 2. cd /opt/stack/keystone && tox -epy27 == Failed 1 tests - output below: == keystone.tests.unit.test_cli.CliNoConfigTestCase.test_cli - Captured traceback: ~~~ Traceback (most recent call last): File "keystone/tests/unit/test_cli.py", line 71, in test_cli self.assertThat(self.logging.output, matchers.Contains(expected_msg)) File "/tmp/keystone/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 493, in assertThat raise mismatch_error testtools.matchers._impl.MismatchError: 'Config file not found, using default configs.' not in u'' If I remove /etc/keystone/keystone.conf then it will succeed As a developer, I always run devstack on my workstation, and as unit test code shouldn't rely on or affected by real environment, I think this is a bug which should be fixed already have a solution, I will fix it by myself ** Affects: keystone Importance: Undecided Assignee: ZhiQiang Fan (aji-zqfan) Status: In Progress ** Changed in: keystone Assignee: (unassigned) => ZhiQiang Fan (aji-zqfan) ** Changed in: keystone Status: New => In Progress -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1574493 Title: keystone tox -epy27 fail in devstack environment Status in OpenStack Identity (keystone): In Progress Bug description: reproduce steps: 1. clone devstack, enable keystone 2. cd /opt/stack/keystone && tox -epy27 == Failed 1 tests - output below: == keystone.tests.unit.test_cli.CliNoConfigTestCase.test_cli - Captured traceback: ~~~ Traceback (most recent call last): File "keystone/tests/unit/test_cli.py", line 71, in test_cli self.assertThat(self.logging.output, matchers.Contains(expected_msg)) File "/tmp/keystone/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 493, in assertThat raise mismatch_error testtools.matchers._impl.MismatchError: 'Config file not found, using default configs.' not in u'' If I remove /etc/keystone/keystone.conf then it will succeed As a developer, I always run devstack on my workstation, and as unit test code shouldn't rely on or affected by real environment, I think this is a bug which should be fixed already have a solution, I will fix it by myself To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1574493/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1214176] Re: Fix copyright headers to be compliant with Foundation policies
** Changed in: devstack Status: Fix Committed => Fix Released ** Changed in: tempest Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1214176 Title: Fix copyright headers to be compliant with Foundation policies Status in Ceilometer: Fix Released Status in devstack: Fix Released Status in heat: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in OpenStack Identity (keystone): Fix Released Status in neutron: Fix Released Status in OpenStack Compute (nova): Fix Released Status in python-ceilometerclient: Fix Released Status in python-cinderclient: Fix Released Status in python-glanceclient: Fix Released Status in python-heatclient: Fix Released Status in python-keystoneclient: Fix Released Status in python-neutronclient: Fix Released Status in OpenStack Object Storage (swift): Fix Released Status in tempest: Fix Released Status in OpenStack DBaaS (Trove): Fix Released Bug description: Correct the copyright headers to be consistent with the policies outlined by the OpenStack Foundation at http://www.openstack.org/brand /openstack-trademark-policy/ Remove references to OpenStack LLC, replace with OpenStack Foundation To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1214176/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1411836] Re: Configuration files should not be manually updated
rejected by cores ** Changed in: glance Status: In Progress => Invalid ** Changed in: glance Assignee: ZhiQiang Fan (aji-zqfan) => (unassigned) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1411836 Title: Configuration files should not be manually updated Status in Glance: Invalid Bug description: The configuration files (glance-api.conf, glance-cache.conf, glance- registry.conf etc) are currently manually synced with the options defined in the code. This is causing an unnecessary amount of contributor's effort to maintain, especially when we can automatically keep them up to date using oslo-config-generator. They have also not been correctly updated in the past; glance-cache.conf does not have any of the deprecated glance store options marked as such, for example. A slight complication is some options currently have better documentation in the example config files, rather than the help text defined in the oslo.config option (example on current master: [DEFAULT]/property_protection_file). These options should be updated with the better documentation before automatic syncing takes place. To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1411836/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1466851] Re: Move to graduated oslo.service
** Also affects: designate Importance: Undecided Status: New ** Changed in: designate Status: New = In Progress ** Changed in: designate Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1466851 Title: Move to graduated oslo.service Status in OpenStack Telemetry (Ceilometer): Fix Committed Status in Cinder: In Progress Status in Designate: In Progress Status in OpenStack Image Registry and Delivery Service (Glance): Fix Released Status in Orchestration API (Heat): Fix Committed Status in OpenStack Identity (Keystone): In Progress Status in OpenStack Neutron (virtual network service): In Progress Status in OpenStack Compute (Nova): In Progress Status in OpenStack Data Processing (Sahara): In Progress Status in Openstack Database (Trove): In Progress Bug description: oslo.service library has graduated so all OpenStack projects should port to it instead of using oslo-incubator code. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1466851/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1466851] Re: Move to graduated oslo.service
** Also affects: magnum Importance: Undecided Status: New ** Changed in: magnum Status: New = In Progress ** Changed in: magnum Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1466851 Title: Move to graduated oslo.service Status in OpenStack Telemetry (Ceilometer): Fix Committed Status in Cinder: In Progress Status in Designate: In Progress Status in OpenStack Image Registry and Delivery Service (Glance): Fix Released Status in Orchestration API (Heat): Fix Committed Status in OpenStack Identity (Keystone): In Progress Status in OpenStack Magnum: In Progress Status in OpenStack Neutron (virtual network service): In Progress Status in OpenStack Compute (Nova): In Progress Status in OpenStack Data Processing (Sahara): In Progress Status in Openstack Database (Trove): In Progress Bug description: oslo.service library has graduated so all OpenStack projects should port to it instead of using oslo-incubator code. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1466851/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1398656] Re: ceilometer import oslo.concurrency failed issue
** Also affects: glance Importance: Undecided Status: New ** Changed in: glance Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1398656 Title: ceilometer import oslo.concurrency failed issue Status in OpenStack Telemetry (Ceilometer): Fix Released Status in Cinder: Fix Committed Status in Designate: Fix Released Status in OpenStack Image Registry and Delivery Service (Glance): New Status in OpenStack Bare Metal Provisioning Service (Ironic): Fix Released Status in OpenStack Identity (Keystone): Fix Committed Status in OpenStack Compute (Nova): Fix Released Bug description: during ceilometer review and find jenkis failed with following message: 2014-12-03 01:28:04.969 | pep8 runtests: PYTHONHASHSEED='0' 2014-12-03 01:28:04.969 | pep8 runtests: commands[0] | flake8 2014-12-03 01:28:04.970 | /home/jenkins/workspace/gate-ceilometer-pep8$ /home/jenkins/workspace/gate-ceilometer-pep8/.tox/pep8/bin/flake8 2014-12-03 01:28:21.508 | ./ceilometer/utils.py:30:1: H302 import only modules.'from oslo.concurrency import processutils' does not import a module 2014-12-03 01:28:21.508 | from oslo.concurrency import processutils 2014-12-03 01:28:21.508 | ^ 2014-12-03 01:28:21.508 | ./ceilometer/ipmi/platform/ipmitool.py:19:1: H302 import only modules.'from oslo.concurrency import processutils' does not import a module 2014-12-03 01:28:21.508 | from oslo.concurrency import processutils 2014-12-03 01:28:21.508 | ^ 2014-12-03 01:28:21.696 | ERROR: InvocationError: '/home/jenkins/workspace/gate-ceilometer-pep8/.tox/pep8/bin/flake8' 2014-12-03 01:28:21.697 | pep8 runtests: commands[1] | flake8 --filename=ceilometer-* bin This seems https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/processutils.py should change to from oslo_concurrency import processutils To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1398656/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1398656] Re: ceilometer import oslo.concurrency failed issue
** Also affects: nova Importance: Undecided Status: New ** Changed in: nova Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Also affects: keystone Importance: Undecided Status: New ** Changed in: keystone Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Changed in: nova Status: New = In Progress ** Changed in: keystone Status: New = In Progress ** Also affects: cinder Importance: Undecided Status: New ** Changed in: cinder Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Changed in: cinder Status: New = In Progress ** Also affects: designate Importance: Undecided Status: New ** Changed in: designate Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Changed in: designate Status: New = In Progress ** Also affects: ironic Importance: Undecided Status: New ** Changed in: ironic Status: New = In Progress ** Changed in: ironic Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1398656 Title: ceilometer import oslo.concurrency failed issue Status in OpenStack Telemetry (Ceilometer): Fix Committed Status in Cinder: In Progress Status in Designate: In Progress Status in OpenStack Bare Metal Provisioning Service (Ironic): In Progress Status in OpenStack Identity (Keystone): In Progress Status in OpenStack Compute (Nova): In Progress Bug description: during ceilometer review and find jenkis failed with following message: 2014-12-03 01:28:04.969 | pep8 runtests: PYTHONHASHSEED='0' 2014-12-03 01:28:04.969 | pep8 runtests: commands[0] | flake8 2014-12-03 01:28:04.970 | /home/jenkins/workspace/gate-ceilometer-pep8$ /home/jenkins/workspace/gate-ceilometer-pep8/.tox/pep8/bin/flake8 2014-12-03 01:28:21.508 | ./ceilometer/utils.py:30:1: H302 import only modules.'from oslo.concurrency import processutils' does not import a module 2014-12-03 01:28:21.508 | from oslo.concurrency import processutils 2014-12-03 01:28:21.508 | ^ 2014-12-03 01:28:21.508 | ./ceilometer/ipmi/platform/ipmitool.py:19:1: H302 import only modules.'from oslo.concurrency import processutils' does not import a module 2014-12-03 01:28:21.508 | from oslo.concurrency import processutils 2014-12-03 01:28:21.508 | ^ 2014-12-03 01:28:21.696 | ERROR: InvocationError: '/home/jenkins/workspace/gate-ceilometer-pep8/.tox/pep8/bin/flake8' 2014-12-03 01:28:21.697 | pep8 runtests: commands[1] | flake8 --filename=ceilometer-* bin This seems https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/processutils.py should change to from oslo_concurrency import processutils To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1398656/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1323975] Re: do not use default=None for config options
** Also affects: cinder Importance: Undecided Status: New ** Changed in: cinder Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1323975 Title: do not use default=None for config options Status in OpenStack Telemetry (Ceilometer): In Progress Status in Cinder: New Status in OpenStack Image Registry and Delivery Service (Glance): Fix Released Status in Orchestration API (Heat): Fix Released Status in MagnetoDB - key-value storage service for OpenStack: New Status in OpenStack Neutron (virtual network service): New Status in OpenStack Compute (Nova): Confirmed Status in Oslo - a Library of Common OpenStack Code: Fix Committed Status in Messaging API for OpenStack: Fix Committed Status in OpenStack Data Processing (Sahara, ex. Savanna): Fix Released Status in Openstack Database (Trove): In Progress Bug description: In the cfg module default=None is set as the default value. It's not necessary to set it again when defining config options. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1323975/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1323975] Re: do not use default=None for config options
Christian Berendt has uploaded a patch for this bug: https://review.openstack.org/#/c/96480/ ** Also affects: keystone Importance: Undecided Status: New ** Changed in: nova Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1323975 Title: do not use default=None for config options Status in OpenStack Telemetry (Ceilometer): In Progress Status in Cinder: New Status in OpenStack Image Registry and Delivery Service (Glance): Fix Released Status in Orchestration API (Heat): Fix Released Status in OpenStack Bare Metal Provisioning Service (Ironic): In Progress Status in OpenStack Identity (Keystone): New Status in MagnetoDB - key-value storage service for OpenStack: New Status in OpenStack Neutron (virtual network service): Fix Committed Status in OpenStack Compute (Nova): Confirmed Status in Oslo - a Library of Common OpenStack Code: Fix Committed Status in Messaging API for OpenStack: Fix Committed Status in OpenStack Data Processing (Sahara, ex. Savanna): Fix Released Status in Openstack Database (Trove): In Progress Bug description: In the cfg module default=None is set as the default value. It's not necessary to set it again when defining config options. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1323975/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1323975] Re: do not use default=None for config options
** Also affects: marconi Importance: Undecided Status: New ** Changed in: marconi Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1323975 Title: do not use default=None for config options Status in OpenStack Telemetry (Ceilometer): In Progress Status in Cinder: In Progress Status in OpenStack Image Registry and Delivery Service (Glance): Fix Released Status in Orchestration API (Heat): Fix Released Status in OpenStack Bare Metal Provisioning Service (Ironic): In Progress Status in OpenStack Identity (Keystone): New Status in MagnetoDB - key-value storage service for OpenStack: New Status in OpenStack Message Queuing Service (Marconi): In Progress Status in OpenStack Neutron (virtual network service): Fix Committed Status in OpenStack Compute (Nova): Incomplete Status in Oslo - a Library of Common OpenStack Code: Fix Committed Status in Messaging API for OpenStack: Fix Committed Status in OpenStack Data Processing (Sahara, ex. Savanna): Fix Released Status in Openstack Database (Trove): In Progress Bug description: In the cfg module default=None is set as the default value. It's not necessary to set it again when defining config options. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1323975/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1323975] Re: do not use default=None for config options
** Also affects: barbican Importance: Undecided Status: New ** Changed in: barbican Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1323975 Title: do not use default=None for config options Status in Project Barbican: In Progress Status in OpenStack Telemetry (Ceilometer): In Progress Status in Cinder: In Progress Status in OpenStack Image Registry and Delivery Service (Glance): Fix Released Status in Orchestration API (Heat): Fix Released Status in OpenStack Bare Metal Provisioning Service (Ironic): In Progress Status in OpenStack Identity (Keystone): New Status in MagnetoDB - key-value storage service for OpenStack: New Status in OpenStack Message Queuing Service (Marconi): In Progress Status in OpenStack Neutron (virtual network service): Fix Committed Status in OpenStack Compute (Nova): Incomplete Status in Oslo - a Library of Common OpenStack Code: Fix Committed Status in Messaging API for OpenStack: Fix Committed Status in OpenStack Data Processing (Sahara, ex. Savanna): Fix Released Status in Openstack Database (Trove): In Progress Bug description: In the cfg module default=None is set as the default value. It's not necessary to set it again when defining config options. To manage notifications about this bug go to: https://bugs.launchpad.net/barbican/+bug/1323975/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1320150] Re: ceilometer.conf.sample should be ignored
** Also affects: nova Importance: Undecided Status: New ** Changed in: nova Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1320150 Title: ceilometer.conf.sample should be ignored Status in OpenStack Telemetry (Ceilometer): In Progress Status in OpenStack Compute (Nova): New Bug description: Patch: https://review.openstack.org/#/c/88560/ , (Change-Id: I0bbec0e86f63e6fcd691d626473ed8498024f7ab) has removed the ceilometer.conf.sample, but not add it to .gitignore file, which cause it is tracked after run tox -e genconfig And the [testenv:genconfig] in tox.ini doesn't need to inherit from [testenv], especially, the test-requirements.txt is not needed, actually, we can set 'deps = ' directly to let it do develop-install, and it will solve the dependency automatically, and finally get the same result as we do fully install dependency for now. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1320150/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1273988] [NEW] keystoneclient requires --pass to create user while keystone doesn't
Public bug reported: name is required in REST API, but CLI requires an extra argument --pass # uname -a Linux havana 3.8.0-29-generic #42~precise1-Ubuntu SMP Wed Aug 14 16:19:23 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux # keystone-manage --version 2013.2 # keystone --version 0.3.2 # curl -i -X POST http://160.132.0.17:35357/v2.0/users -H User-Agent: python-keystoneclient -H Content-Type: application/json -H X-Auth-Token: ac60d12b5b6c668f726a -d '{user: {name: test-create}}' HTTP/1.1 200 OK Vary: X-Auth-Token Content-Type: application/json Content-Length: 92 Date: Wed, 29 Jan 2014 07:27:09 GMT {user: {enabled: true, name: test-create, id: f23d8e2835a0491db1f13a313446768d}} # keystone user-create --name test-create Expecting to find string in password. The server could not comply with the request since it is either malformed or otherwise incorrect. The client is assumed to be in error. (HTTP 400) if keystone cli supports creating an user without pass, we can update that user's password by: # keystone user-password-update test-create --pass xxx to verify this solution: # keystone user-role-add --user test-create --tenant admin --role admin # can be other tenant and role # keystone --os-username test-create --os-password xxx --os-tenant-name admin user-get test-create +--+--+ | Property | Value | +--+--+ | enabled | True | |id| f23d8e2835a0491db1f13a313446768d | | name | test-create| +--+--+ the problem is that # keystone --debug user-create --name test-create WARNING: Bypassing authentication using a token endpoint (authentication credentials are being ignored). REQ: curl -i -X POST http://160.132.0.17:35357/v2.0/users -H User-Agent: python-keystoneclient -H Content-Type: application/json -H X-Auth-Token: ac60d12b5b6c668f726a REQ BODY: {user: {email: null, password: null, enabled: true, name: test-create, tenantId: null}} RESP: [400] CaseInsensitiveDict({'date': 'Wed, 29 Jan 2014 07:43:58 GMT', 'vary': 'X-Auth-Token', 'content-length': '236', 'content-type': 'application/json'}) RESP BODY: {error: {message: Expecting to find string in password. The server could not comply with the request since it is either malformed or otherwise incorrect. The client is assumed to be in error., code: 400, title: Bad Request}} the server side can bare pass attribute is not set, but cannot accept it is None we can fix this via set --pass to SUPRESS or update the server side validation to treat None as not set and leave it blank in db backend, I would prefer fix both side, since some user may claim such problem when he try to send a rest.json={..., 'pass': null} to server. ref: https://github.com/openstack/keystone/blob/2013.2.1/keystone/common/utils.py#L100 ** Affects: keystone Importance: Undecided Assignee: ZhiQiang Fan (aji-zqfan) Status: New ** Affects: python-keystoneclient Importance: Undecided Assignee: ZhiQiang Fan (aji-zqfan) Status: New ** Changed in: python-keystoneclient Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Also affects: keystone Importance: Undecided Status: New ** Changed in: keystone Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Description changed: name is required in REST API, but CLI requires an extra argument --pass + + # uname -a + Linux havana 3.8.0-29-generic #42~precise1-Ubuntu SMP Wed Aug 14 16:19:23 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux + + # keystone-manage --version + 2013.2 # keystone --version 0.3.2 # curl -i -X POST http://160.132.0.17:35357/v2.0/users -H User-Agent: python-keystoneclient -H Content-Type: application/json -H X-Auth-Token: ac60d12b5b6c668f726a -d '{user: {name: test-create}}' HTTP/1.1 200 OK Vary: X-Auth-Token Content-Type: application/json Content-Length: 92 Date: Wed, 29 Jan 2014 07:27:09 GMT {user: {enabled: true, name: test-create, id: f23d8e2835a0491db1f13a313446768d}} # keystone user-create --name test-create Expecting to find string in password. The server could not comply with the request since it is either malformed or otherwise incorrect. The client is assumed to be in error. (HTTP 400) if keystone cli supports creating an user without pass, we can update that user's password by: # keystone user-password-update test-create --pass xxx to verify this solution: # keystone user-role-add --user test-create --tenant admin --role admin # can be other tenant and role # keystone --os-username test-create --os-password xxx --os-tenant-name admin user-get test-create +--+--+ | Property | Value | +--+--+ | enabled | True | |id
[Yahoo-eng-team] [Bug 1268480] Re: assertTrue(isinstance()) in tests should be replace with assertIsInstance()
** Also affects: heat Importance: Undecided Status: New ** Changed in: heat Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** No longer affects: heat ** Also affects: python-keystoneclient Importance: Undecided Status: New ** Changed in: python-keystoneclient Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1268480 Title: assertTrue(isinstance()) in tests should be replace with assertIsInstance() Status in OpenStack Telemetry (Ceilometer): New Status in Cinder: New Status in OpenStack Image Registry and Delivery Service (Glance): In Progress Status in OpenStack Identity (Keystone): In Progress Status in OpenStack Neutron (virtual network service): New Status in OpenStack Compute (Nova): New Status in Python client library for Ceilometer: New Status in Python client library for Cinder: New Status in Python client library for Keystone: New Status in Python client library for Nova: In Progress Bug description: some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1268480/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1268439] Re: range method is not same in py3.x and py2.x
** No longer affects: python-heatclient ** Also affects: python-swiftclient Importance: Undecided Status: New ** Changed in: python-swiftclient Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1268439 Title: range method is not same in py3.x and py2.x Status in OpenStack Telemetry (Ceilometer): New Status in Cinder: New Status in OpenStack Image Registry and Delivery Service (Glance): In Progress Status in Orchestration API (Heat): Triaged Status in OpenStack Identity (Keystone): New Status in OpenStack Neutron (virtual network service): In Progress Status in OpenStack Compute (Nova): New Status in Python client library for Neutron: New Status in Python client library for Swift: New Bug description: in py3.x,range is xrange in py2.x. in py3.x, if you want get a list,you must use: list(range(value)) I review the code, find that many codes use range for loop, if used py3.x environment, it will occure error. so we must modify this issue. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1268439/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1229324] Re: extraneous vim editor configuration comments
** Also affects: neutron Importance: Undecided Status: New ** Also affects: python-neutronclient Importance: Undecided Status: New ** Changed in: python-neutronclient Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Changed in: neutron Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1229324 Title: extraneous vim editor configuration comments Status in OpenStack Telemetry (Ceilometer): Fix Released Status in Cinder: Confirmed Status in Orchestration API (Heat): New Status in OpenStack Neutron (virtual network service): New Status in Oslo - a Library of Common OpenStack Code: In Progress Status in Python client library for Ceilometer: In Progress Status in Python client library for heat: New Status in Python client library for Neutron: New Status in OpenStack Object Storage (Swift): New Bug description: Many of the source code files have a beginning line # vim: tabstop=4 shiftwidth=4 softtabstop=4 This should be deleted. Many of these lines are in the ceilometer/openstack/common directory. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1229324/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1264328] [NEW] incorrect kwargs detail for webob.exc.HTTP*
Public bug reported: When review patch: https://review.openstack.org/64099 I realized that, when we instantiate webob.exc.HTTP* class, we should use explanation instead of detail, or the http response will get message of default explanation instead what we expect. Besides, there are some i18n problem in those message, will be fixed in the same time. Other i18n problem will not be solved in this bug fix ** Affects: neutron Importance: Undecided Assignee: ZhiQiang Fan (aji-zqfan) Status: New ** Affects: nova Importance: Undecided Assignee: ZhiQiang Fan (aji-zqfan) Status: New ** Changed in: nova Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Also affects: neutron Importance: Undecided Status: New ** Changed in: neutron Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1264328 Title: incorrect kwargs detail for webob.exc.HTTP* Status in OpenStack Neutron (virtual network service): New Status in OpenStack Compute (Nova): New Bug description: When review patch: https://review.openstack.org/64099 I realized that, when we instantiate webob.exc.HTTP* class, we should use explanation instead of detail, or the http response will get message of default explanation instead what we expect. Besides, there are some i18n problem in those message, will be fixed in the same time. Other i18n problem will not be solved in this bug fix To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1264328/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1264193] [NEW] wrong doc string for glance.db.sqlalchemy.migration.db_sync
Public bug reported: When review patch: https://review.openstack.org/#/c/64076/ I found that: def db_sync(version=None, current_version=None): Place a database under migration control and perform an upgrade :retval version number sql_connection = CONF.sql_connection try: _version_control(current_version or 0) except versioning_exceptions.DatabaseAlreadyControlledError as e: pass if current_version is None: current_version = int(db_version()) if version is not None and int(version) current_version: downgrade(version=version) elif version is None or int(version) current_version: upgrade(version=version) db_sync doesn't return anything, the doc string and code are broken. Since db_sync() accept empty arguments list, so a reasonable version number should be returned instead of remove the incorrect doc string. ** Affects: glance Importance: Undecided Assignee: ZhiQiang Fan (aji-zqfan) Status: New ** Tags: db low-hanging-fruit ** Changed in: glance Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Tags added: db low-hanging-fruit -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1264193 Title: wrong doc string for glance.db.sqlalchemy.migration.db_sync Status in OpenStack Image Registry and Delivery Service (Glance): New Bug description: When review patch: https://review.openstack.org/#/c/64076/ I found that: def db_sync(version=None, current_version=None): Place a database under migration control and perform an upgrade :retval version number sql_connection = CONF.sql_connection try: _version_control(current_version or 0) except versioning_exceptions.DatabaseAlreadyControlledError as e: pass if current_version is None: current_version = int(db_version()) if version is not None and int(version) current_version: downgrade(version=version) elif version is None or int(version) current_version: upgrade(version=version) db_sync doesn't return anything, the doc string and code are broken. Since db_sync() accept empty arguments list, so a reasonable version number should be returned instead of remove the incorrect doc string. To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1264193/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1264204] [NEW] redundant code in glance.tests.unit.utils:FakeDB.reset
Public bug reported: glance.tests.unit.utils:FakeDB uses glance.db.simple.api FakeDB implements reset with: @staticmethod def reset(): simple_db.DATA = { 'images': {}, 'members': [], 'tags': {}, 'locations': [], 'tasks': {}, 'task_info': {} } while api already has: def reset(): global DATA DATA = { 'images': {}, 'members': [], 'tags': {}, 'locations': [], 'tasks': {}, 'task_info': {} } the redundant code in glance.tests.unit.utils:FakeDB.reset should be replaced with simple_db.reset() ** Affects: glance Importance: Undecided Assignee: ZhiQiang Fan (aji-zqfan) Status: New ** Tags: low-hanging-fruit unittest ** Changed in: glance Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) ** Tags added: low-hanging-fruit unittest -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1264204 Title: redundant code in glance.tests.unit.utils:FakeDB.reset Status in OpenStack Image Registry and Delivery Service (Glance): New Bug description: glance.tests.unit.utils:FakeDB uses glance.db.simple.api FakeDB implements reset with: @staticmethod def reset(): simple_db.DATA = { 'images': {}, 'members': [], 'tags': {}, 'locations': [], 'tasks': {}, 'task_info': {} } while api already has: def reset(): global DATA DATA = { 'images': {}, 'members': [], 'tags': {}, 'locations': [], 'tasks': {}, 'task_info': {} } the redundant code in glance.tests.unit.utils:FakeDB.reset should be replaced with simple_db.reset() To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1264204/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1262424] Re: Files without code should not contain copyright notices
** Also affects: ceilometer Importance: Undecided Status: New ** Changed in: ceilometer Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1262424 Title: Files without code should not contain copyright notices Status in OpenStack Telemetry (Ceilometer): New Status in OpenStack Neutron (virtual network service): Confirmed Status in OpenStack Compute (Nova): New Bug description: Due to a recent policy change in HACKING (http://docs.openstack.org/developer/hacking/#openstack-licensing), empty files should no longer contain copyright notices. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1262424/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1262424] Re: Files without code should not contain copyright notices
** Also affects: heat Importance: Undecided Status: New ** Changed in: heat Assignee: (unassigned) = ZhiQiang Fan (aji-zqfan) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1262424 Title: Files without code should not contain copyright notices Status in OpenStack Telemetry (Ceilometer): New Status in Orchestration API (Heat): New Status in OpenStack Neutron (virtual network service): Confirmed Status in OpenStack Compute (Nova): New Bug description: Due to a recent policy change in HACKING (http://docs.openstack.org/developer/hacking/#openstack-licensing), empty files should no longer contain copyright notices. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1262424/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1221890] Re: wrong name in openvswitch ut
sorry, i misunderstand the code ** Changed in: neutron Status: Incomplete = Invalid ** Changed in: neutron Assignee: ZhiQiang Fan (aji-zqfan) = (unassigned) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1221890 Title: wrong name in openvswitch ut Status in OpenStack Neutron (virtual network service): Invalid Bug description: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/openvswitch/test_agent_scheduler.py#L1088 class OvsL3AgentNotifierTestCase(OvsAgentSchedulerTestCaseBase): def setUp(self): self.dhcp_notifier_cls_p = mock.patch( 'neutron.api.rpc.agentnotifiers.dhcp_rpc_agent_api.' 'DhcpAgentNotifyAPI') self.dhcp_notifier = mock.Mock(name='dhcp_notifier') this will be fixed in the refactor of test_agent_scheduler patch To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1221890/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1221130] Re: format string missing object type in keystone
this is not a bug, because it is a str.find, not string formatting, please use other example to comfirm this bug ** Changed in: keystone Status: In Progress = Invalid -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Keystone. https://bugs.launchpad.net/bugs/1221130 Title: format string missing object type in keystone Status in OpenStack Identity (Keystone): Invalid Bug description: I have found some errors in keystone like below: if CONF.logging_exception_prefix.find('%(asctime)') != -1: The correct code should be if CONF.logging_exception_prefix.find('%(asctime)s') != -1: I will make a collection of this kind of bugs in keystone and fix them. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1221130/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1220234] Re: *.pyc should be removed before run test in tox.ini
** Changed in: neutron Status: Incomplete = Invalid ** Changed in: keystone Status: Incomplete = Invalid ** Changed in: keystone Assignee: ZhiQiang Fan (aji-zqfan) = (unassigned) ** Changed in: neutron Assignee: ZhiQiang Fan (aji-zqfan) = (unassigned) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1220234 Title: *.pyc should be removed before run test in tox.ini Status in OpenStack Identity (Keystone): Invalid Status in OpenStack Neutron (virtual network service): Invalid Bug description: reproduce: $ git rm neutron/scheduler/l3_agent_scheduler.py $ tox -epy27 test_agent_scheduler ... Ran 486 (+116) tests in 63.833s (-82.301s) PASSED (id=225) ... py27: commands succeeded the *.pyc will be removed before run test in run_tests.sh, so ./run_tests.sh will fail, but tox doesn't do the same, so it still success after add line after tox.ini#L44 /usr/bin/find . -type f -name *.pyc -delete $ tox -epy27 test_agent_scheduler ... ImportError: No module named l3_agent_scheduler ... Ran 488 (+481) tests in 10.087s (+9.636s) FAILED (id=231, failures=245 (+238)) ... ERROR: py27: commands failed the absolute path of find may cause problem, but if i don't specify it, there is a warning: WARNING:test command found but not installed in testenv cmd: /usr/bin/find env: /home/zqfan/openstack/neutron/.tox/py27 Maybe forgot to specify a dependency? but tox still performs in the correct way To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1220234/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1216231] Re: downgrade python-subunit to avoid `unpack requires a string argument of length 1`
** Changed in: neutron Status: Incomplete = Invalid ** Changed in: python-neutronclient Status: Incomplete = Invalid ** Changed in: python-neutronclient Assignee: ZhiQiang Fan (aji-zqfan) = (unassigned) ** Changed in: neutron Assignee: ZhiQiang Fan (aji-zqfan) = (unassigned) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1216231 Title: downgrade python-subunit to avoid `unpack requires a string argument of length 1` Status in OpenStack Neutron (virtual network service): Invalid Status in Python client library for Neutron: Invalid Bug description: since subunit release its new version 0.0.14, run tox -epy27 will cause 'unpack requires a string argument of length 1' error and failed to run unittest we should downgrage it to 0.0.13, and tox -r option is needed for someone meet this problem. if you have already install .tox venv and subunit version is 0.0.13, then this problem will not present until you upgrade the module. this downgrade will be invalid if subunit fix this problem see bug: https://bugs.launchpad.net/subunit/+bug/1216163 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1216231/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1207823] Re: Fix the alphabetical order in requirement files
** Changed in: python-neutronclient Status: In Progress = Invalid ** Changed in: python-neutronclient Assignee: ZhiQiang Fan (aji-zqfan) = (unassigned) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1207823 Title: Fix the alphabetical order in requirement files Status in OpenStack Neutron (virtual network service): Fix Committed Status in Python client library for Neutron: Invalid Bug description: Fix the alphabetical order in requirement files, Bring into correspondence with other project,like: https://github.com/openstack/requirements/blob/master/requirements.txt To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1207823/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp