[Yahoo-eng-team] [Bug 1295448] Re: Big Switch Restproxy unit test unnecessarily duplicates tests
Reviewed: https://review.openstack.org/85523 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d8aba33049d7f60a699e713ce5d7ffb92037cbb0 Submitter: Jenkins Branch:milestone-proposed commit d8aba33049d7f60a699e713ce5d7ffb92037cbb0 Author: Kevin Benton blak...@gmail.com Date: Thu Mar 20 07:24:33 2014 -0700 De-duplicate unit tests for ports in Big Switch This eliminates the separate classes that existed for the VIF type testing. Each class was going through all of the port tests when none of the logic those tests were exercising was affected by the VIF types. This cut the number of tests run in test_restproxy_plugin by close to 44% without a reduction in code coverage. Closes-Bug: #1295448 Change-Id: I8c84e1599568fad36b6dd3d51e4ba8a3c012c6c5 (cherry picked from commit 913f45bc16dd2c35f7be772d5867f9208064498a) ** Changed in: neutron Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1295448 Title: Big Switch Restproxy unit test unnecessarily duplicates tests Status in OpenStack Neutron (virtual network service): Fix Released Bug description: The VIF type tests currently have separate classes that all extend the ports test class. This means in addition to testing the VIF changing logic, it's unnecessarily exercising a lot of code that is not impacted by the VIF type. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1295448/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1295448] Re: Big Switch Restproxy unit test unnecessarily duplicates tests
** Also affects: neutron/icehouse Importance: Undecided Status: New ** Changed in: neutron/icehouse Milestone: None = icehouse-rc2 ** Tags removed: icehouse-backport-potential -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1295448 Title: Big Switch Restproxy unit test unnecessarily duplicates tests Status in OpenStack Neutron (virtual network service): Fix Committed Status in neutron icehouse series: New Bug description: The VIF type tests currently have separate classes that all extend the ports test class. This means in addition to testing the VIF changing logic, it's unnecessarily exercising a lot of code that is not impacted by the VIF type. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1295448/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1295448] Re: Big Switch Restproxy unit test unnecessarily duplicates tests
** No longer affects: neutron/icehouse -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1295448 Title: Big Switch Restproxy unit test unnecessarily duplicates tests Status in OpenStack Neutron (virtual network service): Fix Committed Bug description: The VIF type tests currently have separate classes that all extend the ports test class. This means in addition to testing the VIF changing logic, it's unnecessarily exercising a lot of code that is not impacted by the VIF type. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1295448/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
