[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
OK. Removing trusty's nova task then. And unsubscribing ubuntu-
sponsors until a new patch is updated. Thanks, Liang!
** No longer affects: nova (Ubuntu Trusty)
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Fix Released
Status in OpenStack Compute (nova):
Fix Released
Status in oslo-incubator:
Fix Released
Status in cinder package in Ubuntu:
Fix Released
Status in nova package in Ubuntu:
Fix Released
Status in cinder source package in Trusty:
New
Bug description:
Nova SRU:
[Impact]
* Nova services fail to start because they cannot connect to rsyslog
[Test Case]
* Set user_syslog to True in nova.conf, stop rsyslog service and
restart nova services.
[Regression Potential]
* The following patches from 1385295 and 1399088 that address the
regression introduced in this bug's fix are also included.
fix-syslog-logging.patch (LP: #1385295)
move-syslog-instantiation.patch (LP: #1399088)
When nova services log to syslog, they should wait for syslog to start
prior to the nova-* services start.
Cinder SRU:
[Impact]
* Cinder services fail to start because they cannot connect to
rsyslog
[Test Case]
* Set user_syslog to True in cinder.conf, stop rsyslog service and
restart cinder services.
[Regression Potential]
* The following patches from 1385295 and 1399088 that address the
regression introduced in this bug's fix are also included.
fix-syslog-logging.patch (LP: #1385295)
move-syslog-instantiation.patch (LP: #1399088)
When cinder services log to syslog, they should wait for syslog to
start prior to the cinder-* services start.
Debug logs should be:
LOG.debug("message") should be LOG.debug(u"message")
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug("Failed to mount image %(ex)s)", {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File "nova/tests/virt/disk/test_api.py", line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File "nova/virt/disk/api.py", line 208, in is_image_partitionless
fs.setup()
File "nova/virt/disk/vfs/localfs.py", line 80, in setup
LOG.debug("Failed to mount image %(ex)s)", {'ex': e})
File "/usr/lib/python2.7/logging/__init__.py", line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File "/usr/lib/python2.7/logging/__init__.py", line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File "/usr/lib/python2.7/logging/__init__.py", line 1258, in _log
self.handle(record)
File "/usr/lib/python2.7/logging/__init__.py", line 1268, in handle
self.callHandlers(record)
File "/usr/lib/python2.7/logging/__init__.py", line 1308, in callHandlers
hdlr.handle(record)
File "nova/test.py", line 212, in handle
self.format(record)
File "/usr/lib/python2.7/logging/__init__.py", line 723, in format
return fmt.format(record)
File "/usr/lib/python2.7/logging/__init__.py", line 464, in format
record.message = record.getMessage()
File "/usr/lib/python2.7/logging/__init__.py", line 328, in getMessage
msg = msg % self.args
File
"/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py",
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
** Also affects: nova (Ubuntu Trusty)
Importance: Undecided
Status: New
** Also affects: cinder (Ubuntu Trusty)
Importance: Undecided
Status: New
** Changed in: cinder (Ubuntu)
Status: In Progress = Fix Released
** Changed in: nova (Ubuntu)
Status: In Progress = Fix Released
** Changed in: cinder (Ubuntu Trusty)
Assignee: (unassigned) = Liang Chen (cbjchen)
** Changed in: nova (Ubuntu Trusty)
Assignee: (unassigned) = Liang Chen (cbjchen)
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Fix Released
Status in OpenStack Compute (Nova):
Fix Released
Status in The Oslo library incubator:
Fix Released
Status in cinder package in Ubuntu:
Fix Released
Status in nova package in Ubuntu:
Fix Released
Status in cinder source package in Trusty:
New
Status in nova source package in Trusty:
New
Bug description:
[Impact]
* Nova services fail to start because they cannot connect to rsyslog
[Test Case]
* Set user_syslog to True in nova.conf, stop rsyslog service and
restart nova services.
[Regression Potential]
* None
When nova services log to syslog, they should wait for syslog to start
prior to the nova-* services start.
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
** Also affects: cinder (Ubuntu)
Importance: Undecided
Status: New
** Changed in: cinder (Ubuntu)
Assignee: (unassigned) = Liang Chen (cbjchen)
** Changed in: cinder (Ubuntu)
Status: New = In Progress
** Patch added: trusty cinder debdiff
https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/1348244/+attachment/4411763/+files/cinder-2014.1.4-0ubuntu4-lp1348244.patch
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Fix Released
Status in OpenStack Compute (Nova):
Fix Released
Status in The Oslo library incubator:
Fix Released
Status in cinder package in Ubuntu:
In Progress
Status in nova package in Ubuntu:
In Progress
Bug description:
[Impact]
* Nova services fail to start because they cannot connect to rsyslog
[Test Case]
* Set user_syslog to True in nova.conf, stop rsyslog service and
restart nova services.
[Regression Potential]
* None
When nova services log to syslog, they should wait for syslog to start
prior to the nova-* services start.
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
** Description changed:
+ [Impact]
+
+ * Nova services fail to start because they cannot connect to rsyslog
+
+ [Test Case]
+
+ * Set user_syslog to True in nova.conf, stop rsyslog service and
+ restart nova services.
+
+ [Regression Potential]
+
+ * None
+
+ When nova services log to syslog, we should make sure the dependency on
+ the upstart jobs is set prior to the nova-* services start.
+
+
Debug logs should be:
-
- LOG.debug(message) should be LOG.debug(umessage)
+
+ LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
-LOG.debug(Failed to mount image %(ex)s), {'ex': e})
+ LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled, if
a translation for the exception message was provided that was unicode.
+ Example trace:
- Example trace:
-
- Traceback (most recent call last):
- File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
- self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
- File nova/virt/disk/api.py, line 208, in is_image_partitionless
- fs.setup()
- File nova/virt/disk/vfs/localfs.py, line 80, in setup
- LOG.debug(Failed to mount image %(ex)s), {'ex': e})
- File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
- self.logger.debug(msg, *args, **kwargs)
- File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
- self._log(DEBUG, msg, args, **kwargs)
- File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
- self.handle(record)
- File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
- self.callHandlers(record)
- File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
- hdlr.handle(record)
- File nova/test.py, line 212, in handle
- self.format(record)
- File /usr/lib/python2.7/logging/__init__.py, line 723, in format
- return fmt.format(record)
- File /usr/lib/python2.7/logging/__init__.py, line 464, in format
- record.message = record.getMessage()
- File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
- msg = msg % self.args
- File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
- raise UnicodeError(msg)
+ Traceback (most recent call last):
+ File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
+ self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
+ File nova/virt/disk/api.py, line 208, in is_image_partitionless
+ fs.setup()
+ File nova/virt/disk/vfs/localfs.py, line 80, in setup
+ LOG.debug(Failed to mount image %(ex)s), {'ex': e})
+ File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
+ self.logger.debug(msg, *args, **kwargs)
+ File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
+ self._log(DEBUG, msg, args, **kwargs)
+ File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
+ self.handle(record)
+ File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
+ self.callHandlers(record)
+ File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
+ hdlr.handle(record)
+ File nova/test.py, line 212, in handle
+ self.format(record)
+ File /usr/lib/python2.7/logging/__init__.py, line 723, in format
+ return fmt.format(record)
+ File /usr/lib/python2.7/logging/__init__.py, line 464, in format
+ record.message = record.getMessage()
+ File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
+ msg = msg % self.args
+ File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
+ raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
** Description changed:
[Impact]
- * Nova services fail to start because they cannot connect to rsyslog
+ * Nova services fail to start because they cannot connect to rsyslog
[Test Case]
- * Set user_syslog to True in nova.conf, stop rsyslog
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
** Changed in: nova
Status: Fix Committed = Fix Released
** Changed in: nova
Milestone: None = juno-3
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Fix Released
Status in OpenStack Compute (Nova):
Fix Released
Status in The Oslo library incubator:
Fix Committed
Bug description:
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
** Changed in: oslo-incubator
Status: Fix Committed = Fix Released
** Changed in: oslo-incubator
Milestone: None = juno-3
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Fix Released
Status in OpenStack Compute (Nova):
Fix Released
Status in The Oslo library incubator:
Fix Released
Bug description:
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
** Changed in: cinder
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Fix Released
Status in OpenStack Compute (Nova):
Fix Committed
Status in The Oslo library incubator:
Fix Committed
Bug description:
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
Marking as invalid in Cinder.
** Changed in: cinder
Milestone: juno-3 = None
** Changed in: cinder
Status: In Progress = Invalid
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Invalid
Status in OpenStack Compute (Nova):
In Progress
Status in Oslo - a Library of Common OpenStack Code:
In Progress
Bug description:
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
Rushi, putting this back to confirmed and targeted. This is still an
issue but we are fixing it from a different approach. I want to leave
this open to track syncing the fix from Oslo.
** Changed in: cinder
Milestone: None = juno-3
** Changed in: cinder
Status: Invalid = Confirmed
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Confirmed
Status in OpenStack Compute (Nova):
In Progress
Status in Oslo - a Library of Common OpenStack Code:
In Progress
Bug description:
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
** Also affects: oslo
Importance: Undecided
Status: New
** Changed in: oslo
Assignee: (unassigned) = James Carey (jecarey)
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
In Progress
Status in OpenStack Compute (Nova):
In Progress
Status in Oslo - a Library of Common OpenStack Code:
New
Bug description:
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1348244] Re: debug log messages need to be unicode
A hacking check will also need to be created to go with this to make
sure this issue doesn't creep in with future commits.
** Also affects: cinder
Importance: Undecided
Status: New
** Changed in: cinder
Status: New = Confirmed
** Changed in: cinder
Importance: Undecided = High
** Changed in: cinder
Assignee: (unassigned) = Jay Bryant (jsbryant)
** Changed in: cinder
Milestone: None = juno-3
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1348244
Title:
debug log messages need to be unicode
Status in Cinder:
Confirmed
Status in OpenStack Compute (Nova):
New
Bug description:
Debug logs should be:
LOG.debug(message) should be LOG.debug(umessage)
Before the translation of debug log messages was removed, the
translation was returning unicode. Now that they are no longer
translated they need to be explicitly marked as unicode.
This was confirmed by discussion with dhellman. See
2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-oslo.2014-07-23.log
The problem was discovered when an exception was used as replacement
text in a debug log message:
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
In particular it was discovered as part of enabling lazy translation,
where the exception message is replaced with an object that does not
support str(). Note that this would also fail without lazy enabled,
if a translation for the exception message was provided that was
unicode.
Example trace:
Traceback (most recent call last):
File nova/tests/virt/disk/test_api.py, line 78, in
test_can_resize_need_fs_type_specified
self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True))
File nova/virt/disk/api.py, line 208, in is_image_partitionless
fs.setup()
File nova/virt/disk/vfs/localfs.py, line 80, in setup
LOG.debug(Failed to mount image %(ex)s), {'ex': e})
File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug
self.logger.debug(msg, *args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log
self.handle(record)
File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle
self.callHandlers(record)
File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers
hdlr.handle(record)
File nova/test.py, line 212, in handle
self.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 723, in format
return fmt.format(record)
File /usr/lib/python2.7/logging/__init__.py, line 464, in format
record.message = record.getMessage()
File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
File
/opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py,
line 167, in __str__
raise UnicodeError(msg)
UnicodeError: Message objects do not support str() because they may contain
non-ascii characters. Please use unicode() or translate() instead.
==
FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails
tags: worker-3
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
