Reviewed: https://review.openstack.org/294305 Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=608832024230f8bca6ee95da28ae074fb68f4a44 Submitter: Jenkins Branch: master
commit 608832024230f8bca6ee95da28ae074fb68f4a44 Author: Ronald De Rose <ronald.de.r...@intel.com> Date: Thu Mar 17 22:03:44 2016 +0000 Moved name formatting (clean) out of the driver Moved project name and group name formatting (clean) out of the driver and into the manager, which is aligned with how formatting is done for other attributes. Closes-Bug: 1391682 Change-Id: Ifb35472e6609a153320a19b6ec672d24548f629b ** Changed in: keystone Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1391682 Title: V2.0 parameter formatting for projects and groups should be removed from drivers Status in OpenStack Identity (keystone): Fix Released Bug description: Currently the assignment sql & ldap drivers to name cleansing on the project name - this should really be done in the manager to avoid this duplication. For example, the assignment/backend/sql.py module cleans parameters in the sql driver [1] for create_project(). The assignment/backend/ldap.py does the same validation on create_project() too [2]. This happens across different part of the V2.0 backends. [1] https://github.com/openstack/keystone/blob/b05a540e52fde324791eb07ad36e6d59c608a9c9/keystone/assignment/backends/sql.py#L442 [2] https://github.com/openstack/keystone/blob/b05a540e52fde324791eb07ad36e6d59c608a9c9/keystone/assignment/backends/ldap.py#L72 Also, clean is in the ldap driver for formatting the group name, but it is not in the sql driver. Thus, the sql driver incorrectly allows for trailing whitespace, but ldap doesn't. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1391682/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp