[Yahoo-eng-team] [Bug 1477142] Re: Remove redundant commas

[Cyril Roelandt]

$ git grep _get_sort_key
$ 

Marking as invalid

** Changed in: glance
   Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1477142

Title:
  Remove redundant commas

Status in Glance:
  Invalid

Bug description:
  In glance source, there is redundant comma in front of parenthesis. 
  For example in below:

  def _get_sort_key(self, req):
  """Parse a sort key query param from the request object."""
  sort_key = req.params.get('sort_key', 'created_at')
  if sort_key is not None and sort_key not in SUPPORTED_SORT_KEYS:
  _keys = ', '.join(SUPPORTED_SORT_KEYS)
  msg = _("Unsupported sort_key. Acceptable values: %s") % (_keys,)
  raise exc.HTTPBadRequest(explanation=msg)
  return sort_key

  in line six, the commas behind "_keys" is redundant, so we should
  remove it .

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1477142/+subscriptions


-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1477142] Re: Remove redundant commas

[liuyan]

** Changed in: glance
   Status: Invalid = In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1477142

Title:
  Remove redundant commas

Status in Glance:
  In Progress

Bug description:
  In glance source, there is redundant comma in front of parenthesis. 
  For example in below:

  def _get_sort_key(self, req):
  Parse a sort key query param from the request object.
  sort_key = req.params.get('sort_key', 'created_at')
  if sort_key is not None and sort_key not in SUPPORTED_SORT_KEYS:
  _keys = ', '.join(SUPPORTED_SORT_KEYS)
  msg = _(Unsupported sort_key. Acceptable values: %s) % (_keys,)
  raise exc.HTTPBadRequest(explanation=msg)
  return sort_key

  in line six, the commas behind _keys is redundant, so we should
  remove it .

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1477142/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1477142] Re: Remove redundant commas

[Ian Cordasco]

This more or less boils down to future-proofing. If we need to expand
the parameters included in these messages, it reduces the visual noise
in the diff.

** Changed in: glance
   Status: In Progress = Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1477142

Title:
  Remove redundant commas

Status in Glance:
  Invalid

Bug description:
  In glance source, there is redundant comma in front of parenthesis. 
  For example in below:

  def _get_sort_key(self, req):
  Parse a sort key query param from the request object.
  sort_key = req.params.get('sort_key', 'created_at')
  if sort_key is not None and sort_key not in SUPPORTED_SORT_KEYS:
  _keys = ', '.join(SUPPORTED_SORT_KEYS)
  msg = _(Unsupported sort_key. Acceptable values: %s) % (_keys,)
  raise exc.HTTPBadRequest(explanation=msg)
  return sort_key

  in line six, the commas behind _keys is redundant, so we should
  remove it .

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1477142/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp