[Yahoo-eng-team] [Bug 1505476] Re: when live-migrate failed, remove_volume_connection function accept incorrect arguments order in kilo
** Changed in: nova Status: In Progress => Fix Committed ** Changed in: nova Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1505476 Title: when live-migrate failed,remove_volume_connection function accept incorrect arguments order in kilo Status in OpenStack Compute (nova): Fix Released Bug description: Openstack Version : kilo 2015.1.0 Reproduce steps: please see the paths of codes:openstack/nova/nova/compute/manager.py def _rollback_live_migration(self, context, instance,dest, block_migration, migrate_data=None): .. for bdm in bdms: if bdm.is_volume: self.compute_rpcapi.remove_volume_connection( context, instance, bdm.volume_id, dest) .. Actual result: def remove_volume_connection(self, context, volume_id, instance): .. .. Expected result: def remove_volume_connection(self, context, instance, volume_id): pelease check this bug , thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1505476/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1505476] Re: when live-migrate failed, remove_volume_connection function accept incorrect arguments order in kilo
** Changed in: nova Status: Invalid => New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1505476 Title: when live-migrate failed,remove_volume_connection function accept incorrect arguments order in kilo Status in OpenStack Compute (nova): New Bug description: Openstack Version : kilo 2015.1.0 Reproduce steps: please see the paths of codes:openstack/nova/nova/compute/manager.py def _rollback_live_migration(self, context, instance,dest, block_migration, migrate_data=None): .. for bdm in bdms: if bdm.is_volume: self.compute_rpcapi.remove_volume_connection( context, instance, bdm.volume_id, dest) .. Actual result: def remove_volume_connection(self, context, volume_id, instance): .. .. Expected result: def remove_volume_connection(self, context, instance, volume_id): pelease check this bug , thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1505476/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1505476] Re: when live-migrate failed, remove_volume_connection function accept incorrect arguments order in kilo
@jingtao liang: Because the RPC API calls the "remove_volume_connection" method of the manager with named arguments, the order of the arguments is not important. The flow is this: nova/compute/manager.py (on the source host) def _rollback_live_migration(self, context, instance, dest, block_migration, migrate_data=None): # [...] self.compute_rpcapi.remove_volume_connection( context, instance, bdm.volume_id, dest) nova/compute/rpcapi.py (on the source host) def remove_volume_connection(self, ctxt, instance, volume_id, host): version = '4.0' cctxt = self.client.prepare(server=host, version=version) return cctxt.call(ctxt, 'remove_volume_connection', instance=instance, volume_id=volume_id) nova/compute/manager.py (on the target host) def remove_volume_connection(self, context, volume_id, instance): # [...] IOW, it would be an issue if this call: return cctxt.call(ctxt, 'remove_volume_connection', instance=instance, volume_id=volume_id) would look like this: return cctxt.call(ctxt, 'remove_volume_connection', instance, volume_id) but it does not, which means we are fine. Because of this, I'll put the status of this bug to "Invalid". If you disagree with it, please set it back to "new" and add a reasoning why you think this is a valid failure in the behavior of Nova. ** Changed in: nova Status: New => Invalid ** Changed in: nova Assignee: Nimish Joshi (jnimish77) => (unassigned) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1505476 Title: when live-migrate failed,remove_volume_connection function accept incorrect arguments order in kilo Status in OpenStack Compute (nova): Invalid Bug description: Openstack Version : kilo 2015.1.0 Reproduce steps: please see the paths of codes:openstack/nova/nova/compute/manager.py def _rollback_live_migration(self, context, instance,dest, block_migration, migrate_data=None): .. for bdm in bdms: if bdm.is_volume: self.compute_rpcapi.remove_volume_connection( context, instance, bdm.volume_id, dest) .. Actual result: def remove_volume_connection(self, context, volume_id, instance): .. .. Expected result: def remove_volume_connection(self, context, instance, volume_id): pelease check this bug , thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1505476/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp