[Yahoo-eng-team] [Bug 1542819] Re: The details of security group contains "null"
@libosvar, thanks for pointing out. I just checked the code of
neutronclient, and I found that the "any" in the output "neutron
security-group-rule-show" is not a simple convert from null to "any".
So, we can't simply change all null to "any" in [2]. For example, when
remote-ip-prefix is null and remote-group-id is not null, the output
will like the following after convert.
{
"remote_group_id": "1c3ec647-7377-43c8-a046-4303b8d2b521",
"remote_ip_prefix": "any",
}
I think the result is more confusing. So, I will close this bug as
invalid.
[2] http://paste.openstack.org/show/488142/
** Changed in: neutron
Status: Triaged => Invalid
** Project changed: neutron => python-neutronclient
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1542819
Title:
The details of security group contains "null"
Status in python-neutronclient:
Invalid
Bug description:
When using security group, I found the some output of security group will be
"null". This happens when the value is not specified.
Under the same condition, "neutron security-group-rule-list" will report
"any". However, "neutron security-group-rule-show" will report empty.
The details can be found at [1].
I think, if the value it not specified for a security group rule, we
could show "any" to user. This will make the output be consistent, and
the more easily to understand.
[1] http://paste.openstack.org/show/486190/
To manage notifications about this bug go to:
https://bugs.launchpad.net/python-neutronclient/+bug/1542819/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1542819] Re: The details of security group contains "null"
>From the output [2], it should be a neutron issue, instead of neutronclient. [2] http://paste.openstack.org/show/488142/ ** Project changed: python-neutronclient => neutron -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1542819 Title: The details of security group contains "null" Status in neutron: Triaged Bug description: When using security group, I found the some output of security group will be "null". This happens when the value is not specified. Under the same condition, "neutron security-group-rule-list" will report "any". However, "neutron security-group-rule-show" will report empty. The details can be found at [1]. I think, if the value it not specified for a security group rule, we could show "any" to user. This will make the output be consistent, and the more easily to understand. [1] http://paste.openstack.org/show/486190/ To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1542819/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1542819] Re: The details of security group contains "null"
** Project changed: neutron => python-neutronclient ** Changed in: python-neutronclient Importance: Undecided => Wishlist ** Tags added: rfe ** Changed in: python-neutronclient Status: New => Triaged -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1542819 Title: The details of security group contains "null" Status in python-neutronclient: Triaged Bug description: When using security group, I found the some output of security group will be "null". This happens when the value is not specified. Under the same condition, "neutron security-group-rule-list" will report "any". However, "neutron security-group-rule-show" will report empty. The details can be found at [1]. I think, if the value it not specified for a security group rule, we could show "any" to user. This will make the output be consistent, and the more easily to understand. [1] http://paste.openstack.org/show/486190/ To manage notifications about this bug go to: https://bugs.launchpad.net/python-neutronclient/+bug/1542819/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1542819] Re: The details of security group contains "null"
I reported this bug, because I think it will be hard for a non- programmer to understand the meaning. And the output of security-group cli are inconsistent(null, any, empty). @nate-johnston, I agree with you that hiding the null value may be in- appropriate, because it is implicit. I will update the bug to change the null/empty value to "any" to see where the discussion goes. ** Description changed: When using security group, I found the some output of security group will be "null". This happens when the value is not specified. Under the same condition, "neutron security-group-rule-list" will report "any". However, "neutron security-group-rule-show" will report empty. The details can be found at [1]. - I think, if the value it not specified for a security group rule, we can - hide it from the output of "neutron security-group-show". It is - meaningless to show a "null" to user. - + I think, if the value it not specified for a security group rule, we + could show "any" to user. This will make the output be consistent, and + the more easily to understand. [1] http://paste.openstack.org/show/486190/ ** Changed in: neutron Status: Opinion => New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1542819 Title: The details of security group contains "null" Status in neutron: New Bug description: When using security group, I found the some output of security group will be "null". This happens when the value is not specified. Under the same condition, "neutron security-group-rule-list" will report "any". However, "neutron security-group-rule-show" will report empty. The details can be found at [1]. I think, if the value it not specified for a security group rule, we could show "any" to user. This will make the output be consistent, and the more easily to understand. [1] http://paste.openstack.org/show/486190/ To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1542819/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1542819] Re: The details of security group contains "null"
I don't think that I agree with you that there is no value in showing every field, even ones where the value is 'null'. It might be meaningless to some users user, but it is more explicit. Also, ensuring that every field is represented in a predictable fashion means that the API may be easier for other services to consume. I would like to get more opinions on this; marking it as 'opinion' for now until we get a consensus. ** Changed in: neutron Status: New => Opinion ** Tags added: sg-fw -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1542819 Title: The details of security group contains "null" Status in neutron: Opinion Bug description: When using security group, I found the some output of security group will be "null". This happens when the value is not specified. Under the same condition, "neutron security-group-rule-list" will report "any". However, "neutron security-group-rule-show" will report empty. The details can be found at [1]. I think, if the value it not specified for a security group rule, we can hide it from the output of "neutron security-group-show". It is meaningless to show a "null" to user. [1] http://paste.openstack.org/show/486190/ To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1542819/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
