[Yahoo-eng-team] [Bug 1546433] Re: nova.service.Service.kill() is unused and orphaned
Reviewed: https://review.openstack.org/281835 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=487a6259f9f60bf56353f878184273242df7c01e Submitter: Jenkins Branch:master commit 487a6259f9f60bf56353f878184273242df7c01e Author: Roman DoboszDate: Thu Feb 18 09:19:21 2016 +0100 Add annotation to the kill() method Description about the kill() method with clearing up its purpose was added. Closes-Bug: #1546433 Change-Id: I8458242d22c0735faf7c95545bca6de9a03081ce ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1546433 Title: nova.service.Service.kill() is unused and orphaned Status in OpenStack Compute (nova): Fix Released Bug description: oslo.service.Service doesn't provide kill method in it's interface [1]. Nova is implementing it (it removes service record from the DB), but obviously it isn't actually ever called. This was probably orphaned long time ago (last changes in 2011). I think the method should go away. [1] https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L88-L109 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1546433/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1546433] Re: nova.service.Service.kill() is unused and orphaned
** Changed in: nova Status: Opinion => In Progress -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1546433 Title: nova.service.Service.kill() is unused and orphaned Status in OpenStack Compute (nova): In Progress Bug description: oslo.service.Service doesn't provide kill method in it's interface [1]. Nova is implementing it (it removes service record from the DB), but obviously it isn't actually ever called. This was probably orphaned long time ago (last changes in 2011). I think the method should go away. [1] https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L88-L109 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1546433/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1546433] Re: nova.service.Service.kill() is unused and orphaned
I'm not really convinced this is a bug, it's an interface we've got which is fine, even if it's only used by testing. If you want to annotate it as such, that's fine as well. ** Changed in: nova Status: In Progress => Opinion -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1546433 Title: nova.service.Service.kill() is unused and orphaned Status in OpenStack Compute (nova): Opinion Bug description: oslo.service.Service doesn't provide kill method in it's interface [1]. Nova is implementing it (it removes service record from the DB), but obviously it isn't actually ever called. This was probably orphaned long time ago (last changes in 2011). I think the method should go away. [1] https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L88-L109 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1546433/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp