[Yahoo-eng-team] [Bug 1605894] Re: some test_l3 unit test failures

2016-07-23 Thread YAMAMOTO Takashi
http://logs.openstack.org/74/334874/7/check/gate-networking-midonet-
python27/b6e71e0/testr_results.html.gz

   ERROR [root] Original exception being dropped: ['Traceback (most recent call 
last):\n', '  File "/tmp/openstack/neutron/neutron/db/l3_db.py", line 683, in 
_add_interface_by_port\nreturn self._validate_router_port_info(context, 
router, port_id)\n', '  File "/tmp/openstack/neutron/neutron/db/l3_db.py", line 
664, in _validate_router_port_info\nsubnets)\n', '  File 
"/tmp/openstack/neutron/neutron/db/l3_db.py", line 576, in 
_check_for_dup_router_subnets\nraise n_exc.BadRequest(resource=\'router\', 
msg=msg)\n', 'BadRequest: Bad router request: Router already has a port on 
subnet 876deb79-9cdc-47fe-90aa-d607b400294f.\n']
   ERROR [neutron.api.v2.resource] add_router_interface failed: No details.
Traceback (most recent call last):
  File "/tmp/openstack/neutron/neutron/api/v2/resource.py", line 79, in resource
result = method(request=request, **args)
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py",
 line 151, in wrapper
ectxt.value = e.inner_exc
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py",
 line 220, in __exit__
self.force_reraise()
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py",
 line 196, in force_reraise
six.reraise(self.type_, self.value, self.tb)
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py",
 line 139, in wrapper
return f(*args, **kwargs)
  File "/tmp/openstack/neutron/neutron/api/v2/base.py", line 217, in 
_handle_action
ret_value = getattr(self._plugin, name)(*arg_list, **kwargs)
  File "midonet/neutron/plugin_v1.py", line 388, in add_router_interface
context, router_id, interface_info)
  File "/tmp/openstack/neutron/neutron/db/l3_db.py", line 1707, in 
add_router_interface
context, router_id, interface_info)
  File "/tmp/openstack/neutron/neutron/db/l3_db.py", line 763, in 
add_router_interface
context, router, interface_info['port_id'], device_owner)
  File "/tmp/openstack/neutron/neutron/db/l3_db.py", line 688, in 
_add_interface_by_port
'device_owner': prev_owner}})
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py",
 line 1062, in __call__
return _mock_self._mock_call(*args, **kwargs)
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py",
 line 1128, in _mock_call
ret_val = effect(*args, **kwargs)
  File "midonet/neutron/plugin_v1.py", line 270, in update_port
context.session.begin(subtransactions=True):
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/orm/session.py",
 line 725, in begin
nested=nested)
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/orm/session.py",
 line 235, in _begin
self._assert_active()
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/orm/session.py",
 line 218, in _assert_active
"This Session's transaction has been rolled back "
InvalidRequestError: This Session's transaction has been rolled back by a 
nested rollback() call.  To begin a new transaction, issue Session.rollback() 
first.
}}}

Traceback (most recent call last):
  File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 
1425, in test_router_add_interface_dup_subnet2_returns_400
expected_code=exc.HTTPBadRequest.code)
  File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 
403, in _router_interface_action
self.assertEqual(expected_code, res.status_int, msg)
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 411, in assertEqual
self.assertThat(observed, matcher, message)
  File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 498, in assertThat
raise mismatch_error
testtools.matchers._impl.MismatchError: 400 != 500


** Also affects: neutron
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1605894

Title:
  some test_l3 unit test failures

Status in networking-midonet:
  New
Status in neutron:
  New

Bug description:
  networking-midonet gate fails due to recent l3_db change. [1]
  any plugins which have a surrounding transaction for add_router_interface
  would be

[Yahoo-eng-team] [Bug 1605894] Re: some test_l3 unit test failures

2016-07-25 Thread OpenStack Infra
Reviewed:  https://review.openstack.org/346585
Committed: 
https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=0fa57a25a683bb1c85a839dba4bb253aa9551ad0
Submitter: Jenkins
Branch:master

commit 0fa57a25a683bb1c85a839dba4bb253aa9551ad0
Author: YAMAMOTO Takashi 
Date:   Mon Jul 25 13:37:29 2016 +0900

l3: Avoid breaking transaction in _validate_router_port_info

The recent Neutron change [1] broke plugins which have a surrounding
transaction for the method.  This commit workarounds the breakage by
avoid breaking the whole transaction in _validate_router_port_info.

[1] I797df266dafc41843408dc95a6ce9f986db5c21c

Closes-Bug: #1605894
Change-Id: Ib2fff32642013af2523b159a48c7e2bc8c854131


** Changed in: networking-midonet
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1605894

Title:
  some test_l3 unit test failures

Status in networking-midonet:
  Fix Released
Status in neutron:
  In Progress

Bug description:
  networking-midonet gate fails due to recent l3_db change. [1]
  any plugins which have a surrounding transaction for add_router_interface
  would be affected in the same way.

  [1] I797df266dafc41843408dc95a6ce9f986db5c21c

  http://logs.openstack.org/00/344100/2/check/gate-networking-midonet-
  python27/f55680d/console.html

  2016-07-23 10:56:05.220890 | 
==
  2016-07-23 10:56:05.220921 | FAIL: 
midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_dup_subnet2_returns_400
  2016-07-23 10:56:05.220941 | 
--
  2016-07-23 10:56:05.220953 | Traceback (most recent call last):
  2016-07-23 10:56:05.220984 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1425, 
in test_router_add_interface_dup_subnet2_returns_400
  2016-07-23 10:56:05.221003 | expected_code=exc.HTTPBadRequest.code)
  2016-07-23 10:56:05.221029 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in 
_router_interface_action
  2016-07-23 10:56:05.221046 | self.assertEqual(expected_code, 
res.status_int, msg)
  2016-07-23 10:56:05.221081 |   File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 411, in assertEqual
  2016-07-23 10:56:05.221101 | self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.221136 |   File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 498, in assertThat
  2016-07-23 10:56:05.221146 | raise mismatch_error
  2016-07-23 10:56:05.221160 | testtools.matchers._impl.MismatchError: 400 != 
500
  2016-07-23 10:56:05.221178 | 
==
  2016-07-23 10:56:05.221211 | FAIL: 
midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_ipv6_port_existing_network_returns_400
  2016-07-23 10:56:05.221235 | 
--
  2016-07-23 10:56:05.221247 | Traceback (most recent call last):
  2016-07-23 10:56:05.221281 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1316, 
in test_router_add_interface_ipv6_port_existing_network_returns_400
  2016-07-23 10:56:05.221297 | expected_code=exp_code)
  2016-07-23 10:56:05.221324 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in 
_router_interface_action
  2016-07-23 10:56:05.221349 | self.assertEqual(expected_code, 
res.status_int, msg)
  2016-07-23 10:56:05.221386 |   File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 411, in assertEqual
  2016-07-23 10:56:05.221400 | self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.221435 |   File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 498, in assertThat
  2016-07-23 10:56:05.221445 | raise mismatch_error
  2016-07-23 10:56:05.221459 | testtools.matchers._impl.MismatchError: 400 != 
500
  2016-07-23 10:56:05.221477 | 
==
  2016-07-23 10:56:05.221509 | FAIL: 
midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_multiple_ipv4_subnet_port_returns_400
  2016-07-23 10:56:05.221528 | 
--
  2016-07-23 10:56:05.221540 | Traceback (most recent call last):
  2016-07-23 10:56:05.221574 |   File 
"/tmp/ope

[Yahoo-eng-team] [Bug 1605894] Re: some test_l3 unit test failures

2016-08-09 Thread OpenStack Infra
Reviewed:  https://review.openstack.org/346954
Committed: 
https://git.openstack.org/cgit/openstack/neutron/commit/?id=22a341a204e84b83094899730602975baa469af9
Submitter: Jenkins
Branch:master

commit 22a341a204e84b83094899730602975baa469af9
Author: Sreekumar S 
Date:   Mon Jul 25 22:43:24 2016 +0530

Fixes the midonet test_l3 unit test failures

Failures for midonet unit tests seems to be caused due
to nested rollback.
Referred https://review.openstack.org/#/c/230481/
for this fix.

Change-Id: Ic6b37bf3f799055c93e9eeb9b7f51758ceecbeb5
Closes-Bug: #1605894
Related-Bug: #1501686


** Changed in: neutron
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1605894

Title:
  some test_l3 unit test failures

Status in networking-midonet:
  Fix Released
Status in neutron:
  Fix Released

Bug description:
  networking-midonet gate fails due to recent l3_db change. [1]
  any plugins which have a surrounding transaction for add_router_interface
  would be affected in the same way.

  [1] I797df266dafc41843408dc95a6ce9f986db5c21c

  http://logs.openstack.org/00/344100/2/check/gate-networking-midonet-
  python27/f55680d/console.html

  2016-07-23 10:56:05.220890 | 
==
  2016-07-23 10:56:05.220921 | FAIL: 
midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_dup_subnet2_returns_400
  2016-07-23 10:56:05.220941 | 
--
  2016-07-23 10:56:05.220953 | Traceback (most recent call last):
  2016-07-23 10:56:05.220984 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1425, 
in test_router_add_interface_dup_subnet2_returns_400
  2016-07-23 10:56:05.221003 | expected_code=exc.HTTPBadRequest.code)
  2016-07-23 10:56:05.221029 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in 
_router_interface_action
  2016-07-23 10:56:05.221046 | self.assertEqual(expected_code, 
res.status_int, msg)
  2016-07-23 10:56:05.221081 |   File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 411, in assertEqual
  2016-07-23 10:56:05.221101 | self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.221136 |   File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 498, in assertThat
  2016-07-23 10:56:05.221146 | raise mismatch_error
  2016-07-23 10:56:05.221160 | testtools.matchers._impl.MismatchError: 400 != 
500
  2016-07-23 10:56:05.221178 | 
==
  2016-07-23 10:56:05.221211 | FAIL: 
midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_ipv6_port_existing_network_returns_400
  2016-07-23 10:56:05.221235 | 
--
  2016-07-23 10:56:05.221247 | Traceback (most recent call last):
  2016-07-23 10:56:05.221281 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1316, 
in test_router_add_interface_ipv6_port_existing_network_returns_400
  2016-07-23 10:56:05.221297 | expected_code=exp_code)
  2016-07-23 10:56:05.221324 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in 
_router_interface_action
  2016-07-23 10:56:05.221349 | self.assertEqual(expected_code, 
res.status_int, msg)
  2016-07-23 10:56:05.221386 |   File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 411, in assertEqual
  2016-07-23 10:56:05.221400 | self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.221435 |   File 
"/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py",
 line 498, in assertThat
  2016-07-23 10:56:05.221445 | raise mismatch_error
  2016-07-23 10:56:05.221459 | testtools.matchers._impl.MismatchError: 400 != 
500
  2016-07-23 10:56:05.221477 | 
==
  2016-07-23 10:56:05.221509 | FAIL: 
midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_multiple_ipv4_subnet_port_returns_400
  2016-07-23 10:56:05.221528 | 
--
  2016-07-23 10:56:05.221540 | Traceback (most recent call last):
  2016-07-23 10:56:05.221574 |   File 
"/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1287, 
in test_router_add_interface_multiple_ipv4_subnet_port_returns_4