Reviewed: https://review.openstack.org/407058 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3ee76d4980b81354ff19da24de1a0c6e4b67903c Submitter: Jenkins Branch: master
commit 3ee76d4980b81354ff19da24de1a0c6e4b67903c Author: Artur Korzeniewski <artur.korzeniew...@intel.com> Date: Tue Dec 6 14:28:38 2016 +0100 Convert filters to empty dict if None in DB's get_subnetpools(). When calling ML2 plugin's get_subnetpools(), 'fields' parameters may be passed. By default it is set to None. The 'filters' is passed to SubnetPool.get_objects() as kwargs (using **). If someone calls plugin's get_subnetpools() without passing filters, the method will raise exception. This patch is adding support for 'filters' being None when calling plugin get_subnetpools(), by converting it to be empty dict '{}'. Change-Id: Ic7432cb167583e82b3c0e237ef25a5c9f21986e6 Closes-Bug: 1647715 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1647715 Title: get_subnetpool() raise error when called with unset filters Status in neutron: Fix Released Bug description: get_subnetpools() from db_base_plugin_v2 is raising error when called with unset filters argument. This is because filters are by default set to None and when calling OVO, the filters are passed as kwargs using '**': https://github.com/openstack/neutron/blob/10.0.0.0b1/neutron/db/db_base_plugin_v2.py#L1087 It is only issue when calling directly using plugin. Unit tests were not covering it. API is tested and okay. This is also affecting Newton. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1647715/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp