Reviewed: https://review.openstack.org/420187 Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=ee2747bac2e6eeb86e6340a2bb3509bc25f115bc Submitter: Jenkins Branch: master
commit ee2747bac2e6eeb86e6340a2bb3509bc25f115bc Author: Gage Hugo <gageh...@gmail.com> Date: Fri Jan 13 15:34:59 2017 -0600 Corrected punctuation on multiple exceptions As mentioned in the bug report, keystone/exceptions.py has many exceptions with messages that are not consistant with each other and have various punctuational differences, such as some ending with a period while others do not. This change adds a '.' to the end of many exception messages and adds small changes to other messages in order to keep all of the exception messages consistant. Change-Id: I21cac56ff70dbc2693c6090b887537a7c1f303e1 Closes-Bug: #1656026 ** Changed in: keystone Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1656026 Title: Exception don't follow a punctuation convention Status in OpenStack Identity (keystone): Fix Released Bug description: If you happen to take a look through keystone exception module [0]. You'll notice that some of the exceptions use proper punctuation, while other do not. David Stanek mentioned this in a review [1], and we thought it was appropriate to track it as a low-hanging-fruit bug. We should decide what that convention should be for keystone, then apply it to all of our exceptions consistently. [0] https://github.com/openstack/keystone/blob/f8ee249bf08cefd8468aa15c589dab48bd5c4cd8/keystone/exception.py#L105-L118 [1] https://review.openstack.org/#/c/415895/8/keystone/exception.py To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1656026/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp