[Yahoo-eng-team] [Bug 1746202] Re: Invalid query parameter could lead to HTTP 500

2018-01-30 Thread Zhenyu Zheng
** Also affects: cinder
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1746202

Title:
  Invalid query parameter could lead to HTTP 500

Status in Cinder:
  New
Status in OpenStack Compute (nova):
  In Progress

Bug description:
  Invalid query parameter could lead to HTTP 500, although Nova used JSON 
Schema verification
  to check input query params, but query like:
  GET /servers?limit=%88 will still lead to HTTP 500, as it failed to parse at 
webob which is
  pre JSON Schema check.

  GET http://10.76.150.18/compute/v2.1/servers/detail?limit=%88

  Response:

  {
  "computeFault": {
  "message": "Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n",
  "code": 500
  }
  }

  Traceback:

  DEBUG nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] Calling method 'http://bugs.launchpad.net/nova/ and attach the Nova API lo
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: 
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: DEBUG 
nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d admin 
admin] Returning 500 to user: Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API l
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]:  {{(pid=4377) __call__ 
/opt/stack/nova/nova/api/openstack/wsgi.py:1079}}
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: INFO 
nova.api.openstack.requestlog [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] 10.8.4.18 "GET /compute/v2.1/servers/detail?limit=%89" status: 500 
len: 202 microversion: 2.49 time: 0.531050

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1746202/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1746202] Re: Invalid query parameter could lead to HTTP 500

2018-01-30 Thread zhongjun
** Also affects: manila
   Importance: Undecided
   Status: New

** Changed in: manila
 Assignee: (unassigned) => zhongjun (jun-zhongjun)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1746202

Title:
  Invalid query parameter could lead to HTTP 500

Status in Cinder:
  In Progress
Status in Manila:
  New
Status in OpenStack Compute (nova):
  In Progress

Bug description:
  Invalid query parameter could lead to HTTP 500, although Nova used JSON 
Schema verification
  to check input query params, but query like:
  GET /servers?limit=%88 will still lead to HTTP 500, as it failed to parse at 
webob which is
  pre JSON Schema check.

  GET http://10.76.150.18/compute/v2.1/servers/detail?limit=%88

  Response:

  {
  "computeFault": {
  "message": "Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n",
  "code": 500
  }
  }

  Traceback:

  DEBUG nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] Calling method 'http://bugs.launchpad.net/nova/ and attach the Nova API lo
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: 
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: DEBUG 
nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d admin 
admin] Returning 500 to user: Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API l
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]:  {{(pid=4377) __call__ 
/opt/stack/nova/nova/api/openstack/wsgi.py:1079}}
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: INFO 
nova.api.openstack.requestlog [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] 10.8.4.18 "GET /compute/v2.1/servers/detail?limit=%89" status: 500 
len: 202 microversion: 2.49 time: 0.531050

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1746202/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1746202] Re: Invalid query parameter could lead to HTTP 500

2018-02-07 Thread OpenStack Infra
Reviewed:  https://review.openstack.org/539406
Committed: 
https://git.openstack.org/cgit/openstack/manila/commit/?id=bf1998898453f208882a95bf88cd157274e7dbf1
Submitter: Zuul
Branch:master

commit bf1998898453f208882a95bf88cd157274e7dbf1
Author: zhongjun 
Date:   Wed Jan 31 11:02:44 2018 +0800

Fix UnicodeDecodeError when decode API input

Convert UnicodeDecodeError to HTTPBadRequest in
FaultWrapper.

Change-Id: I826f05084b0a0ef170ef293d382868409b96ed3d
Closes-Bug: #1746202


** Changed in: manila
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1746202

Title:
  Invalid query parameter could lead to HTTP 500

Status in Cinder:
  In Progress
Status in Manila:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress

Bug description:
  Invalid query parameter could lead to HTTP 500, although Nova used JSON 
Schema verification
  to check input query params, but query like:
  GET /servers?limit=%88 will still lead to HTTP 500, as it failed to parse at 
webob which is
  pre JSON Schema check.

  GET http://10.76.150.18/compute/v2.1/servers/detail?limit=%88

  Response:

  {
  "computeFault": {
  "message": "Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n",
  "code": 500
  }
  }

  Traceback:

  DEBUG nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] Calling method 'http://bugs.launchpad.net/nova/ and attach the Nova API lo
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: 
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: DEBUG 
nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d admin 
admin] Returning 500 to user: Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API l
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]:  {{(pid=4377) __call__ 
/opt/stack/nova/nova/api/openstack/wsgi.py:1079}}
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: INFO 
nova.api.openstack.requestlog [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] 10.8.4.18 "GET /compute/v2.1/servers/detail?limit=%89" status: 500 
len: 202 microversion: 2.49 time: 0.531050

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1746202/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1746202] Re: Invalid query parameter could lead to HTTP 500

2018-02-07 Thread OpenStack Infra
Reviewed:  https://review.openstack.org/539387
Committed: 
https://git.openstack.org/cgit/openstack/cinder/commit/?id=0e2193982ab1e4941ed82c3785e306eb8e4e46ec
Submitter: Zuul
Branch:master

commit 0e2193982ab1e4941ed82c3785e306eb8e4e46ec
Author: TommyLike 
Date:   Wed Jan 31 09:41:13 2018 +0800

Fix UnicodeDecodeError when decode API input

Convert UnicodeDecodeError to HTTPBadRequest in
FaultWrapper.

**NOTE**: Cinder will raise 500 error when failed to decode invalid
unicode character at anyplace where try to collect url
parematers as below:

```
params = req.params
```

This patch converts this kind of exception into BadRequest, plus
an explicit error message.

Change-Id: I816f05084b0a0ef670ef293d381868409b96ed7d
Closes-Bug: #1746202


** Changed in: cinder
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1746202

Title:
  Invalid query parameter could lead to HTTP 500

Status in Cinder:
  Fix Released
Status in Manila:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress

Bug description:
  Invalid query parameter could lead to HTTP 500, although Nova used JSON 
Schema verification
  to check input query params, but query like:
  GET /servers?limit=%88 will still lead to HTTP 500, as it failed to parse at 
webob which is
  pre JSON Schema check.

  GET http://10.76.150.18/compute/v2.1/servers/detail?limit=%88

  Response:

  {
  "computeFault": {
  "message": "Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n",
  "code": 500
  }
  }

  Traceback:

  DEBUG nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] Calling method 'http://bugs.launchpad.net/nova/ and attach the Nova API lo
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: 
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: DEBUG 
nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d admin 
admin] Returning 500 to user: Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API l
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]:  {{(pid=4377) __call__ 
/opt/stack/nova/nova/api/openstack/wsgi.py:1079}}
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: INFO 
nova.api.openstack.requestlog [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] 10.8.4.18 "GET /compute/v2.1/servers/detail?limit=%89" status: 500 
len: 202 microversion: 2.49 time: 0.531050

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1746202/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1746202] Re: Invalid query parameter could lead to HTTP 500

2018-08-07 Thread Matt Riedemann
Looks like this is fixed for nova as of
https://review.openstack.org/#/c/539164/

** Tags added: api

** Changed in: nova
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1746202

Title:
  Invalid query parameter could lead to HTTP 500

Status in Cinder:
  Fix Released
Status in Manila:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Invalid query parameter could lead to HTTP 500, although Nova used JSON 
Schema verification
  to check input query params, but query like:
  GET /servers?limit=%88 will still lead to HTTP 500, as it failed to parse at 
webob which is
  pre JSON Schema check.

  GET http://10.76.150.18/compute/v2.1/servers/detail?limit=%88

  Response:

  {
  "computeFault": {
  "message": "Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n",
  "code": 500
  }
  }

  Traceback:

  DEBUG nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] Calling method 'http://bugs.launchpad.net/nova/ and attach the Nova API lo
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: 
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: DEBUG 
nova.api.openstack.wsgi [None req-ee355759-13c3-4f63-a41f-920d7385878d admin 
admin] Returning 500 to user: Unexpected API Error. Please report this at 
http://bugs.launchpad.net/nova/ and attach the Nova API l
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]:  {{(pid=4377) __call__ 
/opt/stack/nova/nova/api/openstack/wsgi.py:1079}}
  Jan 30 17:46:56 kevin-dev devstack@n-api.service[4374]: INFO 
nova.api.openstack.requestlog [None req-ee355759-13c3-4f63-a41f-920d7385878d 
admin admin] 10.8.4.18 "GET /compute/v2.1/servers/detail?limit=%89" status: 500 
len: 202 microversion: 2.49 time: 0.531050

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1746202/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp