[Yahoo-eng-team] [Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
This bug was fixed in the package horizon - 3:18.3.5-0ubuntu2.2~cloud0 --- horizon (3:18.3.5-0ubuntu2.2~cloud0) bionic-ussuri; urgency=medium . * New update for the Ubuntu Cloud Archive. . horizon (3:18.3.5-0ubuntu2.2) focal; urgency=medium . * d/p/get-ports-directly.patch: Get ports directly instead of via loop (LP: #1943639). ** Changed in: cloud-archive/ussuri Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1943639 Title: project/instances/attach_interface has O(N) scaling time complexity for opening form Status in Ubuntu Cloud Archive: Fix Released Status in Ubuntu Cloud Archive ussuri series: Fix Released Status in Ubuntu Cloud Archive victoria series: Fix Released Status in Ubuntu Cloud Archive wallaby series: Fix Released Status in Ubuntu Cloud Archive xena series: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in horizon package in Ubuntu: Fix Released Status in horizon source package in Focal: Fix Released Bug description: [ Impact ] The time complexity of opening the project/instances/attach_interface form box is O(N) where N is the number of networks in the project with a large prefactor. This is due to https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210 Which loops over the networks and requests the ports associated with the network. For large projects this scaling behavior can become prohibitive. The patch [1] addresses this issue by reducing the number of API calls and hence the prefactor of the algorithm. [ Test Plan ] In order to reproduce the issue, create a Nova VM and then add many networks. On the instances tab in the Horizon UI click on "attach interface" for the VM. It will take a moment for the dialog to appear. The exact time until the dialog appears will depend on the number of networks linearly. With [1] the time it takes for the dialog box to appear will be significantly shorter. [ Where problems could occur ] The patch [1] affects the "attach interface" dialog box and could break this UI feature in case something was wrong with the implementation. It is also possible that due to a bug in the implementation some networks are missing from the dialog. [1] https://review.opendev.org/c/openstack/horizon/+/866895 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
This bug was fixed in the package horizon - 4:19.4.0-0ubuntu1~cloud2 --- horizon (4:19.4.0-0ubuntu1~cloud2) focal-wallaby; urgency=medium . * d/p/get-ports-directly.patch: Get ports directly instead of via loop (LP: #1943639). ** Changed in: cloud-archive/wallaby Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1943639 Title: project/instances/attach_interface has O(N) scaling time complexity for opening form Status in Ubuntu Cloud Archive: Fix Released Status in Ubuntu Cloud Archive ussuri series: Fix Committed Status in Ubuntu Cloud Archive victoria series: Fix Released Status in Ubuntu Cloud Archive wallaby series: Fix Released Status in Ubuntu Cloud Archive xena series: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in horizon package in Ubuntu: Fix Released Status in horizon source package in Focal: Fix Released Bug description: [ Impact ] The time complexity of opening the project/instances/attach_interface form box is O(N) where N is the number of networks in the project with a large prefactor. This is due to https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210 Which loops over the networks and requests the ports associated with the network. For large projects this scaling behavior can become prohibitive. The patch [1] addresses this issue by reducing the number of API calls and hence the prefactor of the algorithm. [ Test Plan ] In order to reproduce the issue, create a Nova VM and then add many networks. On the instances tab in the Horizon UI click on "attach interface" for the VM. It will take a moment for the dialog to appear. The exact time until the dialog appears will depend on the number of networks linearly. With [1] the time it takes for the dialog box to appear will be significantly shorter. [ Where problems could occur ] The patch [1] affects the "attach interface" dialog box and could break this UI feature in case something was wrong with the implementation. It is also possible that due to a bug in the implementation some networks are missing from the dialog. [1] https://review.opendev.org/c/openstack/horizon/+/866895 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
This bug was fixed in the package horizon - 4:18.6.4-0ubuntu1~cloud2 --- horizon (4:18.6.4-0ubuntu1~cloud2) focal-victoria; urgency=medium . * d/p/get-ports-directly.patch: Get ports directly instead of via loop (LP: #1943639). ** Changed in: cloud-archive/victoria Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1943639 Title: project/instances/attach_interface has O(N) scaling time complexity for opening form Status in Ubuntu Cloud Archive: Fix Released Status in Ubuntu Cloud Archive ussuri series: Fix Committed Status in Ubuntu Cloud Archive victoria series: Fix Released Status in Ubuntu Cloud Archive wallaby series: Fix Released Status in Ubuntu Cloud Archive xena series: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in horizon package in Ubuntu: Fix Released Status in horizon source package in Focal: Fix Released Bug description: [ Impact ] The time complexity of opening the project/instances/attach_interface form box is O(N) where N is the number of networks in the project with a large prefactor. This is due to https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210 Which loops over the networks and requests the ports associated with the network. For large projects this scaling behavior can become prohibitive. The patch [1] addresses this issue by reducing the number of API calls and hence the prefactor of the algorithm. [ Test Plan ] In order to reproduce the issue, create a Nova VM and then add many networks. On the instances tab in the Horizon UI click on "attach interface" for the VM. It will take a moment for the dialog to appear. The exact time until the dialog appears will depend on the number of networks linearly. With [1] the time it takes for the dialog box to appear will be significantly shorter. [ Where problems could occur ] The patch [1] affects the "attach interface" dialog box and could break this UI feature in case something was wrong with the implementation. It is also possible that due to a bug in the implementation some networks are missing from the dialog. [1] https://review.opendev.org/c/openstack/horizon/+/866895 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
This bug was fixed in the package horizon - 3:18.3.5-0ubuntu2.2 --- horizon (3:18.3.5-0ubuntu2.2) focal; urgency=medium * d/p/get-ports-directly.patch: Get ports directly instead of via loop (LP: #1943639). -- Nicolas Bock Tue, 22 Aug 2023 20:58:11 + ** Changed in: horizon (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1943639 Title: project/instances/attach_interface has O(N) scaling time complexity for opening form Status in Ubuntu Cloud Archive: Fix Released Status in Ubuntu Cloud Archive ussuri series: Fix Committed Status in Ubuntu Cloud Archive victoria series: Fix Committed Status in Ubuntu Cloud Archive wallaby series: Fix Committed Status in Ubuntu Cloud Archive xena series: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in horizon package in Ubuntu: Fix Released Status in horizon source package in Focal: Fix Released Bug description: [ Impact ] The time complexity of opening the project/instances/attach_interface form box is O(N) where N is the number of networks in the project with a large prefactor. This is due to https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210 Which loops over the networks and requests the ports associated with the network. For large projects this scaling behavior can become prohibitive. The patch [1] addresses this issue by reducing the number of API calls and hence the prefactor of the algorithm. [ Test Plan ] In order to reproduce the issue, create a Nova VM and then add many networks. On the instances tab in the Horizon UI click on "attach interface" for the VM. It will take a moment for the dialog to appear. The exact time until the dialog appears will depend on the number of networks linearly. With [1] the time it takes for the dialog box to appear will be significantly shorter. [ Where problems could occur ] The patch [1] affects the "attach interface" dialog box and could break this UI feature in case something was wrong with the implementation. It is also possible that due to a bug in the implementation some networks are missing from the dialog. [1] https://review.opendev.org/c/openstack/horizon/+/866895 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
** Changed in: horizon (Ubuntu) Status: New => Fix Released ** Changed in: cloud-archive Status: New => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1943639 Title: project/instances/attach_interface has O(N) scaling time complexity for opening form Status in Ubuntu Cloud Archive: Fix Released Status in Ubuntu Cloud Archive ussuri series: New Status in Ubuntu Cloud Archive victoria series: New Status in Ubuntu Cloud Archive wallaby series: New Status in Ubuntu Cloud Archive xena series: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in horizon package in Ubuntu: Fix Released Status in horizon source package in Focal: New Bug description: [ Impact ] The time complexity of opening the project/instances/attach_interface form box is O(N) where N is the number of networks in the project with a large prefactor. This is due to https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210 Which loops over the networks and requests the ports associated with the network. For large projects this scaling behavior can become prohibitive. The patch [1] addresses this issue by reducing the number of API calls and hence the prefactor of the algorithm. [ Test Plan ] In order to reproduce the issue, create a Nova VM and then add many networks. On the instances tab in the Horizon UI click on "attach interface" for the VM. It will take a moment for the dialog to appear. The exact time until the dialog appears will depend on the number of networks linearly. With [1] the time it takes for the dialog box to appear will be significantly shorter. [ Where problems could occur ] The patch [1] affects the "attach interface" dialog box and could break this UI feature in case something was wrong with the implementation. It is also possible that due to a bug in the implementation some networks are missing from the dialog. [1] https://review.opendev.org/c/openstack/horizon/+/866895 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
This patch was merged to master during the Yoga development cycle and is available in the following point releases upstream: (yoga) 22.0.0 (xena) 20.1.3 The Ubuntu archives currently have the following versions: Yoga - 4:22.1.0-0ubuntu2.1~cloud0 Xena - 4:20.1.4-0ubuntu1~cloud1 Wallaby - 4:19.4.0-0ubuntu1~cloud1 Victoria - 4:18.6.4-0ubuntu1~cloud1 Ussuri - 3:18.3.5-0ubuntu2.1 So to get this patch backported to Ussuri, it first needs to be SRUd to Wallaby and Victoria UCA. ** Also affects: cloud-archive/xena Importance: Undecided Status: New ** Also affects: cloud-archive/victoria Importance: Undecided Status: New ** Also affects: cloud-archive/wallaby Importance: Undecided Status: New ** Changed in: cloud-archive/xena Status: New => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1943639 Title: project/instances/attach_interface has O(N) scaling time complexity for opening form Status in Ubuntu Cloud Archive: New Status in Ubuntu Cloud Archive ussuri series: New Status in Ubuntu Cloud Archive victoria series: New Status in Ubuntu Cloud Archive wallaby series: New Status in Ubuntu Cloud Archive xena series: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in horizon package in Ubuntu: New Status in horizon source package in Focal: New Bug description: [ Impact ] The time complexity of opening the project/instances/attach_interface form box is O(N) where N is the number of networks in the project with a large prefactor. This is due to https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210 Which loops over the networks and requests the ports associated with the network. For large projects this scaling behavior can become prohibitive. The patch [1] addresses this issue by reducing the number of API calls and hence the prefactor of the algorithm. [ Test Plan ] In order to reproduce the issue, create a Nova VM and then add many networks. On the instances tab in the Horizon UI click on "attach interface" for the VM. It will take a moment for the dialog to appear. The exact time until the dialog appears will depend on the number of networks linearly. With [1] the time it takes for the dialog box to appear will be significantly shorter. [ Where problems could occur ] The patch [1] affects the "attach interface" dialog box and could break this UI feature in case something was wrong with the implementation. It is also possible that due to a bug in the implementation some networks are missing from the dialog. [1] https://review.opendev.org/c/openstack/horizon/+/866895 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
** Also affects: cloud-archive Importance: Undecided Status: New ** Also affects: cloud-archive/ussuri Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1943639 Title: project/instances/attach_interface has O(N) scaling time complexity for opening form Status in Ubuntu Cloud Archive: New Status in Ubuntu Cloud Archive ussuri series: New Status in OpenStack Dashboard (Horizon): Fix Released Status in horizon package in Ubuntu: New Status in horizon source package in Focal: New Bug description: [ Impact ] The time complexity of opening the project/instances/attach_interface form box is O(N) where N is the number of networks in the project with a large prefactor. This is due to https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210 Which loops over the networks and requests the ports associated with the network. For large projects this scaling behavior can become prohibitive. The patch [1] addresses this issue by reducing the number of API calls and hence the prefactor of the algorithm. [ Test Plan ] In order to reproduce the issue, create a Nova VM and then add many networks. On the instances tab in the Horizon UI click on "attach interface" for the VM. It will take a moment for the dialog to appear. The exact time until the dialog appears will depend on the number of networks linearly. With [1] the time it takes for the dialog box to appear will be significantly shorter. [ Where problems could occur ] The patch [1] affects the "attach interface" dialog box and could break this UI feature in case something was wrong with the implementation. It is also possible that due to a bug in the implementation some networks are missing from the dialog. [1] https://review.opendev.org/c/openstack/horizon/+/866895 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
Reviewed: https://review.opendev.org/c/openstack/horizon/+/809230 Committed: https://opendev.org/openstack/horizon/commit/9f5d659d160d24d359992dda22fecb0db6b6f805 Submitter: "Zuul (22348)" Branch:master commit 9f5d659d160d24d359992dda22fecb0db6b6f805 Author: Nicolas Bock Date: Wed Sep 15 09:39:31 2021 -0600 Get ports directly instead of via loop In order to get a list of available ports, the current implementation of the form code in `project/instances/attach_interface` loops through the available networks in the project and requests a list of ports for each via the Neutron API. This implementation is O(N) in time with a large prefactor (the time for a Neutron API call) where N is the number of networks. Instead of calling the Neutron API for each network this change uses one call to the Neutron API to get the list of ports on all networks and filters this list via a list comprehension. While this implementation is still O(N) the prefactor is significantly smaller. Closes-Bug: #1943639 Change-Id: I8fd32c3aad22d8ef7f57201f5144f6b2e357ef10 Signed-off-by: Nicolas Bock ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1943639 Title: project/instances/attach_interface has O(N) scaling time complexity for opening form Status in OpenStack Dashboard (Horizon): Fix Released Bug description: The time complexity of opening the project/instances/attach_interface form box is O(N) where N is the number of networks in the project. This is due to https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210 Which loops over the networks and requests the ports associated with the network. For large projects this scaling behavior can become prohibitive. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1943639/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
