Ahmed Hussein created YARN-10256:
------------------------------------

             Summary: Refactor 
TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic
                 Key: YARN-10256
                 URL: https://issues.apache.org/jira/browse/YARN-10256
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: Ahmed Hussein
            Assignee: Ahmed Hussein


In 3.x, 
{{TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic}}
 has redundant assertions. Since the UT throws timeout exception, 
{{GenericTestsUtils.waitFor()}} guarantees that the predicate is met 
successfully. Otherwise, the UT would throw a timeout exception.
The redundant loop causes confusion in understanding the test unit and may 
increase the possibility of failure in case the container terminates



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-dev-h...@hadoop.apache.org

Reply via email to