[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636507#comment-17636507
 ] 

ASF GitHub Bot commented on YARN-11380:
---

ayushtkn commented on code in PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#discussion_r1027665142


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/package-info.java:
##
@@ -1,4 +1,4 @@
-/*
+/**

Review Comment:
   this isn't required, it isn't a javadoc AFAIK, is it also giving failures





> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636502#comment-17636502
 ] 

ASF GitHub Bot commented on YARN-11380:
---

slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321574600

   @ayushtkn @aajisaka Can you help to review the code again? Thank you very 
much! I have fixed the java doc problem of hadoop-yarn-api module.




> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5607) Document TestContainerResourceUsage#waitForContainerCompletion

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636496#comment-17636496
 ] 

ASF GitHub Bot commented on YARN-5607:
--

K0K0V0K commented on code in PR #5119:
URL: https://github.com/apache/hadoop/pull/5119#discussion_r1027655301


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/CommonUtil.java:
##
@@ -0,0 +1,410 @@
+package org.apache.hadoop.yarn.server.resourcemanager;
+
+import org.apache.hadoop.yarn.api.records.ApplicationAttemptId;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.api.records.NodeId;
+import org.apache.hadoop.yarn.api.records.ContainerStatus;
+import org.apache.hadoop.yarn.api.records.NodeState;
+import org.apache.hadoop.yarn.server.api.protocolrecords.NMContainerStatus;
+import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMApp;
+import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppState;
+import 
org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttempt;
+import 
org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptState;
+import org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainer;
+import 
org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerState;
+import org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNode;
+import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler;
+import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplication;
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+
+public class CommonUtil {
+static final Logger LOG = LoggerFactory.getLogger(MockRM.class);
+private static final int SECOND = 1000;
+private static final int TIMEOUT_MS_FOR_ATTEMPT = 40 * SECOND;
+private static final int TIMEOUT_MS_FOR_APP_REMOVED = 40 * SECOND;
+private static final int TIMEOUT_MS_FOR_CONTAINER_AND_NODE = 20 * SECOND;
+private static final int WAIT_MS_PER_LOOP = 10;
+
+/**
+ * Wait until an application has reached a specified state.
+ * The timeout is 80 seconds.
+ *
+ * @param appId  the id of an application
+ * @param finalState the application state waited
+ * @throws InterruptedException if interrupted while waiting for the state 
transition
+ */
+public static void waitForState(MockRM rm, ApplicationId appId, RMAppState 
finalState)
+throws InterruptedException {
+rm.drainEventsImplicitly();
+RMApp app = rm.getRMContext().getRMApps().get(appId);
+Assert.assertNotNull("app shouldn't be null", app);
+final int timeoutMsecs = 80 * SECOND;
+int timeWaiting = 0;
+while (!finalState.equals(app.getState())) {
+if (timeWaiting >= timeoutMsecs) {
+break;
+}
+
+LOG.info("App : " + appId + " State is : " + app.getState() +
+" Waiting for state : " + finalState);
+Thread.sleep(WAIT_MS_PER_LOOP);
+timeWaiting += WAIT_MS_PER_LOOP;
+}
+
+LOG.info("App State is : " + app.getState());
+Assert.assertEquals("App State is not correct (timeout).", finalState,
+app.getState());
+}
+
+/**
+ * Wait until an attempt has reached a specified state.
+ * The timeout is 40 seconds.
+ *
+ * @param attemptId  the id of an attempt
+ * @param finalState the attempt state waited
+ * @throws InterruptedException if interrupted while waiting for the state 
transition
+ */
+public static void waitForState(MockRM rm, ApplicationAttemptId attemptId,
+ RMAppAttemptState finalState) throws 
InterruptedException {
+waitForState(rm, attemptId, finalState, TIMEOUT_MS_FOR_ATTEMPT);
+}
+
+/**
+ * Wait until an attempt has reached a specified state.
+ * The timeout can be specified by the parameter.
+ *
+ * @param attemptIdthe id of an attempt
+ * @param finalState   the attempt state waited
+ * @param timeoutMsecs the length of timeout in milliseconds
+ * @throws InterruptedException if interrupted while waiting for the state 
transition
+ */
+private static void waitForState(MockRM rm, ApplicationAttemptId attemptId,
+ RMAppAttemptState finalState, int timeoutMsecs)
+throws InterruptedException {
+rm.start();
+rm.drainEventsImplicitly();
+RMApp app = 
rm.getRMContext().getRMApps().get(attemptId.getApplicationId());
+Assert.assertNotNull("app shouldn't be null", app);
+   

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636491#comment-17636491
 ] 

ASF GitHub Bot commented on YARN-11380:
---

hadoop-yetus commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321559011

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 37s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  38m 32s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 57s |  |  trunk passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  compile  |   0m 52s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 57s |  |  trunk passed  |
   | -1 :x: |  javadoc  |   0m 57s | 
[/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/3/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt)
 |  hadoop-yarn-api in trunk failed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.  |
   | +1 :green_heart: |  javadoc  |   0m 51s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   2m 13s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 47s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 42s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 46s |  |  the patch passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javac  |   0m 46s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 44s |  |  the patch passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  javac  |   0m 44s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 20s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 
133 unchanged - 27 fixed = 133 total (was 160)  |
   | +1 :green_heart: |  mvnsite  |   0m 43s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
 with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 0 new + 0 
unchanged - 107 fixed = 0 total (was 107)  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  |  
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08
 with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08 generated 0 new + 0 
unchanged - 146 fixed = 0 total (was 146)  |
   | +1 :green_heart: |  spotbugs  |   2m  6s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  21m 49s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  8s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 43s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  98m 16s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5152 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux dfda7194caec 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 93c628570fa118cde0386e352a94a320ddde1bd2 |
   | Default Java | Private 

[jira] [Commented] (YARN-5607) Document TestContainerResourceUsage#waitForContainerCompletion

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636485#comment-17636485
 ] 

ASF GitHub Bot commented on YARN-5607:
--

susheel-gupta commented on code in PR #5119:
URL: https://github.com/apache/hadoop/pull/5119#discussion_r1027642975


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/CommonUtil.java:
##
@@ -0,0 +1,410 @@
+package org.apache.hadoop.yarn.server.resourcemanager;
+
+import org.apache.hadoop.yarn.api.records.ApplicationAttemptId;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.api.records.NodeId;
+import org.apache.hadoop.yarn.api.records.ContainerStatus;
+import org.apache.hadoop.yarn.api.records.NodeState;
+import org.apache.hadoop.yarn.server.api.protocolrecords.NMContainerStatus;
+import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMApp;
+import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppState;
+import 
org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttempt;
+import 
org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptState;
+import org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainer;
+import 
org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerState;
+import org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNode;
+import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler;
+import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplication;
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+
+public class CommonUtil {
+static final Logger LOG = LoggerFactory.getLogger(MockRM.class);
+private static final int SECOND = 1000;
+private static final int TIMEOUT_MS_FOR_ATTEMPT = 40 * SECOND;
+private static final int TIMEOUT_MS_FOR_APP_REMOVED = 40 * SECOND;
+private static final int TIMEOUT_MS_FOR_CONTAINER_AND_NODE = 20 * SECOND;
+private static final int WAIT_MS_PER_LOOP = 10;
+
+/**
+ * Wait until an application has reached a specified state.
+ * The timeout is 80 seconds.
+ *
+ * @param appId  the id of an application
+ * @param finalState the application state waited
+ * @throws InterruptedException if interrupted while waiting for the state 
transition
+ */
+public static void waitForState(MockRM rm, ApplicationId appId, RMAppState 
finalState)
+throws InterruptedException {
+rm.drainEventsImplicitly();
+RMApp app = rm.getRMContext().getRMApps().get(appId);
+Assert.assertNotNull("app shouldn't be null", app);
+final int timeoutMsecs = 80 * SECOND;
+int timeWaiting = 0;
+while (!finalState.equals(app.getState())) {
+if (timeWaiting >= timeoutMsecs) {
+break;
+}
+
+LOG.info("App : " + appId + " State is : " + app.getState() +
+" Waiting for state : " + finalState);
+Thread.sleep(WAIT_MS_PER_LOOP);
+timeWaiting += WAIT_MS_PER_LOOP;
+}
+
+LOG.info("App State is : " + app.getState());
+Assert.assertEquals("App State is not correct (timeout).", finalState,
+app.getState());
+}
+
+/**
+ * Wait until an attempt has reached a specified state.
+ * The timeout is 40 seconds.
+ *
+ * @param attemptId  the id of an attempt
+ * @param finalState the attempt state waited
+ * @throws InterruptedException if interrupted while waiting for the state 
transition
+ */
+public static void waitForState(MockRM rm, ApplicationAttemptId attemptId,
+ RMAppAttemptState finalState) throws 
InterruptedException {
+waitForState(rm, attemptId, finalState, TIMEOUT_MS_FOR_ATTEMPT);
+}
+
+/**
+ * Wait until an attempt has reached a specified state.
+ * The timeout can be specified by the parameter.
+ *
+ * @param attemptIdthe id of an attempt
+ * @param finalState   the attempt state waited
+ * @param timeoutMsecs the length of timeout in milliseconds
+ * @throws InterruptedException if interrupted while waiting for the state 
transition
+ */
+private static void waitForState(MockRM rm, ApplicationAttemptId attemptId,
+ RMAppAttemptState finalState, int timeoutMsecs)
+throws InterruptedException {
+rm.start();
+rm.drainEventsImplicitly();
+RMApp app = 
rm.getRMContext().getRMApps().get(attemptId.getApplicationId());
+Assert.assertNotNull("app shouldn't be null", app);
+ 

[jira] [Commented] (YARN-11381) Fix hadoop-yarn-common module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636466#comment-17636466
 ] 

ASF GitHub Bot commented on YARN-11381:
---

slfan1989 opened a new pull request, #5153:
URL: https://github.com/apache/hadoop/pull/5153

   JIRA: YARN-11381. Fix hadoop-yarn-common module Java Doc Errors.




> Fix hadoop-yarn-common module Java Doc Errors
> -
>
> Key: YARN-11381
> URL: https://issues.apache.org/jira/browse/YARN-11381
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>
> When finishing YARN-11373, ps  has java-doc compilation errors, I will fix 
> all java-doc compilation errors of hadoop-yarn-common module. I will pay 
> attention to the java doc compilation of jdk8 & jdk11 at the same time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-11381) Fix hadoop-yarn-common module Java Doc Errors

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/YARN-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated YARN-11381:
--
Labels: pull-request-available  (was: )

> Fix hadoop-yarn-common module Java Doc Errors
> -
>
> Key: YARN-11381
> URL: https://issues.apache.org/jira/browse/YARN-11381
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps  has java-doc compilation errors, I will fix 
> all java-doc compilation errors of hadoop-yarn-common module. I will pay 
> attention to the java doc compilation of jdk8 & jdk11 at the same time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Created] (YARN-11381) Fix hadoop-yarn-common module Java Doc Errors

[fanshilun (Jira)]

fanshilun created YARN-11381:


 Summary: Fix hadoop-yarn-common module Java Doc Errors
 Key: YARN-11381
 URL: https://issues.apache.org/jira/browse/YARN-11381
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: yarn
Affects Versions: 3.4.0
Reporter: fanshilun
Assignee: fanshilun


When finishing YARN-11373, ps  has java-doc compilation errors, I will fix all 
java-doc compilation errors of hadoop-yarn-common module. I will pay attention 
to the java doc compilation of jdk8 & jdk11 at the same time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11277) trigger deletion of log-dir by size for NonAggregatingLogHandler

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636460#comment-17636460
 ] 

ASF GitHub Bot commented on YARN-11277:
---

aajisaka commented on code in PR #4797:
URL: https://github.com/apache/hadoop/pull/4797#discussion_r1027616899


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/loghandler/NonAggregatingLogHandler.java:
##
@@ -149,47 +156,52 @@ private void recover() throws IOException {
   @Override
   public void handle(LogHandlerEvent event) {
 switch (event.getType()) {
-  case APPLICATION_STARTED:
-LogHandlerAppStartedEvent appStartedEvent =
-(LogHandlerAppStartedEvent) event;
-this.appOwners.put(appStartedEvent.getApplicationId(),
-appStartedEvent.getUser());
-this.dispatcher.getEventHandler().handle(
-new ApplicationEvent(appStartedEvent.getApplicationId(),
-ApplicationEventType.APPLICATION_LOG_HANDLING_INITED));
+case APPLICATION_STARTED:
+  LogHandlerAppStartedEvent appStartedEvent =
+  (LogHandlerAppStartedEvent) event;
+  this.appOwners.put(appStartedEvent.getApplicationId(),
+  appStartedEvent.getUser());
+  this.dispatcher.getEventHandler().handle(
+  new ApplicationEvent(appStartedEvent.getApplicationId(),
+  ApplicationEventType.APPLICATION_LOG_HANDLING_INITED));
+  break;
+case CONTAINER_FINISHED:
+  // Ignore
+  break;
+case APPLICATION_FINISHED:
+  LogHandlerAppFinishedEvent appFinishedEvent =
+  (LogHandlerAppFinishedEvent) event;
+  ApplicationId appId = appFinishedEvent.getApplicationId();
+  String user = appOwners.remove(appId);
+  if (user == null) {
+LOG.error("Unable to locate user for " + appId);
+// send LOG_HANDLING_FAILED out
+NonAggregatingLogHandler.this.dispatcher.getEventHandler().handle(
+new ApplicationEvent(appId,
+ApplicationEventType.APPLICATION_LOG_HANDLING_FAILED));
 break;
-  case CONTAINER_FINISHED:
-// Ignore
-break;
-  case APPLICATION_FINISHED:
-LogHandlerAppFinishedEvent appFinishedEvent =
-(LogHandlerAppFinishedEvent) event;
-ApplicationId appId = appFinishedEvent.getApplicationId();
+  }
+  LogDeleterRunnable logDeleter = new LogDeleterRunnable(user, appId);
+  long appLogSize = calculateSizeOfAppLogs(user, appId);
+  long deletionTimestamp = System.currentTimeMillis()
+  + this.deleteDelaySeconds * 1000;
+  LogDeleterProto deleterProto = LogDeleterProto.newBuilder()
+  .setUser(user)
+  .setDeletionTime(deletionTimestamp)
+  .build();
+  try {
+stateStore.storeLogDeleter(appId, deleterProto);
+  } catch (IOException e) {
+LOG.error("Unable to record log deleter state", e);
+  }
+  // delete no delay if log size exceed deleteThreshold
+  if (enableTriggerDeleteBySize && appLogSize >= deleteThreshold) {

Review Comment:
   Hi @leixm thank you for your update.
   
   1. Can we calculate the size of the application log directory only if the 
feature is enabled?
   2. Can we use `sched.schedule(logDeleter, 0, TimeUnit.SECONDS);` to delete 
the files in background?
   
   The code will be like
   ```java
   try {
 boolean logDeleterStarted = false;
 if (enableTriggerDeleteBySize) {
   final long appLogSize = calculateSizeOfAppLogs(user, appId);
   if (appLogSize >= threshold) {
 ...
 sched.schedule(logDeleter, 0, TimeUnit.SECONDS);
 logDeleterStarted = true;
   }
 }
 if (!logDeleterStarted) {
   sched.schedule(logDeleter, this.deleteDelaySeconds, TimeUnit.SECONDS);
 }
   } catch (RejectedExecutionException e) {
 logDeleter.run();
   }
   ```





> trigger deletion of log-dir by size for NonAggregatingLogHandler
> 
>
> Key: YARN-11277
> URL: https://issues.apache.org/jira/browse/YARN-11277
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.4.0
>Reporter: Xianming Lei
>Priority: Minor
>  Labels: pull-request-available
>
> In our yarn cluster, the log files of some containers are too large, which 
> causes the NodeManager to frequently switch to the unhealthy state. For logs 
> that are too large, we can consider deleting them directly without delaying 
> yarn.nodemanager.log.retain-seconds.
> Cluster environment:
>  # 8k nodes+
>  # 50w+ apps  / day
> Configuration:
>  # yarn.nodemanager.log.retain-seconds=3days
>  # yarn.log-aggregation-enable=false
>  
>  



--
This message 

[jira] [Commented] (YARN-6946) Upgrade JUnit from 4 to 5 in hadoop-yarn-common

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636454#comment-17636454
 ] 

ASF GitHub Bot commented on YARN-6946:
--

ashutoshcipher commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321498614

   Thanks @aajisaka for reviewing and merging.




> Upgrade JUnit from 4 to 5 in hadoop-yarn-common
> ---
>
> Key: YARN-6946
> URL: https://issues.apache.org/jira/browse/YARN-6946
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: test
>Reporter: Akira Ajisaka
>Assignee: Ashutosh Gupta
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: YARN-6946.wip001.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6946) Upgrade JUnit from 4 to 5 in hadoop-yarn-common

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636450#comment-17636450
 ] 

ASF GitHub Bot commented on YARN-6946:
--

aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321492007

   Thank you @ashutoshcipher for your contribution and thank you @slfan1989 for 
your review! Also, thank you for cleaning up bunch of checkstyle issues :)
   
   > hadoop-yarn-project: The patch generated 12 new + 196 unchanged - 171 
fixed = 208 total (was 367)




> Upgrade JUnit from 4 to 5 in hadoop-yarn-common
> ---
>
> Key: YARN-6946
> URL: https://issues.apache.org/jira/browse/YARN-6946
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: test
>Reporter: Akira Ajisaka
>Assignee: Ashutosh Gupta
>Priority: Major
>  Labels: pull-request-available
> Attachments: YARN-6946.wip001.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636448#comment-17636448
 ] 

ASF GitHub Bot commented on YARN-11380:
---

slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321491555

   > The following error is remaining: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
   > 
   > ```
   > [ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5152/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/factory/providers/package-info.java:18:
 error: unknown tag: InterfaceAudience.Private
   > [ERROR] @InterfaceAudience.Private
   > [ERROR] ^
   > ```
   > 
   > Would you fix it?
   
   Thank you very much for your help reviewing the code, I will fix this 
problem.




> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6946) Upgrade JUnit from 4 to 5 in hadoop-yarn-common

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636449#comment-17636449
 ] 

ASF GitHub Bot commented on YARN-6946:
--

aajisaka merged PR #4717:
URL: https://github.com/apache/hadoop/pull/4717




> Upgrade JUnit from 4 to 5 in hadoop-yarn-common
> ---
>
> Key: YARN-6946
> URL: https://issues.apache.org/jira/browse/YARN-6946
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: test
>Reporter: Akira Ajisaka
>Assignee: Ashutosh Gupta
>Priority: Major
>  Labels: pull-request-available
> Attachments: YARN-6946.wip001.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6946) Upgrade JUnit from 4 to 5 in hadoop-yarn-common

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636438#comment-17636438
 ] 

ASF GitHub Bot commented on YARN-6946:
--

ashutoshcipher commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321483949

   > Thank you @ashutoshcipher The test result looks good to me. Could you 
revert the empty line change?
   
   @aajisaka - Done in my last commit.




> Upgrade JUnit from 4 to 5 in hadoop-yarn-common
> ---
>
> Key: YARN-6946
> URL: https://issues.apache.org/jira/browse/YARN-6946
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: test
>Reporter: Akira Ajisaka
>Assignee: Ashutosh Gupta
>Priority: Major
>  Labels: pull-request-available
> Attachments: YARN-6946.wip001.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636439#comment-17636439
 ] 

ASF GitHub Bot commented on YARN-11380:
---

aajisaka commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321483958

   The following error is remaining: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
   ```
   [ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5152/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/factory/providers/package-info.java:18:
 error: unknown tag: InterfaceAudience.Private
   [ERROR] @InterfaceAudience.Private
   [ERROR] ^
   ```
   Would you fix it?




> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6946) Upgrade JUnit from 4 to 5 in hadoop-yarn-common

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636436#comment-17636436
 ] 

ASF GitHub Bot commented on YARN-6946:
--

ashutoshcipher commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321480128

   Thanks @aajisaka I will revert that




> Upgrade JUnit from 4 to 5 in hadoop-yarn-common
> ---
>
> Key: YARN-6946
> URL: https://issues.apache.org/jira/browse/YARN-6946
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: test
>Reporter: Akira Ajisaka
>Assignee: Ashutosh Gupta
>Priority: Major
>  Labels: pull-request-available
> Attachments: YARN-6946.wip001.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6971) Clean up different ways to create resources

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636435#comment-17636435
 ] 

ASF GitHub Bot commented on YARN-6971:
--

riyakhdl commented on PR #5113:
URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1321479727

   @ashutoshcipher Thanks for the review, 
   1. I have done a small performance test to prove it, hence attaching the 
logs.
   
[code_Benchmarking.txt](https://github.com/apache/hadoop/files/10053607/code_Benchmarking.txt)
   
[log_Benchmarking.txt](https://github.com/apache/hadoop/files/10053608/log_Benchmarking.txt)
   
   2. Yes, I have done the changes. 
   
   
   
   > Thanks @riyakhdl for your contribution. I have a couple of comments.
   > 
   > 1. Possible to add any performance stats due to this?
   > 2. I can see you haven't replaced `BuilderUtils.newResource` in all the 
places in YARN module. Can you do that?
   
   




> Clean up different ways to create resources
> ---
>
> Key: YARN-6971
> URL: https://issues.apache.org/jira/browse/YARN-6971
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager, scheduler
>Reporter: Yufei Gu
>Assignee: Riya Khandelwal
>Priority: Minor
>  Labels: newbie, pull-request-available
>
> There are several ways to create a {{resource}} object, e.g., 
> BuilderUtils.newResource() and Resources.createResource(). These methods not 
> only cause confusing but also performance issues, for example 
> BuilderUtils.newResource() is significant slow than 
> Resources.createResource(). 
> We could merge them some how, and replace most BuilderUtils.newResource() 
> with Resources.createResource().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6946) Upgrade JUnit from 4 to 5 in hadoop-yarn-common

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636434#comment-17636434
 ] 

ASF GitHub Bot commented on YARN-6946:
--

aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321479607

   Thank you @ashutoshcipher The test result looks good to me. Could you revert 
the empty line change?




> Upgrade JUnit from 4 to 5 in hadoop-yarn-common
> ---
>
> Key: YARN-6946
> URL: https://issues.apache.org/jira/browse/YARN-6946
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: test
>Reporter: Akira Ajisaka
>Assignee: Ashutosh Gupta
>Priority: Major
>  Labels: pull-request-available
> Attachments: YARN-6946.wip001.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636386#comment-17636386
 ] 

ASF GitHub Bot commented on YARN-11380:
---

hadoop-yetus commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321345447

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  39m 33s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m  3s |  |  trunk passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  compile  |   0m 53s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 57s |  |  trunk passed  |
   | -1 :x: |  javadoc  |   0m 58s | 
[/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt)
 |  hadoop-yarn-api in trunk failed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.  |
   | +1 :green_heart: |  javadoc  |   0m 44s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   2m 15s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 42s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 43s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 48s |  |  the patch passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javac  |   0m 48s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 39s |  |  the patch passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  javac  |   0m 39s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 22s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 
133 unchanged - 26 fixed = 133 total (was 159)  |
   | +1 :green_heart: |  mvnsite  |   0m 43s |  |  the patch passed  |
   | -1 :x: |  javadoc  |   0m 35s | 
[/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt)
 |  hadoop-yarn-api in the patch failed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  |  
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08
 with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08 generated 0 new + 0 
unchanged - 146 fixed = 0 total (was 146)  |
   | +1 :green_heart: |  spotbugs  |   1m 57s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  21m 27s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  2s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 43s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  98m 37s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5152 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 58baf41df37e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | 

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636370#comment-17636370
 ] 

ASF GitHub Bot commented on YARN-11380:
---

slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321285035

   > The Jdk-11 one is still failing
   > 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/1/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
   
   Thank you very much for reviewing the code! I will fix it.




> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6971) Clean up different ways to create resources

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636330#comment-17636330
 ] 

ASF GitHub Bot commented on YARN-6971:
--

hadoop-yetus commented on PR #5113:
URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1321206502

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 59s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 34 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 56s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 59s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  25m 32s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  22m 10s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   4m 28s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m 38s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   4m  9s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   3m 52s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   7m 31s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  24m 41s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  24m 50s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  24m 50s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  22m  9s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |  22m  9s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m 21s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   4m 36s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   4m  6s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   4m 47s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |  12m 50s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  27m 57s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   3m 26s |  |  hadoop-yarn-server-common in 
the patch passed.  |
   | -1 :x: |  unit  | 104m 22s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5113/8/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt)
 |  hadoop-yarn-server-resourcemanager in the patch passed.  |
   | +1 :green_heart: |  unit  |  25m 27s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   8m 56s |  |  hadoop-mapreduce-client-app in 
the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m 12s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 398m 19s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.yarn.server.resourcemanager.TestClientRMService |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5113/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5113 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 1ada1405bae6 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636324#comment-17636324
 ] 

ASF GitHub Bot commented on YARN-11380:
---

ayushtkn commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321204292

   The Jdk-11 one is still failing
   
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/1/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt




> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636305#comment-17636305
 ] 

ASF GitHub Bot commented on YARN-11380:
---

hadoop-yetus commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321169830

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  41m 43s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m  1s |  |  trunk passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  compile  |   0m 51s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   0m 43s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m  1s |  |  trunk passed  |
   | -1 :x: |  javadoc  |   0m 59s | 
[/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/1/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt)
 |  hadoop-yarn-api in trunk failed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.  |
   | +1 :green_heart: |  javadoc  |   0m 44s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   2m 20s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  23m 10s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 39s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 46s |  |  the patch passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javac  |   0m 46s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  |  the patch passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  javac  |   0m 42s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 20s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 
133 unchanged - 19 fixed = 133 total (was 152)  |
   | +1 :green_heart: |  mvnsite  |   0m 42s |  |  the patch passed  |
   | -1 :x: |  javadoc  |   0m 33s | 
[/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/1/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt)
 |  hadoop-yarn-api in the patch failed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08
 with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08 generated 0 new + 0 
unchanged - 146 fixed = 0 total (was 146)  |
   | +1 :green_heart: |  spotbugs  |   1m 59s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  23m  3s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  7s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 44s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 103m 26s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5152/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5152 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux fcbe6bd5fa7d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | 

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636299#comment-17636299
 ] 

ASF GitHub Bot commented on YARN-11380:
---

slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321147063

   @ayushtkn Can you help review this PR? Thank you very much!




> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated YARN-11380:
--
Labels: pull-request-available  (was: )

> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636298#comment-17636298
 ] 

ASF GitHub Bot commented on YARN-11380:
---

slfan1989 opened a new pull request, #5152:
URL: https://github.com/apache/hadoop/pull/5152

   JIRA: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.
   
   When finishing 
[YARN-11373](https://issues.apache.org/jira/browse/YARN-11373), ps has java-doc 
compilation errors, I will fix all java-doc compilation errors of 
hadoop-yarn-api module. I will pay attention to the java doc compilation of 
jdk8 & jdk11 at the same time.
   
   ```
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
(default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
report generation: 
   [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML 
version as HTML 4.01 by using the -html4 option.
   [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
removed
   [ERROR] in a future release. To suppress this warning, please ensure that 
any HTML constructs
   [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
   [ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
 warning: no description for @throws
   [ERROR]* @throws YarnException
   [ERROR]  ^
   [ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
 warning: no description for @throws
   [ERROR]* @throws IOException
   [ERROR]  ^
   [ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
 warning: no description for @throws
   [ERROR]* @throws YarnException
   [ERROR]  ^
   [ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
 warning: no description for @throws
   [ERROR]* @throws IOException 
   ```




> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message 

[jira] [Updated] (YARN-11380) Fix hadoop-yarn-api Java Doc Errors

[fanshilun (Jira)]

 [ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

fanshilun updated YARN-11380:
-
Summary: Fix hadoop-yarn-api  Java Doc Errors  (was: Fix Hadoop-Yarn-Api 
Java Doc Errors)

> Fix hadoop-yarn-api  Java Doc Errors
> 
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-11380) Fix hadoop-yarn-api module Java Doc Errors

[fanshilun (Jira)]

 [ 
https://issues.apache.org/jira/browse/YARN-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

fanshilun updated YARN-11380:
-
Summary: Fix hadoop-yarn-api module Java Doc Errors  (was: Fix 
hadoop-yarn-api  Java Doc Errors)

> Fix hadoop-yarn-api module Java Doc Errors
> --
>
> Key: YARN-11380
> URL: https://issues.apache.org/jira/browse/YARN-11380
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>
> When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
> java-doc compilation errors of hadoop-yarn-api module. I will pay attention 
> to the java doc compilation of jdk8 & jdk11 at the same time.
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
> (default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
> report generation: 
> [ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
> as HTML 4.01 by using the -html4 option.
> [ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
> removed
> [ERROR] in a future release. To suppress this warning, please ensure that any 
> HTML constructs
> [ERROR] in your comments are valid in HTML5, and remove the -html4 option.
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
>  warning: no description for @throws
> [ERROR]* @throws IOException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
>  warning: no description for @throws
> [ERROR]* @throws YarnException
> [ERROR]  ^
> [ERROR] 
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
>  warning: no description for @throws
> [ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Created] (YARN-11380) Fix Hadoop-Yarn-Api Java Doc Errors

[fanshilun (Jira)]

fanshilun created YARN-11380:


 Summary: Fix Hadoop-Yarn-Api Java Doc Errors
 Key: YARN-11380
 URL: https://issues.apache.org/jira/browse/YARN-11380
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: yarn
Affects Versions: 3.4.0
Reporter: fanshilun
Assignee: fanshilun


When finishing YARN-11373, ps has java-doc compilation errors, I will fix all 
java-doc compilation errors of hadoop-yarn-api module. I will pay attention to 
the java doc compilation of jdk8 & jdk11 at the same time.
{code:java}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc-no-fork 
(default-cli) on project hadoop-yarn-api: An error has occurred in Javadoc 
report generation: 
[ERROR] Exit code: 1 - javadoc: warning - You have specified the HTML version 
as HTML 4.01 by using the -html4 option.
[ERROR] The default is currently HTML5 and the support for HTML 4.01 will be 
removed
[ERROR] in a future release. To suppress this warning, please ensure that any 
HTML constructs
[ERROR] in your comments are valid in HTML5, and remove the -html4 option.
[ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:97:
 warning: no description for @throws
[ERROR]* @throws YarnException
[ERROR]  ^
[ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:98:
 warning: no description for @throws
[ERROR]* @throws IOException
[ERROR]  ^
[ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:129:
 warning: no description for @throws
[ERROR]* @throws YarnException
[ERROR]  ^
[ERROR] 
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5146/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationBaseProtocol.java:130:
 warning: no description for @throws
[ERROR]* @throws IOException {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org