[jira] [Commented] (YARN-11424) [Federation] Router AdminCLI Supports DeregisterSubCluster.

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685476#comment-17685476
 ] 

ASF GitHub Bot commented on YARN-11424:
---

hadoop-yetus commented on PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#issuecomment-1421469871

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 47s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  buf  |   0m  0s |  |  buf was not available.  |
   | +0 :ok: |  buf  |   0m  0s |  |  buf was not available.  |
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 4 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m 42s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  33m 41s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  10m 24s |  |  trunk passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  compile  |   8m 46s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   1m 46s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   5m  1s |  |  trunk passed  |
   | -1 :x: |  javadoc  |   0m 54s | 
[/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5363/1/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt)
 |  hadoop-yarn-server-resourcemanager in trunk failed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.  |
   | -1 :x: |  javadoc  |   0m 34s | 
[/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5363/1/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt)
 |  hadoop-yarn-client in trunk failed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.  |
   | +1 :green_heart: |  javadoc  |   4m  4s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   9m 28s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  26m 30s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m  5s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m 57s |  |  the patch passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  cc  |   9m 57s |  |  the patch passed  |
   | -1 :x: |  javac  |   9m 57s | 
[/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5363/1/artifact/out/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt)
 |  
hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 
with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 1 new + 721 
unchanged - 0 fixed = 722 total (was 721)  |
   | +1 :green_heart: |  compile  |   8m 49s |  |  the patch passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  cc  |   8m 49s |  |  the patch passed  |
   | -1 :x: |  javac  |   8m 49s | 
[/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5363/1/artifact/out/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt)
 |  
hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08 
with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08 generated 3 new + 635 
unchanged - 3 fixed = 638 total (was 638)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   1m 39s |  |  
hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 240 u

[jira] [Commented] (YARN-11217) [Federation] Add dumpSchedulerLogs REST APIs for Router

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685407#comment-17685407
 ] 

ASF GitHub Bot commented on YARN-11217:
---

goiri commented on PR #5272:
URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1421190357

   @pjfanning  can you take a final look?




> [Federation] Add dumpSchedulerLogs REST APIs for Router
> ---
>
> Key: YARN-11217
> URL: https://issues.apache.org/jira/browse/YARN-11217
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Affects Versions: 3.4.0, 3.3.4
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-11425) [Federation] Router Supports SubClusterCleaner

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685406#comment-17685406
 ] 

ASF GitHub Bot commented on YARN-11425:
---

goiri commented on code in PR #5326:
URL: https://github.com/apache/hadoop/pull/5326#discussion_r1099001137


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/cleaner/TestSubClusterCleaner.java:
##
@@ -0,0 +1,159 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.yarn.server.router.cleaner;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Time;
+import org.apache.hadoop.yarn.conf.YarnConfiguration;
+import org.apache.hadoop.yarn.exceptions.YarnException;
+import 
org.apache.hadoop.yarn.server.federation.store.impl.MemoryFederationStateStore;
+import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId;
+import org.apache.hadoop.yarn.server.federation.store.records.SubClusterInfo;
+import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterRegisterRequest;
+import org.apache.hadoop.yarn.server.federation.store.records.SubClusterState;
+import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterHeartbeatRequest;
+import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterHeartbeatResponse;
+import 
org.apache.hadoop.yarn.server.federation.utils.FederationStateStoreFacade;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.Map;
+import java.util.concurrent.TimeoutException;
+
+public class TestSubClusterCleaner {
+
+  
+  // Router Constants
+  
+  private Configuration conf;
+  private MemoryFederationStateStore stateStore;
+  private FederationStateStoreFacade facade;
+  private SubClusterCleaner cleaner;
+  private int NUM_SUBCLUSTERS = 4;

Review Comment:
   Checkstyle





> [Federation] Router Supports SubClusterCleaner
> --
>
> Key: YARN-11425
> URL: https://issues.apache.org/jira/browse/YARN-11425
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: federation
>Affects Versions: 3.4.0
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
>  Labels: pull-request-available
>
> In YARN-Federation mode, once a SubCluster is registered, the SubCluster is 
> always in the RUNNING state, even if the SubCluster has no heartbeat for a 
> long time.
> We will let the Router automatically check the heartbeat time of the 
> SubCluster, and once the heartbeat exceeds 30mins, we will set the SubCluster 
> to the SC_LOST state.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-11222) [Federation] Add addToClusterNodeLabels, removeFromClusterNodeLabels REST APIs for Router

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685405#comment-17685405
 ] 

ASF GitHub Bot commented on YARN-11222:
---

goiri commented on code in PR #5328:
URL: https://github.com/apache/hadoop/pull/5328#discussion_r1098999409


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##
@@ -1520,16 +1522,115 @@ public NodeLabelsInfo 
getClusterNodeLabels(HttpServletRequest hsr)
 throw new RuntimeException("getClusterNodeLabels Failed.");
   }
 
+  /**
+   * This method adds specific node labels for specific nodes, and it is
+   * reachable by using {@link RMWSConsts#ADD_NODE_LABELS}.
+   *
+   * @see ResourceManagerAdministrationProtocol#addToClusterNodeLabels
+   * @param newNodeLabels the node labels to add. It is a content param.
+   * @param hsr the servlet request
+   * @return Response containing the status code
+   * @throws Exception in case of bad request
+   */
   @Override
   public Response addToClusterNodeLabels(NodeLabelsInfo newNodeLabels,
   HttpServletRequest hsr) throws Exception {
-throw new NotImplementedException("Code is not implemented");
+
+if (newNodeLabels == null) {
+  routerMetrics.incrAddToClusterNodeLabelsFailedRetrieved();
+  throw new IllegalArgumentException("Parameter error, the newNodeLabels 
is null.");
+}
+
+List nodeLabelInfos = newNodeLabels.getNodeLabelsInfo();
+if (CollectionUtils.isEmpty(nodeLabelInfos)) {
+  routerMetrics.incrAddToClusterNodeLabelsFailedRetrieved();
+  throw new IllegalArgumentException("Parameter error, the nodeLabelsInfo 
is null or empty.");
+}
+
+try {
+  long startTime = clock.getTime();
+  Map subClustersActive = 
getActiveSubclusters();
+  final HttpServletRequest hsrCopy = clone(hsr);
+  Class[] argsClasses = new Class[]{NodeLabelsInfo.class, 
HttpServletRequest.class};
+  Object[] args = new Object[]{newNodeLabels, hsrCopy};
+  ClientMethod remoteMethod = new ClientMethod("addToClusterNodeLabels", 
argsClasses, args);
+  Map responseInfoMap =
+  invokeConcurrent(subClustersActive.values(), remoteMethod, 
Response.class);
+  StringBuffer buffer = new StringBuffer();
+  responseInfoMap.forEach((subClusterInfo, response) -> {
+SubClusterId subClusterId = subClusterInfo.getSubClusterId();
+if (response != null) {
+  buffer.append("SubCluster=" + subClusterId.getId() + ",SUCCESS#");
+} else {
+  buffer.append("SubCluster=" + subClusterId.getId() + ",FAILED#");
+}
+  });
+  long stopTime = clock.getTime();
+  routerMetrics.succeededAddToClusterNodeLabelsRetrieved((stopTime - 
startTime));
+  return Response.status(Status.OK).entity(buffer.toString()).build();
+} catch (NotFoundException e) {
+  routerMetrics.incrAddToClusterNodeLabelsFailedRetrieved();
+  RouterServerUtil.logAndThrowIOException("get all active sub cluster(s) 
error.", e);
+} catch (YarnException e) {
+  routerMetrics.incrAddToClusterNodeLabelsFailedRetrieved();
+  RouterServerUtil.logAndThrowIOException("addToClusterNodeLabels with 
yarn error.", e);
+}
+
+routerMetrics.incrAddToClusterNodeLabelsFailedRetrieved();
+throw new RuntimeException("addToClusterNodeLabels Failed.");
   }
 
+  /**
+   * This method removes all the node labels for specific nodes, and it is
+   * reachable by using {@link RMWSConsts#REMOVE_NODE_LABELS}.
+   *
+   * @see ResourceManagerAdministrationProtocol#removeFromClusterNodeLabels
+   * @param oldNodeLabels the node labels to remove. It is a QueryParam.
+   * @param hsr the servlet request
+   * @return Response containing the status code
+   * @throws Exception in case of bad request
+   */
   @Override
   public Response removeFromClusterNodeLabels(Set oldNodeLabels,
   HttpServletRequest hsr) throws Exception {
-throw new NotImplementedException("Code is not implemented");
+
+if (CollectionUtils.isEmpty(oldNodeLabels)) {
+  routerMetrics.incrRemoveFromClusterNodeLabelsFailedRetrieved();
+  throw new IllegalArgumentException("Parameter error, the oldNodeLabels 
is null or empty.");
+}
+
+try {
+  long startTime = clock.getTime();
+  Map subClustersActive = 
getActiveSubclusters();
+  final HttpServletRequest hsrCopy = clone(hsr);
+  Class[] argsClasses = new Class[]{Set.class, HttpServletRequest.class};
+  Object[] args = new Object[]{oldNodeLabels, hsrCopy};
+  ClientMethod remoteMethod =
+  new ClientMethod("removeFromClusterNodeLabels", argsClasses, args);
+  Map responseInfoMap =
+  invokeConcurrent(subClustersActive.values(), remoteMethod, 
Response.class);
+  StringBuffer buffer = new StringBuffer();
+  respo

[jira] [Commented] (YARN-11424) [Federation] Router AdminCLI Supports DeregisterSubCluster.

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685403#comment-17685403
 ] 

ASF GitHub Bot commented on YARN-11424:
---

goiri commented on code in PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#discussion_r1098998010


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/SubClusterState.java:
##
@@ -55,6 +55,10 @@ public boolean isUnusable() {
 return (this != SC_RUNNING && this != SC_NEW);
   }
 
+  public boolean isUsable() {
+return !isUnusable();

Review Comment:
   Let's remove isUnusable() and always use isUsable with ! and so on.
   Negative methods are usually not recommended.



##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##
@@ -4299,6 +4299,11 @@ public static boolean isAclEnabled(Configuration conf) {
   ROUTER_PREFIX + "interceptor.allow-partial-result.enable";
   public static final boolean 
DEFAULT_ROUTER_INTERCEPTOR_ALLOW_PARTIAL_RESULT_ENABLED = false;
 
+  /** Subcluster timeout allowed by Router.  **/
+  public static final String ROUTER_SUBCLUSTER_EXPIRATION_TIME =
+  ROUTER_PREFIX + "subcluster.heartbeat.expiration.time";
+  public static final long DEFAULT_ROUTER_SUBCLUSTER_EXPIRATION_TIME = 180;

Review Comment:
   Make it TimeUnit



##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java:
##
@@ -37,12 +66,48 @@ public RouterCLI(Configuration conf) {
 super(conf);
   }
 
+  private static void buildHelpMsg(String cmd, StringBuilder builder) {
+UsageInfo usageInfo = ADMIN_USAGE.get(cmd);
+if (usageInfo == null) {
+  return;
+}
+
+if (usageInfo.args != null) {
+  String space = (usageInfo.args == "") ? "" : " ";
+  builder.append("   " + cmd + space + usageInfo.args + ": "
+  + usageInfo.help);
+} else {
+  builder.append("   " + cmd + ": " + usageInfo.help);
+}
+  }
+
+  private static void buildIndividualUsageMsg(String cmd, StringBuilder 
builder) {
+UsageInfo usageInfo = ADMIN_USAGE.get(cmd);
+if (usageInfo == null) {
+  return;
+}
+if (usageInfo.args == null) {
+  builder.append("Usage: routeradmin [" + cmd + "]\n");

Review Comment:
   If we have a StringBuilder, use append not +





> [Federation] Router AdminCLI Supports DeregisterSubCluster.
> ---
>
> Key: YARN-11424
> URL: https://issues.apache.org/jira/browse/YARN-11424
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Affects Versions: 3.4.0
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
>  Labels: pull-request-available
>
> Router provides commands for Deregister SubCluster.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-11424) [Federation] Router AdminCLI Supports DeregisterSubCluster.

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685363#comment-17685363
 ] 

ASF GitHub Bot commented on YARN-11424:
---

slfan1989 commented on PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#issuecomment-1420991561

   @goiri Can you help review this PR? Thank you very much!




> [Federation] Router AdminCLI Supports DeregisterSubCluster.
> ---
>
> Key: YARN-11424
> URL: https://issues.apache.org/jira/browse/YARN-11424
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Affects Versions: 3.4.0
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
>  Labels: pull-request-available
>
> Router provides commands for Deregister SubCluster.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-11424) [Federation] Router AdminCLI Supports DeregisterSubCluster.

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685359#comment-17685359
 ] 

ASF GitHub Bot commented on YARN-11424:
---

slfan1989 commented on PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#issuecomment-1420990268

   @goiri Can you help to merge this pr into the trunk branch? Thank you very 
much!




> [Federation] Router AdminCLI Supports DeregisterSubCluster.
> ---
>
> Key: YARN-11424
> URL: https://issues.apache.org/jira/browse/YARN-11424
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Affects Versions: 3.4.0
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
>  Labels: pull-request-available
>
> Router provides commands for Deregister SubCluster.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-11217) [Federation] Add dumpSchedulerLogs REST APIs for Router

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685361#comment-17685361
 ] 

ASF GitHub Bot commented on YARN-11217:
---

slfan1989 commented on PR #5272:
URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1420990713

   @goiri Can you help to merge this pr into the trunk branch? Thank you very 
much!




> [Federation] Add dumpSchedulerLogs REST APIs for Router
> ---
>
> Key: YARN-11217
> URL: https://issues.apache.org/jira/browse/YARN-11217
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Affects Versions: 3.4.0, 3.3.4
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-11424) [Federation] Router AdminCLI Supports DeregisterSubCluster.

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685357#comment-17685357
 ] 

ASF GitHub Bot commented on YARN-11424:
---

slfan1989 closed pull request #5321: YARN-11424. [Federation] Router Supports 
DeregisterSubCluster.
URL: https://github.com/apache/hadoop/pull/5321




> [Federation] Router AdminCLI Supports DeregisterSubCluster.
> ---
>
> Key: YARN-11424
> URL: https://issues.apache.org/jira/browse/YARN-11424
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Affects Versions: 3.4.0
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
>  Labels: pull-request-available
>
> Router provides commands for Deregister SubCluster.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-11424) [Federation] Router AdminCLI Supports DeregisterSubCluster.

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685356#comment-17685356
 ] 

ASF GitHub Bot commented on YARN-11424:
---

slfan1989 opened a new pull request, #5363:
URL: https://github.com/apache/hadoop/pull/5363

   JIRA: YARN-11424. [Federation] Router Supports DeregisterSubCluster.
   
   In YARN Federation mode, if we want to execute SubCluster commands, we need 
to go to SubCluster RM and execute commands.Router Should Provide Cli commands, 
So that We Can Execute Commands For Different SubClusters.
   
   Router provides commands for Deregister SubCluster.
   
   > yarn routeradmin -help
   https://user-images.githubusercontent.com/55643692/214310783-e137e66b-7810-44f1-b1a5-7fffd1afb55f.png";>
   
   > yarn routeradmin -deregisterSubCluster -c SC-1
   https://user-images.githubusercontent.com/55643692/214290205-6c435abe-fdf6-482e-8451-a3263615592a.png";>
   
   > yarn routeradmin -deregisterSubCluster
   https://user-images.githubusercontent.com/55643692/214290089-55e47ef3-b4e0-4959-9f4f-09b925bd0e9f.png";>
   




> [Federation] Router AdminCLI Supports DeregisterSubCluster.
> ---
>
> Key: YARN-11424
> URL: https://issues.apache.org/jira/browse/YARN-11424
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Affects Versions: 3.4.0
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
>  Labels: pull-request-available
>
> Router provides commands for Deregister SubCluster.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org