[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-09-08 Thread Anuhan Torgonshar (Jira) 


 [ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9349:

Flags:   (was: Important)

> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Fix For: 3.3.0
>
> Attachments: YARN-9349.trunk.patch
>
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> **WARN level**
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
>   log statement line number: 482
>   log level:warn
> **/
> try {
>// queue event requesting init of the same app
>newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
>   log statement line number: 200
>   log level:warn
> **/
> try {
>newState = this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
>   log statement line number: 1156
>   log level:warn
> **/
> try {
> newState =
> stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
> LOG.warn("Can't handle this event at current state: Current: ["
> + oldState + "], eventType: [" + event.getType() + "]", e);
> }
> **ERROR level*
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
> log statement line number:878
> log level: error
> **/
> try {
>/* keep the master in sync with the state machine */
>this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("App attempt: " + appAttemptID
>+ " can't handle this event at current state", e);
>onInvalidTranstion(event.getType(), oldState);
> }
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
> log statement line number:623
> log level: error
> **/
> try {
>stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("Can't handle this event at current state", e);
>LOG.error("Invalid event " + event.getType() + 
>" on Node " + this.nodeId);
> }
>  
> //There are 8 similar code snippets with ERROR log level.
> {code}
> After had a look on whole project, I found that there are 8 similar code 
> snippets assgin the ERROR level, when doTransition() ocurrs 
> *InvalidStateTransitionException*. And there are just 3 places choose  the 
> WARN level when in same situations. Therefor, I think these 3 log statements 
> should be assigned ERROR level to keep consistent with other code snippets.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-9350) Change log level to WARN when ShellCommandExecutor.execute() occurs exception

2019-07-07 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9350:

Issue Type: Bug  (was: Improvement)

> Change log level to WARN when ShellCommandExecutor.execute() occurs exception 
> --
>
> Key: YARN-9350
> URL: https://issues.apache.org/jira/browse/YARN-9350
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: NodeHealthScriptRunner.java, 
> PrivilegedOperationExecutor.java, WindowsBasedProcessTree.java
>
>
> When method ShellCommandExecutor.execute() occurs exception , it has 
> inconsistent log level practices in different places as following :
> {code:java}
> //hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-common\src\main\java\org\apache\hadoop\yarn\util\WindowsBasedProcessTree.java
> //log statement line number:69
> //log level:error
> try {
>shellExecutor.execute();
> } catch (IOException e) {
>LOG.error(StringUtils.stringifyException(e));
> } finally {
>String output = shellExecutor.getOutput();
>if (output != null &&
>output.contains("Prints to stdout a list of processes in the task")) {
>return true;
> }
> //hadoop-2.8.5-src\hadoop-common-project\hadoop-common\src\main\java\org\apache\hadoop\util\NodeHealthScriptRunner.java
> //log statement line number:116
> //log level:warn
> try {
>   shexec.execute();
> } catch (ExitCodeException e) {
>   ..
> } catch (Exception e) {
>LOG.warn("Caught exception : " + e.getMessage());
>if (!shexec.isTimedOut()) {
>  status = HealthCheckerExitStatus.FAILED_WITH_EXCEPTION;
>} else {
>  status = HealthCheckerExitStatus.TIMED_OUT;
>}
>exceptionStackTrace = StringUtils.stringifyException(e);
> } finally {
>..
> }
> //hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\linux\privileged\PrivilegedOperationExecutor.java
> //log statement line number:179
> //log level:warn
> try {
>exec.execute();
>if (LOG.isDebugEnabled()) {
>  LOG.debug("command array:");
>  LOG.debug(Arrays.toString(fullCommandArray));
>  LOG.debug("Privileged Execution Operation Output:");
>  LOG.debug(exec.getOutput());
>}
> } catch (ExitCodeException e) {
>..
> } catch (IOException e) {
> LOG.warn("IOException executing command: ", e);
> throw new PrivilegedOperationException(e);
> }{code}
> There are 2 similar code snippets assign WARN level, when execute() occurs 
> exception, simultaneously only 1 code snippet chooses ERROR level for same 
> situation. Therefore, I think this one log statement is more likely to be 
> assigned WARN level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-9350) Change log level to WARN when ShellCommandExecutor.execute() occurs exception

2019-07-07 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9350:

Issue Type: Improvement  (was: Bug)

> Change log level to WARN when ShellCommandExecutor.execute() occurs exception 
> --
>
> Key: YARN-9350
> URL: https://issues.apache.org/jira/browse/YARN-9350
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: NodeHealthScriptRunner.java, 
> PrivilegedOperationExecutor.java, WindowsBasedProcessTree.java
>
>
> When method ShellCommandExecutor.execute() occurs exception , it has 
> inconsistent log level practices in different places as following :
> {code:java}
> //hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-common\src\main\java\org\apache\hadoop\yarn\util\WindowsBasedProcessTree.java
> //log statement line number:69
> //log level:error
> try {
>shellExecutor.execute();
> } catch (IOException e) {
>LOG.error(StringUtils.stringifyException(e));
> } finally {
>String output = shellExecutor.getOutput();
>if (output != null &&
>output.contains("Prints to stdout a list of processes in the task")) {
>return true;
> }
> //hadoop-2.8.5-src\hadoop-common-project\hadoop-common\src\main\java\org\apache\hadoop\util\NodeHealthScriptRunner.java
> //log statement line number:116
> //log level:warn
> try {
>   shexec.execute();
> } catch (ExitCodeException e) {
>   ..
> } catch (Exception e) {
>LOG.warn("Caught exception : " + e.getMessage());
>if (!shexec.isTimedOut()) {
>  status = HealthCheckerExitStatus.FAILED_WITH_EXCEPTION;
>} else {
>  status = HealthCheckerExitStatus.TIMED_OUT;
>}
>exceptionStackTrace = StringUtils.stringifyException(e);
> } finally {
>..
> }
> //hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\linux\privileged\PrivilegedOperationExecutor.java
> //log statement line number:179
> //log level:warn
> try {
>exec.execute();
>if (LOG.isDebugEnabled()) {
>  LOG.debug("command array:");
>  LOG.debug(Arrays.toString(fullCommandArray));
>  LOG.debug("Privileged Execution Operation Output:");
>  LOG.debug(exec.getOutput());
>}
> } catch (ExitCodeException e) {
>..
> } catch (IOException e) {
> LOG.warn("IOException executing command: ", e);
> throw new PrivilegedOperationException(e);
> }{code}
> There are 2 similar code snippets assign WARN level, when execute() occurs 
> exception, simultaneously only 1 code snippet chooses ERROR level for same 
> situation. Therefore, I think this one log statement is more likely to be 
> assigned WARN level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-9350) Change log level to WARN when ShellCommandExecutor.execute() occurs exception

2019-07-07 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9350:

Issue Type: Bug  (was: Improvement)

> Change log level to WARN when ShellCommandExecutor.execute() occurs exception 
> --
>
> Key: YARN-9350
> URL: https://issues.apache.org/jira/browse/YARN-9350
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: NodeHealthScriptRunner.java, 
> PrivilegedOperationExecutor.java, WindowsBasedProcessTree.java
>
>
> When method ShellCommandExecutor.execute() occurs exception , it has 
> inconsistent log level practices in different places as following :
> {code:java}
> //hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-common\src\main\java\org\apache\hadoop\yarn\util\WindowsBasedProcessTree.java
> //log statement line number:69
> //log level:error
> try {
>shellExecutor.execute();
> } catch (IOException e) {
>LOG.error(StringUtils.stringifyException(e));
> } finally {
>String output = shellExecutor.getOutput();
>if (output != null &&
>output.contains("Prints to stdout a list of processes in the task")) {
>return true;
> }
> //hadoop-2.8.5-src\hadoop-common-project\hadoop-common\src\main\java\org\apache\hadoop\util\NodeHealthScriptRunner.java
> //log statement line number:116
> //log level:warn
> try {
>   shexec.execute();
> } catch (ExitCodeException e) {
>   ..
> } catch (Exception e) {
>LOG.warn("Caught exception : " + e.getMessage());
>if (!shexec.isTimedOut()) {
>  status = HealthCheckerExitStatus.FAILED_WITH_EXCEPTION;
>} else {
>  status = HealthCheckerExitStatus.TIMED_OUT;
>}
>exceptionStackTrace = StringUtils.stringifyException(e);
> } finally {
>..
> }
> //hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\linux\privileged\PrivilegedOperationExecutor.java
> //log statement line number:179
> //log level:warn
> try {
>exec.execute();
>if (LOG.isDebugEnabled()) {
>  LOG.debug("command array:");
>  LOG.debug(Arrays.toString(fullCommandArray));
>  LOG.debug("Privileged Execution Operation Output:");
>  LOG.debug(exec.getOutput());
>}
> } catch (ExitCodeException e) {
>..
> } catch (IOException e) {
> LOG.warn("IOException executing command: ", e);
> throw new PrivilegedOperationException(e);
> }{code}
> There are 2 similar code snippets assign WARN level, when execute() occurs 
> exception, simultaneously only 1 code snippet chooses ERROR level for same 
> situation. Therefore, I think this one log statement is more likely to be 
> assigned WARN level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-04-15 Thread Anuhan Torgonshar (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818478#comment-16818478
 ] 

Anuhan Torgonshar commented on YARN-9349:
-

[~eyang], thanks for your modification. :)

> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: YARN-9349.trunk.patch
>
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> **WARN level**
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
>   log statement line number: 482
>   log level:warn
> **/
> try {
>// queue event requesting init of the same app
>newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
>   log statement line number: 200
>   log level:warn
> **/
> try {
>newState = this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
>   log statement line number: 1156
>   log level:warn
> **/
> try {
> newState =
> stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
> LOG.warn("Can't handle this event at current state: Current: ["
> + oldState + "], eventType: [" + event.getType() + "]", e);
> }
> **ERROR level*
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
> log statement line number:878
> log level: error
> **/
> try {
>/* keep the master in sync with the state machine */
>this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("App attempt: " + appAttemptID
>+ " can't handle this event at current state", e);
>onInvalidTranstion(event.getType(), oldState);
> }
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
> log statement line number:623
> log level: error
> **/
> try {
>stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("Can't handle this event at current state", e);
>LOG.error("Invalid event " + event.getType() + 
>" on Node " + this.nodeId);
> }
>  
> //There are 8 similar code snippets with ERROR log level.
> {code}
> After had a look on whole project, I found that there are 8 similar code 
> snippets assgin the ERROR level, when doTransition() ocurrs 
> *InvalidStateTransitionException*. And there are just 3 places choose  the 
> WARN level when in same situations. Therefor, I think these 3 log statements 
> should be assigned ERROR level to keep consistent with other code snippets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-15 Thread Anuhan Torgonshar (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794078#comment-16794078
 ] 

Anuhan Torgonshar commented on YARN-9349:
-

Hi, [~hudson], the log levels of  three files mentioned in this issue have not 
changed, could you please give a review to them? 

> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: YARN-9349.trunk.patch
>
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> **WARN level**
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
>   log statement line number: 482
>   log level:warn
> **/
> try {
>// queue event requesting init of the same app
>newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
>   log statement line number: 200
>   log level:warn
> **/
> try {
>newState = this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
>   log statement line number: 1156
>   log level:warn
> **/
> try {
> newState =
> stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
> LOG.warn("Can't handle this event at current state: Current: ["
> + oldState + "], eventType: [" + event.getType() + "]", e);
> }
> **ERROR level*
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
> log statement line number:878
> log level: error
> **/
> try {
>/* keep the master in sync with the state machine */
>this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("App attempt: " + appAttemptID
>+ " can't handle this event at current state", e);
>onInvalidTranstion(event.getType(), oldState);
> }
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
> log statement line number:623
> log level: error
> **/
> try {
>stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("Can't handle this event at current state", e);
>LOG.error("Invalid event " + event.getType() + 
>" on Node " + this.nodeId);
> }
>  
> //There are 8 similar code snippets with ERROR log level.
> {code}
> After had a look on whole project, I found that there are 8 similar code 
> snippets assgin the ERROR level, when doTransition() ocurrs 
> *InvalidStateTransitionException*. And there are just 3 places choose  the 
> WARN level when in same situations. Therefor, I think these 3 log statements 
> should be assigned ERROR level to keep consistent with other code snippets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-07 Thread Anuhan Torgonshar (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787600#comment-16787600
 ] 

Anuhan Torgonshar commented on YARN-9349:
-

Hi, [~Prabhu Joseph], I uploaded the patch file, could you give this issue a 
review? Thanks!

> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: YARN-9349.trunk.patch
>
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> **WARN level**
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
>   log statement line number: 482
>   log level:warn
> **/
> try {
>// queue event requesting init of the same app
>newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
>   log statement line number: 200
>   log level:warn
> **/
> try {
>newState = this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
>   log statement line number: 1156
>   log level:warn
> **/
> try {
> newState =
> stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
> LOG.warn("Can't handle this event at current state: Current: ["
> + oldState + "], eventType: [" + event.getType() + "]", e);
> }
> **ERROR level*
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
> log statement line number:878
> log level: error
> **/
> try {
>/* keep the master in sync with the state machine */
>this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("App attempt: " + appAttemptID
>+ " can't handle this event at current state", e);
>onInvalidTranstion(event.getType(), oldState);
> }
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
> log statement line number:623
> log level: error
> **/
> try {
>stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("Can't handle this event at current state", e);
>LOG.error("Invalid event " + event.getType() + 
>" on Node " + this.nodeId);
> }
>  
> //There are 8 similar code snippets with ERROR log level.
> {code}
> After had a look on whole project, I found that there are 8 similar code 
> snippets assgin the ERROR level, when doTransition() ocurrs 
> *InvalidStateTransitionException*. And there are just 3 places choose  the 
> WARN level when in same situations. Therefor, I think these 3 log statements 
> should be assigned ERROR level to keep consistent with other code snippets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-07 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9349:

Attachment: (was: ApplicationImpl.java)

> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: YARN-9349.trunk.patch
>
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> **WARN level**
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
>   log statement line number: 482
>   log level:warn
> **/
> try {
>// queue event requesting init of the same app
>newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
>   log statement line number: 200
>   log level:warn
> **/
> try {
>newState = this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
>   log statement line number: 1156
>   log level:warn
> **/
> try {
> newState =
> stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
> LOG.warn("Can't handle this event at current state: Current: ["
> + oldState + "], eventType: [" + event.getType() + "]", e);
> }
> **ERROR level*
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
> log statement line number:878
> log level: error
> **/
> try {
>/* keep the master in sync with the state machine */
>this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("App attempt: " + appAttemptID
>+ " can't handle this event at current state", e);
>onInvalidTranstion(event.getType(), oldState);
> }
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
> log statement line number:623
> log level: error
> **/
> try {
>stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("Can't handle this event at current state", e);
>LOG.error("Invalid event " + event.getType() + 
>" on Node " + this.nodeId);
> }
>  
> //There are 8 similar code snippets with ERROR log level.
> {code}
> After had a look on whole project, I found that there are 8 similar code 
> snippets assgin the ERROR level, when doTransition() ocurrs 
> *InvalidStateTransitionException*. And there are just 3 places choose  the 
> WARN level when in same situations. Therefor, I think these 3 log statements 
> should be assigned ERROR level to keep consistent with other code snippets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-07 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9349:

Attachment: (was: ContainerImpl.java)

> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: ApplicationImpl.java, YARN-9349.trunk.patch
>
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> **WARN level**
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
>   log statement line number: 482
>   log level:warn
> **/
> try {
>// queue event requesting init of the same app
>newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
>   log statement line number: 200
>   log level:warn
> **/
> try {
>newState = this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
>   log statement line number: 1156
>   log level:warn
> **/
> try {
> newState =
> stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
> LOG.warn("Can't handle this event at current state: Current: ["
> + oldState + "], eventType: [" + event.getType() + "]", e);
> }
> **ERROR level*
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
> log statement line number:878
> log level: error
> **/
> try {
>/* keep the master in sync with the state machine */
>this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("App attempt: " + appAttemptID
>+ " can't handle this event at current state", e);
>onInvalidTranstion(event.getType(), oldState);
> }
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
> log statement line number:623
> log level: error
> **/
> try {
>stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("Can't handle this event at current state", e);
>LOG.error("Invalid event " + event.getType() + 
>" on Node " + this.nodeId);
> }
>  
> //There are 8 similar code snippets with ERROR log level.
> {code}
> After had a look on whole project, I found that there are 8 similar code 
> snippets assgin the ERROR level, when doTransition() ocurrs 
> *InvalidStateTransitionException*. And there are just 3 places choose  the 
> WARN level when in same situations. Therefor, I think these 3 log statements 
> should be assigned ERROR level to keep consistent with other code snippets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-07 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9349:

Attachment: (was: LocalizedResource.java)

> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>  Labels: easyfix
> Attachments: ApplicationImpl.java, YARN-9349.trunk.patch
>
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> **WARN level**
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
>   log statement line number: 482
>   log level:warn
> **/
> try {
>// queue event requesting init of the same app
>newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
>   log statement line number: 200
>   log level:warn
> **/
> try {
>newState = this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> /**
>   file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
>   log statement line number: 1156
>   log level:warn
> **/
> try {
> newState =
> stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
> LOG.warn("Can't handle this event at current state: Current: ["
> + oldState + "], eventType: [" + event.getType() + "]", e);
> }
> **ERROR level*
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
> log statement line number:878
> log level: error
> **/
> try {
>/* keep the master in sync with the state machine */
>this.stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("App attempt: " + appAttemptID
>+ " can't handle this event at current state", e);
>onInvalidTranstion(event.getType(), oldState);
> }
> /**
> file path: 
> hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
> log statement line number:623
> log level: error
> **/
> try {
>stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.error("Can't handle this event at current state", e);
>LOG.error("Invalid event " + event.getType() + 
>" on Node " + this.nodeId);
> }
>  
> //There are 8 similar code snippets with ERROR log level.
> {code}
> After had a look on whole project, I found that there are 8 similar code 
> snippets assgin the ERROR level, when doTransition() ocurrs 
> *InvalidStateTransitionException*. And there are just 3 places choose  the 
> WARN level when in same situations. Therefor, I think these 3 log statements 
> should be assigned ERROR level to keep consistent with other code snippets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Created] (YARN-9350) Change log level to WARN when ShellCommandExecutor.execute() occurs exception

2019-03-06 Thread Anuhan Torgonshar (JIRA) 
Anuhan Torgonshar created YARN-9350:
---

 Summary: Change log level to WARN when 
ShellCommandExecutor.execute() occurs exception 
 Key: YARN-9350
 URL: https://issues.apache.org/jira/browse/YARN-9350
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: yarn
Affects Versions: 2.8.5, 3.1.0
Reporter: Anuhan Torgonshar
 Attachments: NodeHealthScriptRunner.java, 
PrivilegedOperationExecutor.java, WindowsBasedProcessTree.java

When method ShellCommandExecutor.execute() occurs exception , it has 
inconsistent log level practices in different places as following :
{code:java}
//hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-common\src\main\java\org\apache\hadoop\yarn\util\WindowsBasedProcessTree.java
//log statement line number:69
//log level:error
try {
   shellExecutor.execute();
} catch (IOException e) {
   LOG.error(StringUtils.stringifyException(e));
} finally {
   String output = shellExecutor.getOutput();
   if (output != null &&
   output.contains("Prints to stdout a list of processes in the task")) {
   return true;
}

//hadoop-2.8.5-src\hadoop-common-project\hadoop-common\src\main\java\org\apache\hadoop\util\NodeHealthScriptRunner.java
//log statement line number:116
//log level:warn
try {
  shexec.execute();
} catch (ExitCodeException e) {
  ..
} catch (Exception e) {
   LOG.warn("Caught exception : " + e.getMessage());
   if (!shexec.isTimedOut()) {
 status = HealthCheckerExitStatus.FAILED_WITH_EXCEPTION;
   } else {
 status = HealthCheckerExitStatus.TIMED_OUT;
   }
   exceptionStackTrace = StringUtils.stringifyException(e);
} finally {
   ..
}

//hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\linux\privileged\PrivilegedOperationExecutor.java
//log statement line number:179
//log level:warn
try {
   exec.execute();
   if (LOG.isDebugEnabled()) {
 LOG.debug("command array:");
 LOG.debug(Arrays.toString(fullCommandArray));
 LOG.debug("Privileged Execution Operation Output:");
 LOG.debug(exec.getOutput());
   }
} catch (ExitCodeException e) {
   ..
} catch (IOException e) {
LOG.warn("IOException executing command: ", e);
throw new PrivilegedOperationException(e);
}{code}
There are 2 similar code snippets assign WARN level, when execute() occurs 
exception, simultaneously only 1 code snippet chooses ERROR level for same 
situation. Therefore, I think this one log statement is more likely to be 
assigned WARN level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-06 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9349:

Description: 
There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.
{code:java}
**WARN level**
/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
  log statement line number: 482
  log level:warn
**/
try {
   // queue event requesting init of the same app
   newState = stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
  log statement line number: 200
  log level:warn
**/
try {
   newState = this.stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
  log statement line number: 1156
  log level:warn
**/
try {
newState =
stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
LOG.warn("Can't handle this event at current state: Current: ["
+ oldState + "], eventType: [" + event.getType() + "]", e);
}

**ERROR level*
/**
file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
log statement line number:878
log level: error
**/
try {
   /* keep the master in sync with the state machine */
   this.stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.error("App attempt: " + appAttemptID
   + " can't handle this event at current state", e);
   onInvalidTranstion(event.getType(), oldState);
}

/**
file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
log statement line number:623
log level: error
**/
try {
   stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.error("Can't handle this event at current state", e);
   LOG.error("Invalid event " + event.getType() + 
   " on Node " + this.nodeId);
}

 
//There are 8 similar code snippets with ERROR log level.

{code}
After had a look on whole project, I found that there are 8 similar code 
snippets assgin the ERROR level, when doTransition() ocurrs 
*InvalidStateTransitionException*. And there are just 3 places choose  the WARN 
level when in same situations. Therefor, I think these 3 log statements should 
be assigned ERROR level to keep consistent with other code snippets.

  was:
There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.
{code:java}
**WARN level**
/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
  log statement line number: 482
  log level:warn
**/
try {
   // queue event requesting init of the same app
   newState = stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
  log statement line number: 200
  log level:warn
**/
try {
   newState = this.stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
  log statement line number: 1156
  log level:warn
**/
try {
newState =
stateMachine.doTransition(event.getType(), event);
} catch

[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-06 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9349:

Description: 
There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.
{code:java}
**WARN level**
/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
  log statement line number: 482
  log level:warn
**/
try {
   // queue event requesting init of the same app
   newState = stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
  log statement line number: 200
  log level:warn
**/
try {
   newState = this.stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
  log statement line number: 1156
  log level:warn
**/
try {
newState =
stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
LOG.warn("Can't handle this event at current state: Current: ["
+ oldState + "], eventType: [" + event.getType() + "]", e);
}

**ERROR level*
/**
file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
log statement line number:878
log level: error
**/
try {
   /* keep the master in sync with the state machine */
   this.stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.error("App attempt: " + appAttemptID
   + " can't handle this event at current state", e);
   onInvalidTranstion(event.getType(), oldState);
}

/**
file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
log statement line number:623
log level: error
**/
try {
   stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.error("Can't handle this event at current state", e);
   LOG.error("Invalid event " + event.getType() + 
   " on Node " + this.nodeId);
}

 
//There are 8 similar code snippets with ERROR log level.

{code}
After have a look on whole project, I found that there are 8 similar code 
snippets assgin the ERROR level to log statement. And there are just 3 places 
choose  the WARNlevel when in same situations. Therefor, I think these 3 log 
statements should be assigned ERROR level to keep consistent with other code 
snippets.

  was:
There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.
{code:java}
**WARN level**
/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
  log statement line number: 480
  log level:warn
**/
try {
   // queue event requesting init of the same app
   newState = stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
  log statement line number: 200
  log level:warn
**/
try {
   newState = this.stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
  log statement line number: 1156
  log level:warn
**/
try {
newState =
stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {

[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-06 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9349:

  Flags: Important
 Attachment: LocalizedResource.java
 ContainerImpl.java
 ApplicationImpl.java
Description: 
There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.
{code:java}
**WARN level**
/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\application\ApplicationImpl.java
  log statement line number: 480
  log level:warn
**/
try {
   // queue event requesting init of the same app
   newState = stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\localizer\LocalizedResource.java
  log statement line number: 200
  log level:warn
**/
try {
   newState = this.stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}

/**
  file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-nodemanager\src\main\java\org\apache\hadoop\yarn\server\nodemanager\containermanager\container\ContainerImpl.java
  log statement line number: 1156
  log level:warn
**/
try {
newState =
stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
LOG.warn("Can't handle this event at current state: Current: ["
+ oldState + "], eventType: [" + event.getType() + "]", e);
}

**ERROR level*
/**
file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmapp\attempt\RMAppAttemptImpl.java
log statement line number:878
log level: error
**/
try {
   /* keep the master in sync with the state machine */
   this.stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.error("App attempt: " + appAttemptID
   + " can't handle this event at current state", e);
   onInvalidTranstion(event.getType(), oldState);
}

/**
file path: 
hadoop-2.8.5-src\hadoop-yarn-project\hadoop-yarn\hadoop-yarn-server\hadoop-yarn-server-resourcemanager\src\main\java\org\apache\hadoop\yarn\server\resourcemanager\rmnode\RMNodeImpl.java
log statement line number:623
log level: error
**/
try {
   stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.error("Can't handle this event at current state", e);
   LOG.error("Invalid event " + event.getType() + 
   " on Node " + this.nodeId);
}

 
//There are 8 similar code snippets with ERROR log level.

{code}
After have a look on whole project, I found that there are 8 similar code 
snippets assgin the ERROR level to log statement. And there are just 3 places 
choose  the WARNlevel when in same situations. Therefor, I think these 3 log 
statements should be assigned ERROR level to keep consistent with other code 
snippets.

  was:
There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.
{code:java}
//file path: 
hadoop-3.1.0-src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
//log statement line number: 629
try {
   // queue event requesting init of the same app
   newState = stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}


{code}


> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
> Attachments: ApplicationImpl.java, ContainerImpl.java, 
> LocalizedResource.java
>
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> **WARN level**

[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

2019-03-06 Thread Anuhan Torgonshar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuhan Torgonshar updated YARN-9349:

Description: 
There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.
{code:java}
//file path: 
hadoop-3.1.0-src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
//log statement line number: 629
try {
   // queue event requesting init of the same app
   newState = stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}


{code}

  was:There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.

Summary: When doTransition() method occurs exception, the log level 
practices are inconsistent  (was: When doTransition() method occurs exception, 
the log level practices are incon)

> When doTransition() method occurs exception, the log level practices are 
> inconsistent
> -
>
> Key: YARN-9349
> URL: https://issues.apache.org/jira/browse/YARN-9349
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: nodemanager
>Affects Versions: 3.1.0, 2.8.5
>Reporter: Anuhan Torgonshar
>Priority: Major
>
> There are *inconsistent* log level practices when code catches 
> *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> //file path: 
> hadoop-3.1.0-src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
> //log statement line number: 629
> try {
>// queue event requesting init of the same app
>newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>LOG.warn("Can't handle this event at current state", e);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Created] (YARN-9349) When doTransition() method occurs exception, the log level practices are incon

2019-03-06 Thread Anuhan Torgonshar (JIRA) 
Anuhan Torgonshar created YARN-9349:
---

 Summary: When doTransition() method occurs exception, the log 
level practices are incon
 Key: YARN-9349
 URL: https://issues.apache.org/jira/browse/YARN-9349
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: nodemanager
Affects Versions: 2.8.5, 3.1.0
Reporter: Anuhan Torgonshar


There are *inconsistent* log level practices when code catches 
*_InvalidStateTransitionException_* for _*doTransition()*_ method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org